Merge pull request #4 from 1337programming/feature/hmr-support

Feature/hmr support

Author: opiepj

.gitignore

@@ -1,2 +1,6 @@
 node_modules
 npm-debug.log
+*.swf
+.idea/
+.eslintrc.json
+

README.md

@@ -47,10 +47,11 @@ module.exports = config;
 Once the build finishes, a child process is spawned firing both a python and node script.
 
 ### API
-* onBuildStart: **Array[ ]**, array of scripts to execute on the initial build. **Default: [ ]**
-* onBuildEnd: **Array[ ]**, array of scripts to execute after files are emitted. **Default: [ ]**
-* dev: **Boolean**, switch for development environments. This causes scripts to only execute once. Useful for running HMR on webpack-dev-server. **Default: false**
+* onBuildStart: array of scripts to execute on the initial build. **Default: [ ]**
+* onBuildEnd: array of scripts to execute after files are emitted at the end of the compilation. **Default: [ ]**
+* dev: switch for development environments. This causes scripts to only execute once. Useful for running HMR on webpack-dev-server. **Default: true**
+* verbose: enable for verbose output. **Default: false**
 
 ### Contributions
-[Yair Tavor]("http://stackoverflow.com/users/3054454/yair-tavor")
+Yair Tavor
 

index.js

@@ -1,50 +1,81 @@
 var exec = require('child_process').exec;
 
 function puts(error, stdout, stderr) {
-  console.log(stdout);
+  if (error) {
+    console.log('Error: ', error, stderr);
+  }
+  if (this.options.verbose) {
+    console.log(stdout);
+  }
+}
+
+function validateInput(options) {
+  if (typeof options.onBuildStart === 'string') {
+    options.onBuildStart = options.onBuildStart.split('&&');
+  }
+  if (typeof options.onBuildEnd === 'string') {
+    options.onBuildEnd = options.onBuildEnd.split('&&');
+  }
+  return options;
 }
 
 function WebpackShellPlugin(options) {
   var defaultOptions = {
     onBuildStart: [],
     onBuildEnd: [],
-    dev: false
+    dev: true,
+    verbose: false
   };
+
   if (!options.onBuildStart) {
     options.onBuildStart = defaultOptions.onBuildStart;
   }
 
-  if(!options.onBuildEnd) {
+  if (!options.onBuildEnd) {
     options.onBuildEnd = defaultOptions.onBuildEnd;
   }
 
+  options = validateInput(options);
+
+
+  if (!options.dev) {
+    options.dev = defaultOptions.dev;
+  }
+
   this.options = options;
 
 }
 
-WebpackShellPlugin.prototype.apply = function(compiler) {
-  const options = this.options;
+WebpackShellPlugin.prototype.apply = function (compiler) {
+  var options = this.options;
 
   compiler.plugin("compilation", function (compilation) {
-    if(options.onBuildStart.length){
-    console.log("Executing pre-build scripts");
-    options.onBuildStart.forEach(function (script) { exec(script, puts)});
-    if (options.dev) {
-      options.onBuildStart = [];
+    if (options.verbose) {
+      console.log('Report compilation:', compilation);
     }
-  }
-});
+    if (options.onBuildStart.length) {
+      console.log("Executing pre-build scripts");
+      options.onBuildStart.forEach(function (script) {
+        exec(script, puts)
+      });
+      if (options.dev) {
+        options.onBuildStart = [];
+      }
+    }
+  });
 
   compiler.plugin("emit", function (compilation, callback) {
-    if(options.onBuildEnd.length){
-    console.log("Executing post-build scripts");
-    options.onBuildEnd.forEach(function(script){ exec(script, puts)});
-    if (options.dev) {
-      options.onBuildEnd = [];
+    if (options.onBuildEnd.length) {
+      console.log("Executing post-build scripts");
+      options.onBuildEnd.forEach(function (script) {
+        exec(script, puts)
+      });
+      if (options.dev) {
+        options.onBuildEnd = [];
+      }
     }
-  }
-  callback();
-});
+    callback();
+  });
 };
 
 module.exports = WebpackShellPlugin;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack-shell-plugin",
-  "version": "0.2.3",
+  "version": "0.3.0",
   "description": "Run shell commands before and after webpack builds",
   "main": "index.js",
   "scripts": {