refactor: format code.

Author: liqiang-fit2cloud

gotty/backend/localcommand/factory.go

@@ -7,18 +7,21 @@ import (
 	"github.com/KubeOperator/webkubectl/gotty/server"
 )
 
+//Options : close options
 type Options struct {
 	CloseSignal  int `hcl:"close_signal" flagName:"close-signal" flagSName:"" flagDescribe:"Signal sent to the command process when gotty close it (default: SIGHUP)" default:"1"`
 	CloseTimeout int `hcl:"close_timeout" flagName:"close-timeout" flagSName:"" flagDescribe:"Time in seconds to force kill process after client is disconnected (default: -1)" default:"-1"`
 }
 
+//Factory : command factory
 type Factory struct {
 	command string
 	argv    []string
 	options *Options
 	opts    []Option
 }
 
+//NewFactory : create a new factory
 func NewFactory(command string, argv []string, options *Options) (*Factory, error) {
 	opts := []Option{WithCloseSignal(syscall.Signal(options.CloseSignal))}
 	if options.CloseTimeout >= 0 {
@@ -33,10 +36,12 @@ func NewFactory(command string, argv []string, options *Options) (*Factory, erro
 	}, nil
 }
 
+//Name : get name of factory
 func (factory *Factory) Name() string {
 	return "local command"
 }
 
+//New : create a new slave
 func (factory *Factory) New(params map[string][]string) (server.Slave, error) {
 	argv := make([]string, len(factory.argv))
 	copy(argv, factory.argv)

gotty/pkg/randomstring/generate.go

@@ -6,11 +6,12 @@ import (
 	"strconv"
 )
 
+//Generate a random string in specified length
 func Generate(length int) string {
 	const base = 36
 	size := big.NewInt(base)
 	n := make([]byte, length)
-	for i, _ := range n {
+	for i := range n {
 		c, _ := rand.Int(rand.Reader, size)
 		n[i] = strconv.FormatInt(c.Int64(), base)[0]
 	}

gotty/server/handlers.go

@@ -153,7 +153,7 @@ func (server *Server) processWSConn(ctx context.Context, conn *websocket.Conn) e
 		[]string{"server", "master", "slave"},
 		map[string]map[string]interface{}{
 			"server": server.options.TitleVariables,
-			"master": map[string]interface{}{
+			"master": {
 				"remote_addr": conn.RemoteAddr(),
 			},
 			"slave": slave.WindowTitleVariables(),
@@ -204,7 +204,7 @@ func (server *Server) handleIndex(w http.ResponseWriter, r *http.Request) {
 		[]string{"server", "master"},
 		map[string]map[string]interface{}{
 			"server": server.options.TitleVariables,
-			"master": map[string]interface{}{
+			"master": {
 				"remote_addr": r.RemoteAddr,
 			},
 		},

gotty/webtty/webtty.go

@@ -219,7 +219,7 @@ func (wt *WebTTY) handleMasterReadEvent(data []byte) error {
 
 	case Ping:
 		err := wt.masterWrite([]byte{Pong})
-		wt.lastPingTime = time.Now();
+		wt.lastPingTime = time.Now()
 		if err != nil {
 			return errors.Wrapf(err, "failed to return Pong message to master")
 		}

gotty/webtty/webtty_test.go

@@ -120,6 +120,9 @@ func TestWriteFromConn(t *testing.T) {
 	// ping
 	message = []byte("1\n") // line buffered canonical mode
 	n, err = connOutPipeWriter.Write(message)
+	if err != nil {
+		t.Fatalf("Unexpected error from Write(): %s", err)
+	}
 	if n != len(message) {
 		t.Fatalf("Write() accepted `%d` for message `%s`", n, message)
 	}