rename 'fillUrl' to 'fillPageUrl'

johguentner · johguentner · commit 27f61a688d18 · 2021-08-21T20:28:29.000+02:00
- small refactoring was necessary to clarify, that this 'filling' represents the actual page-url of the notion-page and is not a fillable property of a page
diff --git a/src/Entities/Page.php b/src/Entities/Page.php
@@ -106,7 +106,7 @@ private function fillFromRaw(): void
         $this->fillObjectType();
         $this->fillProperties();
         $this->fillTitle(); // This has to be called after fillProperties(), since title is provided by properties
-        $this->fillUrl();
+        $this->fillPageUrl();
         $this->fillCreatedTime();
         $this->fillLastEditedTime();
     }
@@ -160,7 +160,7 @@ private function fillTitle(): void
     /**
      * 
      */
-    private function fillUrl(): void
+    private function fillPageUrl(): void
     {
         if (Arr::exists($this->responseData, 'url')) {
             $this->url = $this->responseData['url'];

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ private function fillFromRaw(): void`
`106`	`106`	`$this->fillObjectType();`
`107`	`107`	`$this->fillProperties();`
`108`	`108`	`$this->fillTitle(); // This has to be called after fillProperties(), since title is provided by properties`
`109`		`- $this->fillUrl();`
	`109`	`+ $this->fillPageUrl();`
`110`	`110`	`$this->fillCreatedTime();`
`111`	`111`	`$this->fillLastEditedTime();`
`112`	`112`	`}`
`@@ -160,7 +160,7 @@ private function fillTitle(): void`
`160`	`160`	`/**`
`161`	`161`	`*`
`162`	`162`	`*/`
`163`		`- private function fillUrl(): void`
	`163`	`+ private function fillPageUrl(): void`
`164`	`164`	`{`
`165`	`165`	`if (Arr::exists($this->responseData, 'url')) {`
`166`	`166`	`$this->url = $this->responseData['url'];`