renamed / condensed collect methods

Author: mechelon

src/Endpoints/Block.php

@@ -25,17 +25,10 @@ public function __construct(Notion $notion, string $blockId)
      * @return BlockCollection
      */
     public function children(): BlockCollection
-    {
-        return $this->collectChildren();
-    }
-
-    private function collectChildren(): BlockCollection
     {
         $response = $this->get(
             $this->url(Endpoint::BLOCKS . "/" . $this->blockId . "/children" . "?{$this->buildPaginationQuery()}")
         );
-        if (!$response->ok())
-            throw HandlingException::instance("Block not found.", ["blockId" => $this->blockId]);
 
         return new BlockCollection($response->json());
     }

src/Endpoints/Databases.php

@@ -28,13 +28,6 @@ class Databases extends Endpoint implements EndpointInterface
      * @return DatabaseCollection
      */
     public function all(): DatabaseCollection
-    {
-        return $this->collect();
-    }
-
-
-    // TODO rename this function - receive, access, fetch?
-    private function collect(): DatabaseCollection
     {
         $resultData = $this->getJson($this->url(Endpoint::DATABASES) . "?{$this->buildPaginationQuery()}");
         return new DatabaseCollection($resultData);

src/Endpoints/Users.php

@@ -21,14 +21,10 @@ class Users extends Endpoint implements EndpointInterface
      */
     public function all(): UserCollection
     {
-        return $this->collect();
-    }
-
-    private function collect(): UserCollection{
         $result = $this->get(
             $this->url(Endpoint::USERS . "?{$this->buildPaginationQuery()}")
         );
-
+        
         return new UserCollection($result->json());
     }
 

src/Entities/Collections/EntityCollection.php

@@ -55,16 +55,11 @@ protected function fillResult()
     }
 
 
-    public function getRaw(): array
+    public function getRawResponse(): array
     {
         return $this->responseData;
     }
 
-    public function asRaw(): array
-    {
-        return $this->rawResults;
-    }
-
     public function asCollection(): Collection
     {
         return $this->collection;