#51: Removed union types in method parameters (temporarily for PHP 7.4 support) and replaced them with corresponding type check; added tests

Author: mechelon

src/Endpoints/Block.php

@@ -78,8 +78,12 @@ public function children(): BlockCollection
      * @return FiveamCode\LaravelNotionApi\Entities\Blocks\Block
      * @throws HandlingException
      */
-    public function append(array|BlockEntity $appendices): BlockEntity
+    public function append($appendices): BlockEntity
     {
+        if(!is_array($appendices) && !$appendices instanceof BlockEntity) {
+            throw new HandlingException('$appendices must be an array or instance of BlockEntity');
+        }
+
         if (!is_array($appendices)) {
             $appendices = [$appendices];
         }

src/Entities/Blocks/Block.php

@@ -224,4 +224,10 @@ private static function mapTypeToClass(string $type): string
                 return Block::class;
         }
     }
+
+    protected static function assertValidTextContent($textContent) {
+        if(!is_array($textContent) && !is_string($textContent)) {
+            throw new HandlingException('$textContent content must be a string.');
+        }
+    }
 }

src/Entities/Blocks/BulletedListItem.php

@@ -8,8 +8,10 @@
  */
 class BulletedListItem extends TextBlock
 {
-    public static function create(array|string $textContent): BulletedListItem
+    public static function create($textContent): BulletedListItem
     {
+        self::assertValidTextContent($textContent);
+
         $bulletedListItem = new BulletedListItem();
         TextBlock::createTextBlock($bulletedListItem, $textContent);
         return $bulletedListItem;

src/Entities/Blocks/HeadingOne.php

@@ -8,8 +8,10 @@
  */
 class HeadingOne extends TextBlock
 {
-    public static function create(array|string $textContent): HeadingOne
+    public static function create($textContent): HeadingOne
     {
+        self::assertValidTextContent($textContent);
+
         $headingOne = new HeadingOne();
         TextBlock::createTextBlock($headingOne, $textContent);
         return $headingOne;

src/Entities/Blocks/HeadingThree.php

@@ -8,8 +8,10 @@
  */
 class HeadingThree extends TextBlock
 {
-    public static function create(array|string $textContent): HeadingThree
+    public static function create($textContent): HeadingThree
     {
+        self::assertValidTextContent($textContent);
+
         $headingThree = new HeadingThree();
         HeadingThree::createTextBlock($headingThree, $textContent);
         return $headingThree;

src/Entities/Blocks/HeadingTwo.php

@@ -8,8 +8,10 @@
  */
 class HeadingTwo extends TextBlock
 {
-    public static function create(array|string $textContent): HeadingTwo
+    public static function create($textContent): HeadingTwo
     {
+        self::assertValidTextContent($textContent);
+
         $headingTwo = new HeadingTwo();
         HeadingTwo::createTextBlock($headingTwo, $textContent);
         return $headingTwo;

src/Entities/Blocks/NumberedListItem.php

@@ -8,8 +8,10 @@
  */
 class NumberedListItem extends TextBlock
 {
-    public static function create(array|string $textContent): NumberedListItem
+    public static function create($textContent): NumberedListItem
     {
+        self::assertValidTextContent($textContent);
+
         $numberedListItem = new NumberedListItem();
         TextBlock::createTextBlock($numberedListItem, $textContent);
         return $numberedListItem;

src/Entities/Blocks/Paragraph.php

@@ -8,8 +8,10 @@
  */
 class Paragraph extends TextBlock
 {
-    public static function create(array|string $textContent): Paragraph
+    public static function create($textContent): Paragraph
     {
+        self::assertValidTextContent($textContent);
+
         $paragraph = new Paragraph();
         TextBlock::createTextBlock($paragraph, $textContent);
         return $paragraph;

src/Entities/Blocks/TextBlock.php

@@ -11,8 +11,10 @@
  */
 class TextBlock extends Block implements Modifiable
 {
-    protected static function createTextBlock(TextBlock $textBlock, array|string $textContent): TextBlock
+    protected static function createTextBlock(TextBlock $textBlock, $textContent): TextBlock
     {
+        self::assertValidTextContent($textContent);
+
         if (is_string($textContent)) {
             $textContent = [$textContent];
         }

src/Entities/Blocks/ToDo.php

@@ -8,8 +8,10 @@
  */
 class ToDo extends TextBlock
 {
-    public static function create(array|string $textContent): ToDo
+    public static function create($textContent): ToDo
     {
+        self::assertValidTextContent($textContent);
+
         $toDo = new ToDo();
         TextBlock::createTextBlock($toDo, $textContent);
         return $toDo;