Skip to content

Commit d7cf814

Browse files
committed
fix tests for get_iib_metrics function
1 parent b56bc2c commit d7cf814

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

tests/test_iib_metrics_client.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ class TestGetIIBMetrics(unittest.TestCase):
4141
pushgateway_port = '9091'
4242
mqsilist_command = str()
4343
bip_codes_brokers = dict()
44+
bip_codes_components = dict()
4445

4546
Mocked = MockFunction()
4647
@patch('iib_metrics_client.logger.info', side_effect=Mocked.mock_logging_info)
@@ -53,15 +54,14 @@ def test_get_iib_metrics(
5354
mock_put_metric_to_gateway):
5455
"""Tests for `get_iib_metrics` function."""
5556
with patch('iib_metrics_client.get_brokers_status') as mock_get_brokers_status:
56-
bip_codes_components = get_platform_params_for_commands(iib_ver='9')[2]
5757
mock_get_brokers_status.return_value = [['TEST', 'running', 'TEST']]
5858
self.assertEqual(
5959
get_iib_metrics(
6060
pushgateway_host=self.pushgateway_host,
6161
pushgateway_port=self.pushgateway_port,
6262
mqsilist_command=self.mqsilist_command,
6363
bip_codes_brokers=self.bip_codes_brokers,
64-
bip_codes_components= bip_codes_components),
64+
bip_codes_components= self.bip_codes_components),
6565
None)
6666
mock_get_brokers_status.return_value = [['TEST', 'stopped', 'TEST']]
6767
self.assertEqual(
@@ -70,7 +70,7 @@ def test_get_iib_metrics(
7070
pushgateway_port=self.pushgateway_port,
7171
mqsilist_command=self.mqsilist_command,
7272
bip_codes_brokers=self.bip_codes_brokers,
73-
bip_codes_components= bip_codes_components),
73+
bip_codes_components= self.bip_codes_components),
7474
None)
7575

7676
@patch('iib_metrics_client.logger.info', side_effect=Mocked.mock_logging_info)
@@ -85,15 +85,17 @@ def test_get_iib_metrics_exception(self, mock_logging_info, mock_logging_error):
8585
pushgateway_host=self.pushgateway_host,
8686
pushgateway_port=self.pushgateway_port,
8787
mqsilist_command=self.mqsilist_command,
88-
bip_codes_brokers=self.bip_codes_brokers)
88+
bip_codes_brokers=self.bip_codes_brokers,
89+
bip_codes_components= self.bip_codes_components)
8990
mock_iib_command.side_effect = Exception()
9091
self.assertRaises(
9192
Exception,
9293
get_iib_metrics,
9394
pushgateway_host=self.pushgateway_host,
9495
pushgateway_port=self.pushgateway_port,
9596
mqsilist_command=self.mqsilist_command,
96-
bip_codes_brokers=self.bip_codes_brokers)
97+
bip_codes_brokers=self.bip_codes_brokers,
98+
bip_codes_components= self.bip_codes_components)
9799

98100

99101
class TestPutMetricToGateway(unittest.TestCase):

0 commit comments

Comments
 (0)