eslint

Author: mymindstorm

.eslintignore

@@ -2,3 +2,8 @@ node_modules
 dist
 firefox
 chrome
+scripts
+webpack.config.js
+webpack.prod.js
+src/test
+src/models/credentials.ts

.eslintrc.js

@@ -15,5 +15,9 @@ module.exports = {
   env: {
     "amd": true,
     "node": true  
+  },
+  rules: {
+    "@typescript-eslint/no-use-before-define": "off",
+    "@typescript-eslint/explicit-function-return-type": "off"
   }
 };

src/argon.ts

@@ -10,13 +10,13 @@ window.addEventListener("message", event => {
 
   switch (message.action) {
     case "hash":
-      argon.hash(message.value).then(hash => {
+      Argon.hash(message.value).then(hash => {
         source.postMessage({ response: hash }, event.origin);
       });
       break;
 
     case "verify":
-      argon.compareHash(message.hash, message.value).then(result => {
+      Argon.compareHash(message.hash, message.value).then(result => {
         source.postMessage({ response: result }, event.origin);
       });
       break;
@@ -27,7 +27,7 @@ window.addEventListener("message", event => {
   return;
 });
 
-class argon {
+class Argon {
   static async hash(value: string) {
     const salt = window.crypto.getRandomValues(new Uint8Array(16));
     const hash = await argon2.hash({

src/background.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line @typescript-eslint/ban-ts-ignore
 // @ts-ignore
 import QRCode from "qrcode-reader";
 
@@ -157,8 +158,8 @@ async function getTotp(text: string) {
           }
           issuer = issuer.replace(/\+/g, " ");
         } else if (parameter[0].toLowerCase() === "counter") {
-          let counter = Number(parameter[1]);
-          counter = isNaN(counter) || counter < 0 ? 0 : counter;
+          // let counter = Number(parameter[1]);
+          // counter = isNaN(counter) || counter < 0 ? 0 : counter;
         } else if (parameter[0].toLowerCase() === "period") {
           period = Number(parameter[1]);
           period =
@@ -426,18 +427,15 @@ async function uploadBackup(service: string) {
 
   switch (service) {
     case "dropbox":
-      const dbox = new Dropbox();
-      await dbox.upload(encryption);
+      await new Dropbox().upload(encryption);
       break;
 
     case "drive":
-      const drive = new Drive();
-      await drive.upload(encryption);
+      await new Drive().upload(encryption);
       break;
 
     case "onedrive":
-      const onedrive = new OneDrive();
-      await onedrive.upload(encryption);
+      await new OneDrive().upload(encryption);
       break;
 
     default:

src/components/Import.vue

@@ -59,7 +59,7 @@ export default Vue.extend({
   }
 });
 
-function shouldShowPassphrase(entries: IOTPEntry[]) {
+function shouldShowPassphrase(entries: OTPEntryInterface[]) {
   for (const entry of entries) {
     if (!entry.secret) {
       return true;

src/components/Popup/PrefrencesPage.vue

@@ -68,7 +68,7 @@ export default Vue.extend({
         this.$store.commit("menu/setHighContrast", useHighContrast);
       }
     },
-    encryption(): IEncryption {
+    encryption(): EncryptionInterface {
       return this.$store.state.accounts.encryption;
     },
     enforceAutolock() {

src/content.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line @typescript-eslint/ban-ts-ignore
 // @ts-ignore
 import scanGIF from "../images/scan.gif";
 
@@ -26,7 +27,7 @@ if (!document.getElementById("__ga_grayLayout__")) {
       case "pastecode":
         pasteCode(message.code);
         break;
-      case "stopCapture":
+      case "stopCapture": {
         const captureBox = document.getElementById("__ga_captureBox__");
         if (captureBox) {
           captureBox.style.display = "none";
@@ -37,6 +38,7 @@ if (!document.getElementById("__ga_grayLayout__")) {
           grayLayout.style.display = "none";
         }
         break;
+      }
       default:
         // invalid command, ignore it
         break;

src/definitions/BackupProvider.d.ts

@@ -1,4 +1,4 @@
 interface BackupProvider {
-  upload(encryption: IEncryption): Promise<boolean>;
+  upload(encryption: EncryptionInterface): Promise<boolean>;
   getUser(): Promise<string>;
 }

src/definitions/module-interface.d.ts

@@ -1,9 +1,10 @@
-interface IModule {
+interface Module {
   getModule(): Promise<VuexConstructor> | VuexConstructor;
 }
 
 interface VuexConstructor {
   state?: {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     [key: string]: any;
   };
   mutations?: {
@@ -13,76 +14,77 @@ interface VuexConstructor {
     [key: string]:
       | Function
       | {
-          root: Boolean;
+          root: boolean;
           handler: Function;
         };
   };
   getters?: {
     [key: string]: Function;
   };
-  modules?: Object;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  modules?: Record<string, any>;
   plugins?: Array<Function>;
-  strict?: Boolean;
-  devtools?: Boolean;
+  strict?: boolean;
+  devtools?: boolean;
 }
 
 interface MenuState {
-  version: String;
-  zoom: Number;
-  autolock: Number;
-  useAutofill: Boolean;
-  useHighContrast: Boolean;
-  backupDisabled: Boolean;
-  storageArea: String;
+  version: string;
+  zoom: number;
+  autolock: number;
+  useAutofill: boolean;
+  useHighContrast: boolean;
+  backupDisabled: boolean;
+  storageArea: string;
 }
 
 interface StyleState {
   style: {
-    timeout: Boolean;
-    isEditing: Boolean;
-    slidein: Boolean;
-    slideout: Boolean;
-    fadein: Boolean;
-    fadeout: Boolean;
-    show: Boolean;
-    qrfadein: Boolean;
-    qrfadeout: Boolean;
-    notificationFadein: Boolean;
-    notificationFadeout: Boolean;
-    hotpDisabled: Boolean;
+    timeout: boolean;
+    isEditing: boolean;
+    slidein: boolean;
+    slideout: boolean;
+    fadein: boolean;
+    fadeout: boolean;
+    show: boolean;
+    qrfadein: boolean;
+    qrfadeout: boolean;
+    notificationFadein: boolean;
+    notificationFadeout: boolean;
+    hotpDisabled: boolean;
   };
 }
 
 interface AccountsState {
-  entries: IOTPEntry[];
-  encryption: IEncryption;
-  OTPType: Number;
-  shouldShowPassphrase: Boolean;
-  sectorStart: Boolean;
-  sectorOffset: Number;
-  second: Number;
-  notification: String;
-  filter: Boolean;
+  entries: OTPEntryInterface[];
+  encryption: EncryptionInterface;
+  OTPType: number;
+  shouldShowPassphrase: boolean;
+  sectorStart: boolean;
+  sectorOffset: number;
+  second: number;
+  notification: string;
+  filter: boolean;
   siteName: (string | null)[];
-  showSearch: Boolean;
-  exportData: { [k: string]: IOTPEntry };
-  exportEncData: { [k: string]: IOTPEntry };
+  showSearch: boolean;
+  exportData: { [k: string]: OTPEntryInterface };
+  exportEncData: { [k: string]: OTPEntryInterface };
   key: { enc: string; hash: string } | null;
-  wrongPassword: Boolean;
+  wrongPassword: boolean;
 }
 
 interface NotificationState {
   message: Array<string>;
-  confirmMessage: String;
-  messageIdle: Boolean;
-  notification: String;
+  confirmMessage: string;
+  messageIdle: boolean;
+  notification: string;
 }
 
 interface BackupState {
-  dropboxEncrypted: Boolean;
-  driveEncrypted: Boolean;
-  oneDriveEncrypted: Boolean;
-  dropboxToken: Boolean;
-  driveToken: Boolean;
-  oneDriveToken: Boolean;
+  dropboxEncrypted: boolean;
+  driveEncrypted: boolean;
+  oneDriveEncrypted: boolean;
+  dropboxToken: boolean;
+  driveToken: boolean;
+  oneDriveToken: boolean;
 }

src/definitions/otp.d.ts

@@ -1,4 +1,4 @@
-interface IOTPEntry {
+interface OTPEntryInterface {
   type: number; // OTPType
   index: number;
   issuer: string;
@@ -14,14 +14,14 @@ interface IOTPEntry {
   create(): Promise<void>;
   update(): Promise<void>;
   next(): Promise<void>;
-  applyEncryption(encryption: IEncryption): void;
-  changeEncryption(encryption: IEncryption): void;
+  applyEncryption(encryption: EncryptionInterface): void;
+  changeEncryption(encryption: EncryptionInterface): void;
   delete(): Promise<void>;
   generate(): void;
   genUUID(): void;
 }
 
-interface IEncryption {
+interface EncryptionInterface {
   getEncryptedString(data: string): string;
   getDecryptedSecret(entry: OTPStorage): string | null;
   getEncryptionStatus(): boolean;