Skip to content

Commit 0aba259

Browse files
Samiya CaurDevtools-frontend LUCI CQ
authored andcommitted
Enable e2e test for overrides_test
Fixed: 350617272 Change-Id: Ifad2dd49e0a1b72cd001a150f41624086ecef8e1 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6597914 Auto-Submit: Samiya Caur <samiyac@chromium.org> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org> Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
1 parent 13f2194 commit 0aba259

File tree

1 file changed

+27
-30
lines changed

1 file changed

+27
-30
lines changed

test/e2e/sources/overrides_test.ts

Lines changed: 27 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -402,36 +402,33 @@ describe('Overrides panel', function() {
402402
await waitFor('[aria-label="Close sourcemap-origin.min.js"]');
403403
});
404404

405-
// crbug.com/350617272
406-
it.skipOnPlatforms(
407-
['mac'], '[crbug.com/350617272]: show redirect dialog when override content of source mapped css file',
408-
async () => {
409-
await goToResource('sources/sourcemap-origin.html');
410-
await openSourcesPanel();
411-
await enableLocalOverrides();
412-
413-
await openNetworkTab();
414-
await waitForSomeRequestsToAppear(4);
415-
await waitForOverrideContentMenuItemIsEnabled('sourcemap-origin.css');
416-
await click('aria/Open in Sources panel');
417-
418-
// Actual file > Has override content
419-
const file = await waitFor('[aria-label="sourcemap-origin.css"]');
420-
await file.click({button: 'right'});
421-
await click('aria/Close');
422-
423-
// Source mapped file > Show redirect confirmation dialog
424-
const mappedfile = await waitFor('[aria-label="sourcemap-origin.scss, file"]');
425-
await mappedfile.click({button: 'right'});
426-
await click('aria/Override content');
427-
const p = await waitFor('.dimmed-pane');
428-
const dialog = await p.waitForSelector('>>>> [role="dialog"]');
429-
const okButton = await dialog?.waitForSelector('>>> devtools-button');
430-
const okButtonTextContent = await okButton?.evaluate(e => e.textContent);
431-
assert.deepEqual(okButtonTextContent, 'OK');
432-
await okButton?.click();
433-
await waitFor('[aria-label="Close sourcemap-origin.css"]');
434-
});
405+
it('show redirect dialog when override content of source mapped css file', async () => {
406+
await goToResource('sources/sourcemap-origin.html');
407+
await openSourcesPanel();
408+
await enableLocalOverrides();
409+
410+
await openNetworkTab();
411+
await waitForSomeRequestsToAppear(4);
412+
await waitForOverrideContentMenuItemIsEnabled('sourcemap-origin.css');
413+
await click('aria/Open in Sources panel');
414+
415+
// Actual file > Has override content
416+
const file = await waitFor('[aria-label="sourcemap-origin.css"]');
417+
await file.click({button: 'right'});
418+
await click('aria/Close');
419+
420+
// Source mapped file > Show redirect confirmation dialog
421+
const mappedfile = await waitFor('[aria-label="sourcemap-origin.scss, file"]');
422+
await mappedfile.click({button: 'right'});
423+
await click('aria/Override content');
424+
const p = await waitFor('.dimmed-pane');
425+
const dialog = await p.waitForSelector('>>>> [role="dialog"]');
426+
const okButton = await dialog?.waitForSelector('>>> devtools-button');
427+
const okButtonTextContent = await okButton?.evaluate(e => e.textContent);
428+
assert.deepEqual(okButtonTextContent, 'OK');
429+
await okButton?.click();
430+
await waitFor('[aria-label="Close sourcemap-origin.css"]');
431+
});
435432
});
436433

437434
describe('Overrides panel', () => {

0 commit comments

Comments
 (0)