Skip to content

Commit 6d3155a

Browse files
Connor ClarkDevtools-frontend LUCI CQ
authored andcommitted
Catch resolveSourceMap promise if errors
There is no known way this promise errors, but just in case, catch and ignore any error that may occur so that the trace analysis doesn't needlessly fail. Bug: 416107350 Change-Id: I81369345035c9361c496838fb69bd72c0d419d7a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6527147 Commit-Queue: Connor Clark <cjamcl@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Auto-Submit: Connor Clark <cjamcl@chromium.org>
1 parent c4b4c9e commit 6d3155a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

front_end/models/trace/handlers/ScriptsHandler.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,9 @@ export async function finalize(options: Types.Configuration.ParseOptions): Promi
281281
script.sourceMap = sourceMap;
282282
}
283283
});
284-
promises.push(promise);
284+
promises.push(promise.catch(e => {
285+
console.error('Uncaught error when resolving source map', params, e);
286+
}));
285287
}
286288
await Promise.all(promises);
287289
}

0 commit comments

Comments
 (0)