Commit 83670e8
Fix window size in unit tests
The window size was not fixed for unit tests
resulting in a different viewport being used when tests
run in headless. Since our tests run in an iframe, rendering
something that exceeds the iframe height would cause the bounding
box of the elements becoming larger that the viewport resulting
in screenshots containing parts of the parent iframe.
Bug: none
Change-Id: Ifee7587e67a5e68aedee572cfaa0fa18a4a54bd5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6597734
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>1 parent 6993884 commit 83670e8
File tree
21 files changed
+37
-33
lines changed- front_end/ui/components/dialogs
- test
- interactions/goldens/linux
- persistence
- protocol_monitor
- timeline
- unit
21 files changed
+37
-33
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
417 | 417 | | |
418 | 418 | | |
419 | 419 | | |
420 | | - | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
438 | | - | |
439 | | - | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | | - | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
450 | | - | |
451 | | - | |
452 | | - | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
453 | 456 | | |
454 | 457 | | |
455 | 458 | | |
| |||
Loading
Loading
0 commit comments