Look for stack frames to parse without looking for Error

Previously we searched for a message to start with a word
ending in "Error" to determine if it was an error and we
should look for stack frames. With this change we make no
assumptions about what an error is named and just look for
stack frames instead.

Bug: 406029201
Change-Id: I7c31c6b4cd4a9137227a99baf34626cdd51dbc16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6563869
Commit-Queue: Eric Leese <leese@chromium.org>
Auto-Submit: Eric Leese <leese@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>

Author: Eric Leese

front_end/panels/console/ErrorStackParser.test.ts

@@ -35,14 +35,13 @@ describe('ErrorStackParser', () => {
     assert.isNull(parseErrorStack('foobar'));
   });
 
-  it('returns null if the first word does not end in "Error"', () => {
-    assert.isNull(parseErrorStack('CustomFoo: bar'));
+  it('returns null if there are no stack frames', () => {
+    assert.isNull(parseErrorStack('Error: bar'));
   });
 
-  it('accepts stacks with any "*Error" as its first word', () => {
-    assert.isNotNull(parseErrorStack('Error: standard error'));
-    assert.isNotNull(parseErrorStack('ReferenceError: unknown variable'));
-    assert.isNotNull(parseErrorStack('CustomError: foobar'));
+  it('accepts stacks if the first word of any line after the first line is "at"', () => {
+    assert.isNotNull(parseErrorStack('!\nat foo'));
+    assert.isNotNull(parseErrorStack('ReferenceError:\n    at foo'));
   });
 
   it('omits position information for frames it cannot parse', () => {

front_end/panels/console/ErrorStackParser.ts

@@ -32,7 +32,7 @@ export interface ParsedErrorFrame {
  */
 export function parseSourcePositionsFromErrorStack(
     runtimeModel: SDK.RuntimeModel.RuntimeModel, stack: string): ParsedErrorFrame[]|null {
-  if (!/^[\w.]*Error\b/.test(stack)) {
+  if (!(/\n\s*at\s/.test(stack) || stack.startsWith('SyntaxError:'))) {
     return null;
   }
   const debuggerModel = runtimeModel.debuggerModel();