Skip to content

Commit d87f11a

Browse files
Samiya CaurDevtools-frontend LUCI CQ
authored andcommitted
Enable skipped test for Performance -> Sources navigation
Fixed: 327072692 Change-Id: I792e46cc17fc748e83355e41a9bca1eeca904867 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6597436 Auto-Submit: Samiya Caur <samiyac@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Samiya Caur <samiyac@chromium.org>
1 parent 46c8304 commit d87f11a

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

test/e2e/cross_tool_integration/workflow_test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ describe('A user can navigate across', function() {
4747
await waitFor('.panel[aria-label="sources"]');
4848
});
4949

50-
// Flaky test.
51-
it.skip('[crbug.com/327072692] Performance -> Sources', async () => {
50+
it('Performance -> Sources', async () => {
5251
await navigateToPerformanceTab();
5352

5453
await startRecording();
@@ -69,7 +68,7 @@ describe('A user can navigate across', function() {
6968

7069
await stopRecording();
7170

72-
await navigateToBottomUpTab();
71+
await navigateToBottomUpTab(undefined, 'script-location');
7372

7473
await click('.devtools-link[title*="default.html"]');
7574
await waitFor('.panel[aria-label="sources"]');

test/e2e/helpers/performance-helpers.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,8 @@ export async function searchForComponent(
120120
undefined, devToolsPage);
121121
}
122122

123-
export async function navigateToBottomUpTab(devToolsPage: DevToolsPage = getBrowserAndPagesWrappers().devToolsPage) {
123+
export async function navigateToBottomUpTab(
124+
devToolsPage: DevToolsPage = getBrowserAndPagesWrappers().devToolsPage, veLinkContext: string) {
124125
await devToolsPage.click(BOTTOM_UP_SELECTOR);
125126
await expectVeEvents(
126127
[
@@ -148,7 +149,7 @@ export async function navigateToBottomUpTab(devToolsPage: DevToolsPage = getBrow
148149
[
149150
veImpression('TableCell', 'self'),
150151
veImpression('TableCell', 'total'),
151-
veImpression('TableCell', 'activity', [veImpression('Link', 'url')]),
152+
veImpression('TableCell', 'activity', [veImpression('Link', veLinkContext)]),
152153
]),
153154
]),
154155
]),

test/e2e/performance/timeline/treeView_test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe('The Performance tool, Bottom-up panel', function() {
6565
const expectedActivities = ['h2', 'H2', 'h2_with_suffix'];
6666

6767
await step('navigate to the Bottom-up tab', async () => {
68-
await navigateToBottomUpTab();
68+
await navigateToBottomUpTab(undefined, 'url');
6969
});
7070

7171
await step('click on the "Match Case" button and validate activities', async () => {
@@ -85,7 +85,7 @@ describe('The Performance tool, Bottom-up panel', function() {
8585
const allActivities = ['H2', 'h2_with_suffix', 'h2'];
8686

8787
await step('navigate to the Bottom-up tab', async () => {
88-
await navigateToBottomUpTab();
88+
await navigateToBottomUpTab(undefined, 'url');
8989
});
9090

9191
await step('click on the "Regex Button" and validate activities', async () => {
@@ -105,7 +105,7 @@ describe('The Performance tool, Bottom-up panel', function() {
105105
const expectedActivities = ['h2', 'H2'];
106106

107107
await step('navigate to the Bottom-up tab', async () => {
108-
await navigateToBottomUpTab();
108+
await navigateToBottomUpTab(undefined, 'url');
109109
});
110110

111111
await step('click on the "Match whole word" and validate activities', async () => {
@@ -126,7 +126,7 @@ describe('The Performance tool, Bottom-up panel', function() {
126126
const expectedActivities = ['H2', 'h2_with_suffix', 'h2'];
127127

128128
await step('navigate to the Bottom-up tab', async () => {
129-
await navigateToBottomUpTab();
129+
await navigateToBottomUpTab(undefined, 'url');
130130
});
131131

132132
await step('validate activities', async () => {
@@ -144,7 +144,7 @@ describe('The Performance tool, Bottom-up panel', function() {
144144
it('group by', async () => {
145145
const expectedActivities = ['Scripting', 'System', 'Rendering', 'Painting', 'Loading'];
146146
await step('navigate to the Bottom-up tab', async () => {
147-
await navigateToBottomUpTab();
147+
await navigateToBottomUpTab(undefined, 'url');
148148
});
149149

150150
await step('use group-by drop down and validate activities', async () => {
@@ -169,7 +169,7 @@ describe('The Performance tool, Bottom-up panel', function() {
169169
const expectedActivities = ['h2_with_suffix', 'container2', 'Function call', 'Timer fired', 'Profiling overhead'];
170170

171171
await step('navigate to the Bottom-up tab', async () => {
172-
await navigateToBottomUpTab();
172+
await navigateToBottomUpTab(undefined, 'url');
173173
});
174174

175175
await step('validate that top level activities have the right context', async () => {
@@ -196,7 +196,7 @@ describe('The Performance tool, Bottom-up panel', function() {
196196
const expectedActivities = ['Commit', 'Function call', 'h2_with_suffix', 'h2', 'H2', 'Layerize', 'Layout'];
197197

198198
await step('navigate to the Bottom-up tab', async () => {
199-
await navigateToBottomUpTab();
199+
await navigateToBottomUpTab(undefined, 'url');
200200
});
201201

202202
await step('validate activities', async () => {

test/e2e_non_hosted/performance/wasm/performance_profiling_test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ describe('The Performance panel', function() {
104104
await setupPerformancePanel(devToolsPage, inspectedPage);
105105
const expectedActivities = ['mainWasm', 'js-to-wasm::i', '(anonymous)', 'Run microtasks'];
106106

107-
await navigateToBottomUpTab(devToolsPage);
107+
await navigateToBottomUpTab(devToolsPage, 'url');
108108

109109
const timelineTree = await devToolsPage.$('.timeline-tree-view') as puppeteer.ElementHandle<HTMLSelectElement>;
110110
const rootActivity = await devToolsPage.waitForElementWithTextContent(expectedActivities[0], timelineTree);

0 commit comments

Comments
 (0)