Skip to content

Commit c863e26

Browse files
author
Cache Hamm
committed
Simplify engine success flow control and promise handling
1 parent ee85634 commit c863e26

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/engine.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,10 +191,9 @@ class Engine extends EventEmitter {
191191
return rule.evaluate(almanac).then((ruleResult) => {
192192
debug(`engine::run ruleResult:${ruleResult.result}`)
193193
if (ruleResult.result) {
194-
return Promise.all([
195-
almanac.addSuccessEvent(ruleResult.event),
196-
this.emitAsync('success', ruleResult.event, almanac, ruleResult)
197-
]).then(() => this.emitAsync(ruleResult.event.type, ruleResult.event.params, almanac, ruleResult))
194+
almanac.addSuccessEvent(ruleResult.event)
195+
return this.emitAsync('success', ruleResult.event, almanac, ruleResult)
196+
.then(() => this.emitAsync(ruleResult.event.type, ruleResult.event.params, almanac, ruleResult))
198197
} else {
199198
return this.emitAsync('failure', ruleResult.event, almanac, ruleResult)
200199
}

0 commit comments

Comments
 (0)