rule.id allow for "0" id rules

Author: Cache Hamm

src/rule.js

@@ -36,7 +36,12 @@ class Rule extends EventEmitter {
       this.setName(options.name)
     }
 
-    this.setId(options ? options.id : null)
+    if (!options || options.id === undefined) {
+      // auto generate an id if none was provided
+      this.setId('_' + Math.random().toString(36).substr(2, 9))
+    } else {
+      this.setId(options.id)
+    }
 
     const priority = (options && options.priority) || 1
     this.setPriority(priority)
@@ -61,11 +66,7 @@ class Rule extends EventEmitter {
    * @param {any} id - any truthy input
    */
   setId (id) {
-    if (!id) {
-      this.id = '_' + Math.random().toString(36).substr(2, 9)
-    } else {
-      this.id = id
-    }
+    this.id = id
     return this
   }
 

test/engine.test.js

@@ -93,11 +93,7 @@ describe('Engine', () => {
       engine.updateRule(rule)
       expect(engine.rules[0].conditions.all.length).to.equal(0)
     })
-    it('should generate id for rule if not provided', () => {
-      const rule = new Rule(factories.rule())
-      expect(rule.id).to.not.equal(null)
-      expect(rule.id).to.not.equal(undefined)
-    })
+
     it('should throw error if rule not found', () => {
       const rule1 = new Rule(factories.rule())
       engine.addRule(rule1)

test/rule.test.js

@@ -54,6 +54,27 @@ describe('Rule', () => {
       expect(rule.ruleEvent).to.eql(opts.event)
       expect(rule.name).to.eql(opts.name)
     })
+
+    context('id', () => {
+      it('autogenerates an id if none was provided', () => {
+        const rule = new Rule()
+        expect(rule.id).to.have.lengthOf(10)
+      })
+
+      it('sets the id if provided', () => {
+        let rule = new Rule({ id: 'test-id' })
+        expect(rule.id).to.equal('test-id')
+
+        rule = new Rule({ id: 0 })
+        expect(rule.id).to.equal(0)
+
+        rule = new Rule({ id: '' })
+        expect(rule.id).to.equal('')
+
+        rule = new Rule({ id: null })
+        expect(rule.id).to.equal(null)
+      })
+    })
   })
 
   describe('event emissions', () => {
@@ -96,6 +117,24 @@ describe('Rule', () => {
     })
   })
 
+  describe('setId()', () => {
+    it('changes the rule id', () => {
+      const newId = 'test-id-123'
+      rule.setId(newId)
+      expect(rule.id).to.equal(newId)
+    })
+  })
+
+  describe('setEvent()', () => {
+    it('throws if no argument provided', () => {
+      expect(() => rule.setEvent()).to.throw(/Rule: setEvent\(\) requires event object/)
+    })
+
+    it('throws if argument is missing "type" property', () => {
+      expect(() => rule.setEvent({})).to.throw(/Rule: setEvent\(\) requires event object with "type" property/)
+    })
+  })
+
   describe('setConditions()', () => {
     describe('validations', () => {
       it('throws an exception for invalid root conditions', () => {