modify: 코드래빗 리뷰 1차 반영

Author: Jihyun3478

src/services/__test__/qr.service.test.ts

@@ -2,6 +2,7 @@ import { UserService } from '@/services/user.service';
 import { UserRepository } from '@/repositories/user.repository';
 import { DBError } from '@/exception';
 import { QRLoginToken } from '@/types/models/QRLoginToken.type';
+import { Pool } from 'pg';
 
 jest.mock('@/repositories/user.repository');
 
@@ -10,7 +11,8 @@ describe('UserService', () => {
   let repo: jest.Mocked<UserRepository>;
 
   beforeEach(() => {
-    const repoInstance = new UserRepository({} as any);
+    const mockPool = {} as jest.Mocked<Pool>;
+    const repoInstance = new UserRepository(mockPool);
     repo = repoInstance as jest.Mocked<UserRepository>;
     service = new UserService(repo);
   });

src/services/user.service.ts

@@ -125,8 +125,8 @@ export class UserService {
     return await this.userRepo.updateTokens(userData.id, userData.accessToken, userData.refreshToken);
   }
 
-  public getDecryptedTokens(userId: number, accessToken: string, refreshToken: string) {  
-    return this.decryptTokens(userId, accessToken, refreshToken);  
+  public getDecryptedTokens(groupId: number, accessToken: string, refreshToken: string) {  
+    return this.decryptTokens(groupId, accessToken, refreshToken);  
   }
 
   async create(userId: number, ip: string, userAgent: string): Promise<string> {

src/utils/generateRandomToken.util.ts

@@ -1,8 +1,11 @@
+import crypto from 'crypto';
+
 export function generateRandomToken(length: number = 10): string {
     const chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';
     let result = '';
+    const randomBytes = crypto.randomBytes(length);
     for (let i = 0; i < length; i++) {
-      result += chars.charAt(Math.floor(Math.random() * chars.length));
+      result += chars.charAt(randomBytes[i] % chars.length);
     }
     return result;
   }