fix: lint 오류 수정 및 응답 형식 통일

Author: Jihyun3478

src/controllers/svg.controller.ts

@@ -1,25 +1,26 @@
-import { NextFunction, Request, RequestHandler, Response } from "express";
+import { NextFunction, RequestHandler, Request, Response } from "express";
 import logger from '@/configs/logger.config'
-import { GetSvgBadgeParams, GetSvgBadgeQuery } from "@/types";
+import { GetSvgBadgeQuery, BadgeDataResponseDto } from "@/types";
 import { SvgService } from '@/services/svg.service';
 
 export class SvgController {
     constructor(private svgService: SvgService) {}
 
-    getSvgBadge: RequestHandler<GetSvgBadgeParams, any, any, GetSvgBadgeQuery> = async (
-        req: Request<GetSvgBadgeParams, object, object, GetSvgBadgeQuery>,
-        res: Response,
+    getSvgBadge: RequestHandler<{ username: string }, BadgeDataResponseDto, object, GetSvgBadgeQuery> = async (
+        req: Request<{ username: string }, BadgeDataResponseDto, object, GetSvgBadgeQuery>,
+        res: Response<BadgeDataResponseDto>,
         next: NextFunction,
     ) => {
         try {
             const { username } = req.params;
             const { type = 'default'} = req.query;
 
             const data = await this.svgService.getBadgeData(username, type);
+            const response = new BadgeDataResponseDto(true, '배지 데이터 조회에 성공하였습니다.', data, null);
 
-            res.json(data);
+            res.status(200).json(response);
         } catch (error) {
-            logger.error('SVG Badge 생성 실패: ', error);
+            logger.error('SVG Badge 조회 실패:', error);
             next(error);
         }
     }

src/services/svg.service.ts

@@ -1,5 +1,5 @@
 import logger from '@/configs/logger.config';
-import { BadgeDataResponseDto, SvgBadgeType } from '@/types';
+import { SvgBadgeType, BadgeData } from '@/types';
 import { LeaderboardRepository } from '@/repositories/leaderboard.repository';
 
 export class SvgService {
@@ -9,15 +9,15 @@ export class SvgService {
         username: string,
         type: SvgBadgeType,
         dateRange: number = 30,
-    ): Promise<BadgeDataResponseDto> {
+    ): Promise<BadgeData> {
         try {
             const userStats = await this.leaderboardRepo.getUserStats(username, dateRange);
             const recentPosts = type === 'default'
                 ? await this.leaderboardRepo.getRecentPosts(username, dateRange, 3)
                 : [];
 
-            return new BadgeDataResponseDto(
-                {
+            return {
+                user: {
                     username: userStats.username,
                     totalViews: Number(userStats.total_views),
                     totalLikes: Number(userStats.total_likes),
@@ -26,14 +26,14 @@ export class SvgService {
                     likeDiff: Number(userStats.like_diff),
                     postDiff: Number(userStats.post_diff),
                 },
-                recentPosts.map(post => ({
+                recentPosts: recentPosts.map(post => ({
                     title: post.title,
                     releasedAt: post.released_at,
                     viewCount: Number(post.today_view),
                     likeCount: Number(post.today_like),
                     viewDiff: Number(post.view_diff),
                 }))
-            )
+            };
         } catch (error) {
             logger.error('SvgService getBadgeData error: ', error);
             throw error;

src/types/dto/responses/svgResponse.type.ts

@@ -1,3 +1,5 @@
+import { BaseResponseDto } from '@/types/dto/responses/baseResponse.type';
+
 export interface BadgeUserData {
     username: string;
     totalViews: number;
@@ -16,12 +18,13 @@ export interface BadgeRecentPost {
     viewDiff: number;
 }
 
-export class BadgeDataResponseDto {
+export interface BadgeData {
     user: BadgeUserData;
     recentPosts: BadgeRecentPost[];
+}
 
-    constructor(user: BadgeUserData, recentPosts: BadgeRecentPost[]) {
-        this.user = user;
-        this.recentPosts = recentPosts;
+export class BadgeDataResponseDto extends BaseResponseDto<BadgeData | null> {
+    constructor(success: boolean, message: string, data: BadgeData | null, error: string | null) {
+        super(success, message, data, error);
     }
-}
+}

src/types/index.ts

@@ -41,7 +41,7 @@ export { TotalStatsResponseDto } from '@/types/dto/responses/totalStatsResponse.
 // SVG 관련
 export type { GetSvgBadgeParams, GetSvgBadgeQuery, SvgBadgeType } from '@/types/dto/requests/svgRequest.type';
 export { GetSvgBadgeQueryDto } from '@/types/dto/requests/svgRequest.type';
-export type { BadgeUserData, BadgeRecentPost } from '@/types/dto/responses/svgResponse.type';
+export type { BadgeUserData, BadgeRecentPost, BadgeData } from '@/types/dto/responses/svgResponse.type';
 export { BadgeDataResponseDto } from '@/types/dto/responses/svgResponse.type';
 
 // Sentry 관련