Skip to content

Commit b08d834

Browse files
committed
refactor: findByVelogUUID & getDecryptedTokens 메서드 병합
1 parent c20e48e commit b08d834

File tree

2 files changed

+17
-16
lines changed

2 files changed

+17
-16
lines changed

src/controllers/user.controller.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -146,15 +146,9 @@ export class UserController {
146146
if (!found) {
147147
throw new TokenExpiredError();
148148
}
149-
150-
const user = await this.userService.findByVelogUUID(found.user.toString());
151-
if (!user) throw new NotFoundError('유저를 찾을 수 없습니다.');
152-
153-
const { decryptedAccessToken, decryptedRefreshToken } = this.userService.getDecryptedTokens(
154-
user.group_id,
155-
user.access_token,
156-
user.refresh_token
157-
);
149+
150+
const { user, decryptedAccessToken, decryptedRefreshToken } =
151+
await this.userService.findUserAndTokensByVelogUUID(found.user.toString());
158152

159153
res.clearCookie('access_token', this.cookieOption());
160154
res.clearCookie('refresh_token', this.cookieOption());

src/services/user.service.ts

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class UserService {
5353
async handleUserTokensByVelogUUID(userData: UserWithTokenDto) {
5454
const { id, email, accessToken, refreshToken } = userData;
5555
try {
56-
let user = await this.findByVelogUUID(id);
56+
let user = await this.userRepo.findByUserVelogUUID(id);
5757

5858
if (!user) {
5959
user = await this.createUser({
@@ -82,10 +82,6 @@ export class UserService {
8282
}
8383
}
8484

85-
async findByVelogUUID(uuid: string): Promise<User | null> {
86-
return await this.userRepo.findByUserVelogUUID(uuid);
87-
}
88-
8985
async findSampleUser(): Promise<SampleUser> {
9086
const user = await this.userRepo.findSampleUser();
9187
if (!user) {
@@ -125,8 +121,19 @@ export class UserService {
125121
return await this.userRepo.updateTokens(userData.id, userData.accessToken, userData.refreshToken);
126122
}
127123

128-
public getDecryptedTokens(groupId: number, accessToken: string, refreshToken: string) {
129-
return this.decryptTokens(groupId, accessToken, refreshToken);
124+
async findUserAndTokensByVelogUUID(uuid: string): Promise<{ user: User; decryptedAccessToken: string; decryptedRefreshToken: string }> {
125+
const user = await this.userRepo.findByUserVelogUUID(uuid);
126+
if (!user) {
127+
throw new NotFoundError('유저를 찾을 수 없습니다.');
128+
}
129+
130+
const { decryptedAccessToken, decryptedRefreshToken } = this.decryptTokens(
131+
user.group_id,
132+
user.access_token,
133+
user.refresh_token,
134+
);
135+
136+
return { user, decryptedAccessToken, decryptedRefreshToken };
130137
}
131138

132139
async create(userId: number, ip: string, userAgent: string): Promise<string> {

0 commit comments

Comments
 (0)