[25.08.01 / TASK-209] Test - 주간 트렌드 분석 및 주간 사용자 게시글 분석 배치 단위테스트 구현 (#39)

* modify: 트렌드 분석 성공 로그 추가

* test: 주간 트렌드 분석 배치 단위테스트 구현

* test: 주간 사용자 게시글 분석 배치 단위테스트 구현

* refactor: 본문 데이터 수집 성공 케이스 제거

* test: TokenExpiredError에 대한 테스트 케이스 추가

* modify: TokenExpiredError에 대한 테스트 케이스 수정

* modify: side_impact가 아닌 return_value를 사용하도록 수정

* refactor: fetch, analyze, save로 클래스 각각 분리

* refactor: conftest 파일 분리

* refactor: 사용하지 않는 import 제거

* modify: 기존 fixture를 재사용하도록 수정

* refactor: 루트 conftest 리팩토링

* refactor: 루트 conftest 리팩토링

Author: Jihyun3478

insight/tasks/weekly_trend_analysis.py

@@ -149,6 +149,7 @@ async def _analyze_data(
                 trending_summary=trending_items, trend_analysis=trend_analysis
             )
 
+            self.logger.info("Trend analysis completed: %s items", len(trending_items))
             return [result]  # 주간 트렌드는 하나의 결과만 생성
 
         except Exception as e:

insight/tests/conftest.py

@@ -1,6 +1,7 @@
 import sys
 import uuid
-from unittest.mock import MagicMock
+from datetime import datetime
+from unittest.mock import MagicMock, AsyncMock
 
 import pytest
 from django.conf import settings
@@ -240,3 +241,40 @@ def empty_insight_weekly_trend(db):
     return WeeklyTrend.objects.create(
         week_start_date=week_start, week_end_date=week_end, insight={}
     )
+
+@pytest.fixture
+def mock_post():
+    """테스트용 게시글 목록 응답 (get_trending_posts 용)"""
+    return MagicMock(
+        id="abc123",
+        title="test title",
+        views=100,
+        likes=10,
+        user=MagicMock(username="tester"),
+        thumbnail="thumbnail",
+        url_slug="test",
+    )
+
+@pytest.fixture
+def mock_post_detail():
+    """테스트용 게시글 본문 응답 (get_post 용)"""
+    return MagicMock(body="test content")
+
+@pytest.fixture
+def mock_context(mock_post, mock_post_detail):
+    """VelogClient 및 날짜 mock을 포함한 컨텍스트"""
+    mock_velog_client = AsyncMock()
+    mock_velog_client.get_trending_posts.return_value = [mock_post]
+    mock_velog_client.get_post.return_value = mock_post_detail
+
+    mock_context = MagicMock()
+    mock_context.velog_client = mock_velog_client
+    mock_context.week_start.date.return_value = "2025-07-21"
+    mock_context.week_end.date.return_value = "2025-07-27"
+    mock_context.week_end = datetime(2025, 7, 27)
+    return mock_context
+
+@pytest.fixture
+def trending_post_data(mock_post, mock_post_detail):
+    from insight.tasks.weekly_trend_analysis import TrendingPostData
+    return TrendingPostData(post=mock_post, body=mock_post_detail.body)

insight/tests/tasks/weekly_trend/conftest.py

@@ -0,0 +1,7 @@
+import pytest
+
+
+@pytest.fixture
+def analyzer():
+    from insight.tasks.weekly_trend_analysis import WeeklyTrendAnalyzer
+    return WeeklyTrendAnalyzer(trending_limit=1)

insight/tests/tasks/weekly_trend/test_weekly_trend_analyze.py

@@ -0,0 +1,58 @@
+from unittest.mock import MagicMock, patch
+
+import pytest
+from insight.models import WeeklyTrendInsight, TrendAnalysis
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("mock_setup_django")
+class TestWeeklyTrendAnalyze:
+    @patch("insight.tasks.weekly_trend_analysis.analyze_trending_posts")
+    async def test_analyze_data_success(
+        self, mock_llm, analyzer, trending_post_data, sample_weekly_trend_insight
+    ):
+        """LLM 분석 성공 테스트"""
+        mock_llm.return_value = sample_weekly_trend_insight.to_json_dict()
+
+        context = MagicMock()
+        with patch.object(analyzer, "logger") as mock_logger:
+            result = await analyzer._analyze_data(
+                [trending_post_data], context
+            )
+
+        assert len(result) == 1
+        insight = result[0]
+        assert insight.trend_analysis.hot_keywords == ["Python", "Django", "React"]
+        assert insight.trending_summary[0].summary == "Django 백엔드와 React 프론트엔드를 연결하는 방법"
+        mock_logger.info.assert_called()
+
+    @patch("insight.tasks.weekly_trend_analysis.analyze_trending_posts")
+    async def test_analyze_data_with_summary_length_mismatch_fallback(
+        self, mock_llm, analyzer, trending_post_data, sample_trending_items
+    ):
+        """LLM이 반환한 요약 개수가 원본보다 적을 때, 누락된 항목이 fallback 처리되는지 테스트"""
+        mock_llm.return_value = WeeklyTrendInsight(
+            trending_summary=[sample_trending_items[0]],
+            trend_analysis=TrendAnalysis(hot_keywords=[], title_trends="", content_trends="", insights=""),
+        ).to_json_dict()
+
+        mock_context = MagicMock()
+        with patch.object(analyzer, "logger") as mock_logger:
+            result = await analyzer._analyze_data(
+                [trending_post_data, trending_post_data], mock_context
+            )
+            mock_logger.info.assert_called()
+
+        assert len(result[0].trending_summary) == 2
+
+    @patch("insight.tasks.weekly_trend_analysis.analyze_trending_posts")
+    async def test_analyze_data_failure(
+        self, mock_llm, analyzer, trending_post_data
+    ):
+        """LLM 분석 중 예외 발생 시, 예외가 로깅되고 다시 전파되는지 테스트"""
+        mock_llm.side_effect = Exception("LLM Error")
+
+        with patch.object(analyzer, "logger") as mock_logger:
+            with pytest.raises(Exception):
+                await analyzer._analyze_data([trending_post_data], MagicMock())
+            mock_logger.error.assert_called()

insight/tests/tasks/weekly_trend/test_weekly_trend_fetch.py

@@ -0,0 +1,36 @@
+from unittest.mock import patch
+
+import pytest
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("mock_setup_django")
+class TestWeeklyTrendFetch:
+    async def test_fetch_data_when_fail_get_post_detail(
+        self, analyzer, mock_context
+    ):
+        """게시글 본문 조회 실패 시, body 없이 기본 데이터로 대체되는지 테스트"""
+        mock_context.velog_client.get_post.side_effect = Exception(
+            "fetch error"
+        )
+
+        with patch.object(analyzer, "logger") as mock_logger:
+            result = await analyzer._fetch_data(mock_context)
+
+        assert len(result) == 1
+        assert result[0].body == ""
+        mock_logger.warning.assert_called()
+
+    async def test_fetch_data_failure_with_empty_body(
+        self, analyzer, mock_context
+    ):
+        """게시글 본문이 비었을 경우, warning 로그 출력 확인 테스트"""
+        mock_context.velog_client.get_post.return_value.body = ""
+
+        with patch.object(analyzer, "logger") as mock_logger:
+            result = await analyzer._fetch_data(mock_context)
+
+        assert result[0].body == ""
+        mock_logger.warning.assert_called_with(
+            "Post %s has empty body", "abc123"
+        )

insight/tests/tasks/weekly_trend/test_weekly_trend_save.py

@@ -0,0 +1,66 @@
+from datetime import date, datetime
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("mock_setup_django")
+class TestWeeklyTrendSave:
+    @patch("insight.tasks.weekly_trend_analysis.WeeklyTrend.objects.create")
+    async def test_save_results_success(
+        self, mock_create, analyzer, mock_context
+    ):
+        """분석 결과 저장 성공 테스트"""
+        trending_item = MagicMock()
+        trending_item.to_dict.return_value = {"title": "test"}
+
+        trend_analysis = MagicMock()
+        trend_analysis.to_dict.return_value = {"insights": "Good"}
+
+        result = MagicMock(
+            trending_summary=[trending_item], trend_analysis=trend_analysis
+        )
+
+        with patch.object(analyzer, "logger") as mock_logger:
+            await analyzer._save_results([result], mock_context)
+
+        mock_create.assert_called_once_with(
+            week_start_date="2025-07-21",
+            week_end_date=date(2025, 7, 27),
+            insight={
+                "trending_summary": [{"title": "test"}],
+                "trend_analysis": {"insights": "Good"},
+            },
+            is_processed=False,
+            processed_at=datetime(2025, 7, 27),
+        )
+        mock_logger.info.assert_called()
+
+    @patch(
+        "insight.tasks.weekly_trend_analysis.WeeklyTrend.objects.create",
+        side_effect=Exception("DB error"),
+    )
+    async def test_save_results_failure(
+        self, mock_create, analyzer, mock_context
+    ):
+        """DB 저장 중 예외 발생 시, 로그 출력 및 예외 전파되는지 테스트"""
+        result = MagicMock(
+            trending_summary=[MagicMock(to_dict=lambda: {"title": "test"})],
+            trend_analysis=MagicMock(to_dict=lambda: {"insights": "fail"}),
+        )
+
+        with patch.object(analyzer, "logger") as mock_logger:
+            with pytest.raises(Exception):
+                await analyzer._save_results([result], mock_context)
+            mock_logger.error.assert_called()
+
+    async def test_save_results_when_results_empty(
+        self, analyzer, mock_context
+    ):
+        """분석 결과가 없을 경우, DB 저장 로직이 호출되지 않는지 테스트"""
+        with patch(
+            "insight.tasks.weekly_trend_analysis.WeeklyTrend.objects.create"
+        ) as mock_create:
+            await analyzer._save_results([], mock_context)
+            mock_create.assert_not_called()

insight/tests/tasks/weekly_user_trend/conftest.py

@@ -0,0 +1,7 @@
+import pytest
+
+
+@pytest.fixture
+def analyzer_user():
+    from insight.tasks.weekly_user_trend_analysis import UserWeeklyAnalyzer
+    return UserWeeklyAnalyzer()

insight/tests/tasks/weekly_user_trend/test_weekly_user_trend_analyze.py

@@ -0,0 +1,147 @@
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from insight.models import WeeklyUserStats
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("mock_setup_django")
+class TestWeeklyUserTrendAnalyze:
+    @patch("insight.tasks.weekly_user_trend_analysis.Post.objects")
+    @patch("insight.tasks.weekly_user_trend_analysis.PostDailyStatistics.objects")
+    async def test_calculate_user_weekly_total_stats_success(
+        self, mock_stats, mock_posts, analyzer_user, mock_context
+    ):
+        """사용자 주간 전체 통계 계산 성공 테스트"""
+        mock_posts.filter.return_value.values_list.return_value = [1, 2]
+        mock_posts.filter.return_value.count.return_value = 1
+        mock_stats.filter.return_value.values.return_value = [
+            {
+                "post_id": 1,
+                "date": mock_context.week_start,
+                "daily_view_count": 10,
+                "daily_like_count": 5,
+            },
+            {
+                "post_id": 1,
+                "date": mock_context.week_end,
+                "daily_view_count": 15,
+                "daily_like_count": 10,
+            },
+        ]
+
+        stats = await analyzer_user._calculate_user_weekly_total_stats(
+            1, mock_context
+        )
+        assert isinstance(stats, WeeklyUserStats)
+        assert stats.posts == 1
+        assert stats.views == 5
+        assert stats.likes == 5
+        assert stats.new_posts == 1
+
+    @patch("insight.tasks.weekly_user_trend_analysis.Post.objects")
+    @patch("insight.tasks.weekly_user_trend_analysis.PostDailyStatistics.objects")
+    async def test_calculate_user_weekly_total_stats_missing_stats(
+        self, mock_stats, mock_posts, analyzer_user, mock_context
+    ):
+        """통계가 누락된 경우, 조회수와 좋아요 수가 0으로 처리되는지 테스트"""
+        mock_posts.filter.return_value.values_list.return_value = [1]
+        mock_posts.filter.return_value.count.return_value = 1
+        mock_stats.filter.return_value.values.return_value = []
+
+        stats = await analyzer_user._calculate_user_weekly_total_stats(
+            1, mock_context
+        )
+        assert stats.views == 0
+        assert stats.likes == 0
+
+    @patch("insight.tasks.weekly_user_trend_analysis.Post.objects")
+    @patch("insight.tasks.weekly_user_trend_analysis.PostDailyStatistics.objects")
+    async def test_calculate_user_weekly_total_stats_ignores_negative_diff(
+        self, mock_stats, mock_posts, analyzer_user, mock_context
+    ):
+        """조회수나 좋아요 수가 감소한 경우, 0으로 처리하여 음수 결과를 방지하는지 테스트"""
+        mock_posts.filter.return_value.values_list.return_value = [1]
+        mock_posts.filter.return_value.count.return_value = 1
+        mock_stats.filter.return_value.values.return_value = [
+            {
+                "post_id": 1,
+                "date": mock_context.week_start,
+                "daily_view_count": 200,
+                "daily_like_count": 100,
+            },
+            {
+                "post_id": 1,
+                "date": mock_context.week_end,
+                "daily_view_count": 180,
+                "daily_like_count": 90,
+            },
+        ]
+
+        stats = await analyzer_user._calculate_user_weekly_total_stats(
+            1, mock_context
+        )
+        assert stats.views == 0
+        assert stats.likes == 0
+
+    @patch("insight.tasks.weekly_user_trend_analysis.analyze_user_posts")
+    async def test_analyze_user_posts_success(
+        self, mock_analyze, analyzer_user, sample_trend_analysis, sample_trending_items
+    ):
+        """사용자 게시글 분석 성공 테스트"""
+        mock_post = MagicMock(
+            title="test", thumbnail="", url_slug="slug", body="내용"
+        )
+        mock_analyze.return_value = {
+            "trending_summary": [sample_trending_items[0].to_dict()],
+            "trend_analysis": sample_trend_analysis.to_dict(),
+        }
+
+        trending_items, trend_analysis = await analyzer_user._analyze_user_posts_with_llm(
+            [mock_post], "user"
+        )
+
+        assert len(trending_items) == 1
+        assert trend_analysis is not None
+        assert trend_analysis.hot_keywords == sample_trend_analysis.hot_keywords
+
+    @patch(
+        "insight.tasks.weekly_user_trend_analysis.analyze_user_posts",
+        side_effect=Exception("LLM 실패"),
+    )
+    async def test_analyze_user_posts_failure_returns_fallback(
+        self, mock_llm, analyzer_user
+    ):
+        """LLM 분석 실패 시, [분석 실패] 요약과 None 분석 결과를 반환하는지 테스트"""
+        mock_post = MagicMock(
+            title="post1", thumbnail="", url_slug="slug", body="내용"
+        )
+        items, trend = await analyzer_user._analyze_user_posts_with_llm(
+            [mock_post], "tester"
+        )
+
+        assert len(items) == 1
+        assert items[0].summary == "[분석 실패]"
+        assert trend is None
+
+    @patch("insight.tasks.weekly_user_trend_analysis.UserWeeklyAnalyzer._create_user_reminder")
+    async def test_analyze_user_data_without_new_posts_creates_reminder(
+        self, mock_reminder, analyzer_user, mock_context
+    ):
+        """신규 게시글이 없는 사용자의 경우, 리마인더 생성 로직이 동작하는지 테스트"""
+        user_data = MagicMock()
+        user_data.user_id = 1
+        user_data.username = "tester"
+        user_data.weekly_new_posts = []
+        user_data.weekly_total_stats = WeeklyUserStats(
+            posts=0, new_posts=0, views=0, likes=0
+        )
+
+        mock_reminder.return_value = MagicMock(title="최근 글", days_ago=5)
+
+        insight = await analyzer_user._analyze_user_data(
+            user_data, mock_context
+        )
+        assert insight.user_weekly_reminder.title == "최근 글"
+        mock_reminder.assert_called_once()