release/index.js: Download binary to temp file, after smoke test, move to final location

Author: jahooma

cli/release/index.js

@@ -23,6 +23,7 @@ function createConfig(packageName) {
     binaryName,
     binaryPath: path.join(configDir, binaryName),
     metadataPath: path.join(configDir, 'codebuff-metadata.json'),
+    tempDownloadDir: path.join(configDir, '.download-temp'),
     userAgent: `${packageName}-cli`,
     requestTimeout: 20000,
   }
@@ -127,6 +128,51 @@ function getCurrentVersion() {
   }
 }
 
+function runSmokeTest(binaryPath) {
+  return new Promise((resolve) => {
+    if (!fs.existsSync(binaryPath)) {
+      resolve(false)
+      return
+    }
+
+    const child = spawn(binaryPath, ['--version'], {
+      cwd: os.homedir(),
+      stdio: 'pipe',
+    })
+
+    let output = ''
+
+    child.stdout.on('data', (data) => {
+      output += data.toString()
+    })
+
+    const timeout = setTimeout(() => {
+      child.kill('SIGTERM')
+      setTimeout(() => {
+        if (!child.killed) {
+          child.kill('SIGKILL')
+        }
+      }, 1000)
+      resolve(false)
+    }, 5000)
+
+    child.on('exit', (code) => {
+      clearTimeout(timeout)
+      // Check that it exits successfully and outputs something that looks like a version
+      if (code === 0 && output.trim().match(/^\d+(\.\d+)*$/)) {
+        resolve(true)
+      } else {
+        resolve(false)
+      }
+    })
+
+    child.on('error', () => {
+      clearTimeout(timeout)
+      resolve(false)
+    })
+  })
+}
+
 function compareVersions(v1, v2) {
   if (!v1 || !v2) return 0
 
@@ -217,33 +263,21 @@ async function downloadBinary(version) {
     process.env.NEXT_PUBLIC_CODEBUFF_APP_URL || 'https://codebuff.com'
   }/api/releases/download/${version}/${fileName}`
 
+  // Ensure config directory exists
   fs.mkdirSync(CONFIG.configDir, { recursive: true })
 
-  if (fs.existsSync(CONFIG.binaryPath)) {
-    try {
-      fs.unlinkSync(CONFIG.binaryPath)
-    } catch (err) {
-      // Fallback: try renaming the locked/undeletable binary
-      const backupPath = CONFIG.binaryPath + `.old.${Date.now()}`
-
-      try {
-        fs.renameSync(CONFIG.binaryPath, backupPath)
-      } catch (renameErr) {
-        // If we can't unlink OR rename, we can't safely proceed
-        throw new Error(
-          `Failed to replace existing binary. ` +
-            `unlink error: ${err.code || err.message}, ` +
-            `rename error: ${renameErr.code || renameErr.message}`,
-        )
-      }
-    }
+  // Clean up any previous temp download directory
+  if (fs.existsSync(CONFIG.tempDownloadDir)) {
+    fs.rmSync(CONFIG.tempDownloadDir, { recursive: true })
   }
+  fs.mkdirSync(CONFIG.tempDownloadDir, { recursive: true })
 
   term.write('Downloading...')
 
   const res = await httpGet(downloadUrl)
 
   if (res.statusCode !== 200) {
+    fs.rmSync(CONFIG.tempDownloadDir, { recursive: true })
     throw new Error(`Download failed: HTTP ${res.statusCode}`)
   }
 
@@ -269,36 +303,71 @@ async function downloadBinary(version) {
     }
   })
 
+  // Extract to temp directory
   await new Promise((resolve, reject) => {
     res
       .pipe(zlib.createGunzip())
-      .pipe(tar.x({ cwd: CONFIG.configDir }))
+      .pipe(tar.x({ cwd: CONFIG.tempDownloadDir }))
       .on('finish', resolve)
       .on('error', reject)
   })
 
-  try {
-    const files = fs.readdirSync(CONFIG.configDir)
-    const extractedPath = path.join(CONFIG.configDir, CONFIG.binaryName)
+  const tempBinaryPath = path.join(CONFIG.tempDownloadDir, CONFIG.binaryName)
+
+  // Verify the binary was extracted
+  if (!fs.existsSync(tempBinaryPath)) {
+    const files = fs.readdirSync(CONFIG.tempDownloadDir)
+    fs.rmSync(CONFIG.tempDownloadDir, { recursive: true })
+    throw new Error(
+      `Binary not found after extraction. Expected: ${CONFIG.binaryName}, Available files: ${files.join(', ')}`,
+    )
+  }
+
+  // Set executable permissions
+  if (process.platform !== 'win32') {
+    fs.chmodSync(tempBinaryPath, 0o755)
+  }
+
+  // Run smoke test on the downloaded binary
+  term.write('Verifying download...')
+  const smokeTestPassed = await runSmokeTest(tempBinaryPath)
+
+  if (!smokeTestPassed) {
+    fs.rmSync(CONFIG.tempDownloadDir, { recursive: true })
+    throw new Error('Downloaded binary failed smoke test (--version check)')
+  }
 
-    if (fs.existsSync(extractedPath)) {
-      if (process.platform !== 'win32') {
-        fs.chmodSync(extractedPath, 0o755)
+  // Smoke test passed - move binary to final location
+  try {
+    if (fs.existsSync(CONFIG.binaryPath)) {
+      try {
+        fs.unlinkSync(CONFIG.binaryPath)
+      } catch (err) {
+        // Fallback: try renaming the locked/undeletable binary (Windows)
+        const backupPath = CONFIG.binaryPath + `.old.${Date.now()}`
+        try {
+          fs.renameSync(CONFIG.binaryPath, backupPath)
+        } catch (renameErr) {
+          throw new Error(
+            `Failed to replace existing binary. ` +
+              `unlink error: ${err.code || err.message}, ` +
+              `rename error: ${renameErr.code || renameErr.message}`,
+          )
+        }
       }
-      // Save version metadata for fast version checking
-      fs.writeFileSync(
-        CONFIG.metadataPath,
-        JSON.stringify({ version }, null, 2),
-      )
-    } else {
-      throw new Error(
-        `Binary not found after extraction. Expected: ${extractedPath}, Available files: ${files.join(', ')}`,
-      )
     }
-  } catch (error) {
-    term.clearLine()
-    console.error(`Extraction failed: ${error.message}`)
-    process.exit(1)
+    fs.renameSync(tempBinaryPath, CONFIG.binaryPath)
+
+    // Save version metadata for fast version checking
+    fs.writeFileSync(
+      CONFIG.metadataPath,
+      JSON.stringify({ version }, null, 2),
+    )
+  } finally {
+    // Clean up temp directory even if rename fails
+    if (fs.existsSync(CONFIG.tempDownloadDir)) {
+      fs.rmSync(CONFIG.tempDownloadDir, { recursive: true })
+    }
   }
 
   term.clearLine()