Fix lint errors in web: empty blocks, conditional hooks, const conditions, displayName, type annotations

Author: brandonkachen

web/src/__tests__/e2e/store-hydration.spec.ts

@@ -1,12 +1,19 @@
 import { test, expect } from '@playwright/test'
 
-test('store hydrates agents via client fetch when SSR is empty', async ({ page }) => {
+test('store hydrates agents via client fetch when SSR is empty', async ({
+  page,
+}) => {
   const agents = [
     {
       id: 'base',
       name: 'Base',
       description: 'desc',
-      publisher: { id: 'codebuff', name: 'Codebuff', verified: true, avatar_url: null },
+      publisher: {
+        id: 'codebuff',
+        name: 'Codebuff',
+        verified: true,
+        avatar_url: null,
+      },
       version: '1.2.3',
       created_at: new Date().toISOString(),
       weekly_spent: 10,

web/src/__tests__/e2e/store-ssr.spec.ts

@@ -9,7 +9,12 @@ test('SSR HTML contains at least one agent card', async ({ page }) => {
       id: 'base',
       name: 'Base',
       description: 'desc',
-      publisher: { id: 'codebuff', name: 'Codebuff', verified: true, avatar_url: null },
+      publisher: {
+        id: 'codebuff',
+        name: 'Codebuff',
+        verified: true,
+        avatar_url: null,
+      },
       version: '1.2.3',
       created_at: new Date().toISOString(),
       weekly_spent: 10,

web/src/app/admin/traces/utils/trace-processing.ts

@@ -446,7 +446,7 @@ export function extractActualAssistantResponse(response: any): string {
   if (!response) return ''
 
   // Extract the raw response content first
-  let responseContent = extractAssistantResponseFromResponse(response)
+  const responseContent = extractAssistantResponseFromResponse(response)
 
   if (!responseContent) return ''
 

web/src/app/analytics.knowledge.md

@@ -44,49 +44,41 @@ Important event tracking considerations:
 The application uses the following event categories for consistent tracking:
 
 1. Home Page Events (`home.*`)
-
    - home.cta_clicked
    - home.video_opened
    - home.testimonial_clicked
 
 2. Demo Terminal Events (`demo_terminal.*`)
-
    - demo_terminal.command_executed
    - demo_terminal.help_viewed
    - demo_terminal.theme_changed
    - demo_terminal.bug_fixed
    - demo_terminal.rainbow_added
 
 3. Authentication Events (`auth.*`)
-
    - auth.login_started
    - auth.login_completed
    - auth.logout_completed
 
 4. Cookie Consent Events (`cookie_consent.*`)
-
    - cookie_consent.accepted
    - cookie_consent.declined
 
 5. Subscription Events (`subscription.*`)
-
    - subscription.plan_viewed
    - subscription.upgrade_started
    - subscription.payment_completed
    - subscription.change_confirmed
 
 6. Referral Events (`referral.*`)
-
    - referral.link_copied
    - referral.code_redeemed
    - referral.invite_sent
 
 7. Documentation Events (`docs.*`)
-
    - docs.viewed
 
 8. Banner Events (`banner.*`)
-
    - banner.clicked
 
 9. Usage Events (`usage.*`)
@@ -100,7 +92,6 @@ Progress bar color coding:
 - Shows warning message when exceeding quota with overage rate details
 
 9. Navigation Events (`navigation.*`)
-
    - navigation.docs_clicked
    - navigation.pricing_clicked
 
@@ -249,7 +240,6 @@ Example event properties:
 1. **Consistent Categories**: Use established categories (demo_terminal, auth, subscription, etc.) for all new events
 
 2. **Event Properties**:
-
    - Include theme in all UI events
    - Add source/location for user actions
    - Include error details for failure cases
@@ -310,7 +300,6 @@ export function PostHogProvider({ children }) {
 The application implements LinkedIn conversion tracking using a multi-step flow:
 
 1. Initial Visit:
-
    - Capture `li_fat_id` from URL query parameters
    - Store in localStorage
    - Clear from URL for cleaner user experience
@@ -332,7 +321,6 @@ Important: This pattern ensures accurate attribution even when users don't conve
 ## Implementation Guidelines
 
 1. Centralize Tracking Logic:
-
    - Keep tracking code DRY by centralizing in shared functions
    - Multiple UI components may trigger the same conversion event
    - Maintain consistent tracking parameters across all conversion points

web/src/app/api/admin/admin-auth.ts

@@ -23,7 +23,10 @@ export async function checkAdminAuth(): Promise<
         'Unauthorized access attempt to admin endpoint',
       )
     }
-    return NextResponse.json({ error: 'Forbidden - not an admin' }, { status: 403 })
+    return NextResponse.json(
+      { error: 'Forbidden - not an admin' },
+      { status: 403 },
+    )
   }
 
   return adminUser

web/src/app/api/agents/publish/route.ts

@@ -60,7 +60,11 @@ export async function POST(request: NextRequest) {
 
     // DEPRECATED: authToken in body is for backwards compatibility with older CLI versions.
     // New clients should use the Authorization header instead.
-    const { data, authToken: bodyAuthToken, allLocalAgentIds } = parseResult.data
+    const {
+      data,
+      authToken: bodyAuthToken,
+      allLocalAgentIds,
+    } = parseResult.data
     const agentDefinitions = data
 
     // Prefer Authorization header, fall back to body authToken for backwards compatibility
@@ -248,10 +252,10 @@ export async function POST(request: NextRequest) {
     const existsInSamePublisher = (full: string) =>
       publishingAgentIds.has(full) || publishedAgentIds.has(full)
 
-    async function getLatestPublishedVersion(
+    const getLatestPublishedVersion = async (
       publisherId: string,
       agentId: string,
-    ): Promise<string | null> {
+    ): Promise<string | null> => {
       const latest = await db
         .select({ version: schema.agentConfig.version })
         .from(schema.agentConfig)

web/src/app/api/agents/validate/route.ts

@@ -14,7 +14,8 @@ interface ValidateAgentsRequest {
 export async function POST(request: NextRequest): Promise<NextResponse> {
   try {
     const body = (await request.json()) as ValidateAgentsRequest
-    let { agentConfigs, agentDefinitions } = body
+    const { agentConfigs } = body
+    let { agentDefinitions } = body
 
     if (!agentDefinitions || !Array.isArray(agentDefinitions)) {
       agentDefinitions = agentConfigs

web/src/app/api/auth/[...nextauth]/auth-options.ts

@@ -162,7 +162,8 @@ export const authOptions: NextAuthOptions = {
 
       const potentialRedirectUrl = new URL(url, baseUrl)
       const authCode = potentialRedirectUrl.searchParams.get('auth_code')
-      let referralCode = potentialRedirectUrl.searchParams.get('referral_code')
+      const referralCode =
+        potentialRedirectUrl.searchParams.get('referral_code')
 
       console.log('🟡 NextAuth redirect parsed params:', {
         authCode: !!authCode,

web/src/app/api/healthz/route.ts

@@ -10,7 +10,7 @@ export const GET = async () => {
     return NextResponse.json({
       status: 'ok',
       cached_agents: agents.length,
-      timestamp: new Date().toISOString()
+      timestamp: new Date().toISOString(),
     })
   } catch (error) {
     console.error('[Healthz] Failed to warm cache:', error)
@@ -19,7 +19,7 @@ export const GET = async () => {
     return NextResponse.json({
       status: 'ok',
       cache_warm: false,
-      error: error instanceof Error ? error.message : 'Unknown error'
+      error: error instanceof Error ? error.message : 'Unknown error',
     })
   }
 }

web/src/app/api/user/sessions/logout-all/route.ts

@@ -28,7 +28,9 @@ function isSameOrigin(request: NextRequest) {
     const referer = request.headers.get('referer')
     if (origin && new URL(origin).origin === base) return true
     if (referer && new URL(referer).origin === base) return true
-  } catch {}
+  } catch {
+    // Ignore URL parsing errors
+  }
   return false
 }
 
@@ -39,7 +41,10 @@ export async function POST(request: NextRequest) {
   }
 
   if (!isSameOrigin(request)) {
-    return NextResponse.json({ error: 'Forbidden - not same origin, cannot logout all sessions' }, { status: 403 })
+    return NextResponse.json(
+      { error: 'Forbidden - not same origin, cannot logout all sessions' },
+      { status: 403 },
+    )
   }
 
   const currentToken = getCurrentSessionTokenFromCookies()