refactor: simplify console logs response format based on PR feedback

- Remove pagination object and consolidate info into message field
- Delete deprecated GetAllLogsAsJson method
- Optimize log counting with single loop for better performance
- Add default offset/limit values to resource templates
- Simplify response to only include logs, message, and success fields
- Move count information (total, filtered, returned) into message text
- Add parameter validation for offset/limit in TypeScript

This addresses all review comments from PR #42 to make the response
format more concise and easier for AI agents to process.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: Saqoosha

Editor/Resources/GetConsoleLogsResource.cs

@@ -1,3 +1,4 @@
+using System;
 using Newtonsoft.Json.Linq;
 using McpUnity.Services;
 
@@ -35,14 +36,19 @@ public override JObject Fetch(JObject parameters)
             // Use the new paginated method
             JObject result = _consoleLogsService.GetLogsAsJson(logType, offset, limit);
 
-            // Add success info to the response
+            // Add formatted message with pagination info
+            string typeFilter = logType != null ? $" of type '{logType}'" : "";
+            int returnedCount = result["_returnedCount"]?.Value<int>() ?? 0;
+            int filteredCount = result["_filteredCount"]?.Value<int>() ?? 0;
+            int totalCount = result["_totalCount"]?.Value<int>() ?? 0;
+            
+            result["message"] = $"Retrieved {returnedCount} of {filteredCount} log entries{typeFilter} (offset: {offset}, limit: {limit}, total: {totalCount})";
             result["success"] = true;
 
-            var pagination = result["pagination"] as JObject;
-            string typeFilter = logType != null ? $" of type '{logType}'" : "";
-            int returnedCount = pagination?["returnedCount"]?.Value<int>() ?? 0;
-            int filteredCount = pagination?["filteredCount"]?.Value<int>() ?? 0;
-            result["message"] = $"Retrieved {returnedCount} of {filteredCount} log entries{typeFilter} (offset: {offset}, limit: {limit})";
+            // Remove internal count fields (they're now in the message)
+            result.Remove("_totalCount");
+            result.Remove("_filteredCount");
+            result.Remove("_returnedCount");
 
             return result;
         }

Editor/Services/ConsoleLogsService.cs

@@ -77,17 +77,6 @@ public void StopListening()
             EditorApplication.update -= CheckConsoleClearViaReflection;
 #endif
         }
-        
-        /// <summary>
-        /// Get all logs as a JSON array
-        /// </summary>
-        /// <returns>JArray containing all logs</returns>
-        public JArray GetAllLogsAsJson(string logType = "")
-        {
-            var result = GetLogsAsJson(logType, 0, int.MaxValue);
-            return result["logs"] as JArray;
-        }
-        
         /// <summary>
         /// Get logs as a JSON array with pagination support
         /// </summary>
@@ -121,23 +110,21 @@ public JObject GetLogsAsJson(string logType = "", int offset = 0, int limit = 10
 
             lock (_logEntries)
             {
-                // First pass: count total and filtered entries
-                foreach (var entry in _logEntries)
-                {
-                    totalCount++;
-                    if (!filter || unityLogTypes.Contains(entry.Type.ToString()))
-                    {
-                        filteredCount++;
-                    }
-                }
+                totalCount = _logEntries.Count;
 
-                // Second pass: collect the requested page (newest first)
+                // Single pass: count filtered entries and collect the requested page (newest first)
                 for (int i = _logEntries.Count - 1; i >= 0; i--)
                 {
                     var entry = _logEntries[i];
+                    
+                    // Skip if filtering and entry doesn't match the filter
                     if (filter && !unityLogTypes.Contains(entry.Type.ToString()))
                         continue;
-                        
+                    
+                    // Count filtered entries
+                    filteredCount++;
+                    
+                    // Check if we're in the offset range and haven't reached the limit yet
                     if (currentIndex >= offset && logsArray.Count < limit)
                     {
                         logsArray.Add(new JObject
@@ -150,22 +137,18 @@ public JObject GetLogsAsJson(string logType = "", int offset = 0, int limit = 10
                     }
 
                     currentIndex++;
-                    if (logsArray.Count >= limit) break;
+                    
+                    // Early exit if we've collected enough logs
+                    if (currentIndex >= offset + limit) break;
                 }
             }
 
             return new JObject
             {
                 ["logs"] = logsArray,
-                ["pagination"] = new JObject
-                {
-                    ["offset"] = offset,
-                    ["limit"] = limit,
-                    ["totalCount"] = totalCount,
-                    ["filteredCount"] = filteredCount,
-                    ["returnedCount"] = logsArray.Count,
-                    ["hasMore"] = offset + logsArray.Count < filteredCount
-                }
+                ["_totalCount"] = totalCount,
+                ["_filteredCount"] = filteredCount,
+                ["_returnedCount"] = logsArray.Count
             };
         }
 

Editor/Services/IConsoleLogsService.cs

@@ -10,13 +10,6 @@ namespace McpUnity.Services
     /// </summary>
     public interface IConsoleLogsService
     {
-        /// <summary>
-        /// Get all logs as a JSON array, optionally filtered by log type
-        /// </summary>
-        /// <param name="logType">UnityEngine.LogType as string (e.g. "Error", "Warning", "Log"). Empty string for all logs.</param>
-        /// <returns>JArray containing filtered logs</returns>
-        JArray GetAllLogsAsJson(string logType = "");
-        
         /// <summary>
         /// Get logs as a JSON object with pagination support
         /// </summary>

Server~/src/resources/getConsoleLogsResource.ts

@@ -17,27 +17,27 @@ function listLogTypes(resourceMimeType: string) {
   return {
     resources: [
       {
-        uri: `unity://logs/`,
+        uri: `unity://logs/?offset=0&limit=50`,
         name: "All logs",
-        description: "Retrieve Unity console logs (newest first). Use pagination to avoid token limits: ?offset=0&limit=50 for recent logs. Default limit=100 may be too large for LLM context.",
+        description: "Retrieve Unity console logs (newest first). Default pagination offset=0&limit=50 to avoid token limits.",
         mimeType: resourceMimeType
       },
       {
-        uri: `unity://logs/error`,
+        uri: `unity://logs/error?offset=0&limit=20`,
         name: "Error logs",
-        description: "Retrieve only error logs from Unity console (newest first). Use ?offset=0&limit=20 to avoid token limits. Large log sets may exceed LLM context window.",
+        description: "Retrieve only error logs from Unity console (newest first). Default pagination offset=0&limit=20.",
         mimeType: resourceMimeType
       },
       {
-        uri: `unity://logs/warning`,
+        uri: `unity://logs/warning?offset=0&limit=30`,
         name: "Warning logs", 
-        description: "Retrieve only warning logs from Unity console (newest first). Use pagination ?offset=0&limit=30 to manage token usage effectively.",
+        description: "Retrieve only warning logs from Unity console (newest first). Default pagination offset=0&limit=30.",
         mimeType: resourceMimeType
       },
       {
-        uri: `unity://logs/info`,
+        uri: `unity://logs/info?offset=0&limit=25`,
         name: "Info logs",
-        description: "Retrieve only info logs from Unity console (newest first). Use smaller limits like ?limit=25 to prevent token overflow in LLM responses.",
+        description: "Retrieve only info logs from Unity console (newest first). Default pagination offset=0&limit=25.",
         mimeType: resourceMimeType
       }
     ]
@@ -76,9 +76,17 @@ async function resourceHandler(mcpUnity: McpUnity, uri: URL, variables: Variable
   let logType = variables["logType"] ? decodeURIComponent(variables["logType"] as string) : undefined;
   if (logType === '') logType = undefined;
 
-  // Extract pagination parameters
+  // Extract pagination parameters with validation
   const offset = variables["offset"] ? parseInt(variables["offset"] as string, 10) : 0;
   const limit = variables["limit"] ? parseInt(variables["limit"] as string, 10) : 100;
+  
+  // Validate pagination parameters
+  if (isNaN(offset) || offset < 0) {
+    throw new McpUnityError(ErrorType.VALIDATION, 'Invalid offset parameter: must be a non-negative integer');
+  }
+  if (isNaN(limit) || limit <= 0) {
+    throw new McpUnityError(ErrorType.VALIDATION, 'Invalid limit parameter: must be a positive integer');
+  }
 
   // Send request to Unity
   const response = await mcpUnity.sendRequest({