Skip to content

fix: merge members llm prompt #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joanagmaia wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −2
Open

fix: merge members llm prompt #3644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f05aec3
fix: merge members llm prompt
joanagmaia Nov 25, 2025
23d9fd1
fix: add rule to prevent bot merges with normal profiles
joanagmaia Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions services/apps/merge_suggestions_worker/src/workflows/mergeMembersWithLLM.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,18 @@ export async function mergeMembersWithLLM(
4. Display Name: Tokenize using both character and word tokenization. When the display name is more than one word, and the difference is a few edit distances consider it a strong indication of similarity.
When one display name is contained by the other, check other fields for the final decision. The same members on different platforms might have different display names.
Display names can be multiple words and might be sorted in different order in different platforms for the same member.
Pro tip: If members have identities in the same platform (member1.identities[x].platform === member2.identities[y].platform) and if these identities have different usernames(member1.identities[x].value !== member2.identities[y].value) you can label them as different.
Only do such labeling if both members have identities in the same platform. If they don't have identities in the same platform ignore the pro tip.
CRITICAL RULE - NEVER MERGE IF SAME PLATFORM WITH DIFFERENT VALUES:
Before making any decision, you MUST check if both members have identities on the same platform.
If member1.identities[x].platform === member2.identities[y].platform (they share a platform), then:
- Check if member1.identities[x].value === member2.identities[y].value
- If the values are DIFFERENT, immediately return 'false' - these are definitely different people
- This rule applies REGARDLESS of how similar other fields appear.
This check must be performed FIRST before evaluating any other similarities. Only do such labeling if both members have identities in the same platform. If they don't have identities in the same platform, ignore the rule.
BOT CHECKS - NEVER MERGE IF ONE PROFILE IS A BOT AND THE OTHER IS NOT
- Check the bot status in attributes.isBot.default for each member
- If one member has attributes.isBot.default === true and the other has attributes.isBot.default === false (or undefined), return 'false'
- Bots and humans are never the same entity
- This check must be performed before evaluating any other similarities
Print 'true' if they are the same member, 'false' otherwise. No explanation required. Don't print anything else.`

const suggestions = await memberActivitiesProxy.getRawMemberMergeSuggestions(
Expand Down
Loading