Skip to content

Commit 4a9b6fa

Browse files
Merge pull request #409 from konstantingross/feature/Add_missing_config_parameter_#407
Add missing config parameter fixes #407
2 parents fb308ed + bb3d073 commit 4a9b6fa

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

ElectronNET.API/NativeTheme.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ internal static NativeTheme Instance
8989
/// </list>
9090
/// Your application should then always use <see cref="ShouldUseDarkColorsAsync"/> to determine what CSS to apply.
9191
/// </summary>
92-
/// <param name="themeSource">The new ThemeSource.</param>
92+
/// <param name="themeSourceMode">The new ThemeSource.</param>
9393
public void SetThemeSource(ThemeSourceMode themeSourceMode)
9494
{
9595
var themeSource = themeSourceMode.GetDescription();

ElectronNET.CLI/Commands/StartElectronCommand.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public StartElectronCommand(string[] args)
2727
private string _manifest = "manifest";
2828
private string _clearCache = "clear-cache";
2929
private string _paramPublishReadyToRun = "PublishReadyToRun";
30+
private string _paramDotNetConfig = "dotnet-configuration";
3031

3132
public Task<bool> ExecuteAsync()
3233
{
@@ -73,9 +74,15 @@ public Task<bool> ExecuteAsync()
7374
publishReadyToRun += "true";
7475
}
7576

77+
string configuration = "Release";
78+
if (parser.Arguments.ContainsKey(_paramDotNetConfig))
79+
{
80+
configuration = parser.Arguments[_paramDotNetConfig][0];
81+
}
82+
7683
if (parser != null && !parser.Arguments.ContainsKey("watch"))
7784
{
78-
resultCode = ProcessHelper.CmdExecute($"dotnet publish -r {platformInfo.NetCorePublishRid} --output \"{tempBinPath}\" {publishReadyToRun} --no-self-contained", aspCoreProjectPath);
85+
resultCode = ProcessHelper.CmdExecute($"dotnet publish -r {platformInfo.NetCorePublishRid} -c {configuration} --output \"{tempBinPath}\" {publishReadyToRun} --no-self-contained", aspCoreProjectPath);
7986
}
8087

8188
if (resultCode != 0)

ElectronNET.CLI/Properties/launchSettings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"profiles": {
33
"ElectronNET.CLI": {
44
"commandName": "Project",
5-
"commandLineArgs": "start /project-path \"C:\\Users\\Rizvi\\source\\repos\\Electron.NET\\ElectronNET.WebApp\" /watch"
5+
"commandLineArgs": "start /project-path \"$(SolutionDir)\\ElectronNET.WebApp\" /watch"
66
}
77
}
88
}

0 commit comments

Comments
 (0)