DataFetcherConstructor args constructor as the annotation + tests

Author: danieltaub96

src/main/java/graphql/annotations/processor/util/DataFetcherConstructor.java

@@ -39,9 +39,9 @@ public DataFetcher constructDataFetcher(String fieldName, GraphQLDataFetcher ann
             return newInstance(annotatedDataFetcher.value());
         } else {
             try {
-                final Constructor<? extends DataFetcher> ctr = annotatedDataFetcher.value().getDeclaredConstructor(
-                        stream(args).map(v -> String.class).toArray(Class[]::new));
-                return constructNewInstance(ctr, (Object[]) args);
+                // Get the String[] constructor
+                final Constructor<? extends DataFetcher> ctr = annotatedDataFetcher.value().getDeclaredConstructor(String[].class);
+                return constructNewInstance(ctr, new Object[] {args});
             } catch (final NoSuchMethodException e) {
                 throw new GraphQLAnnotationsException("Unable to instantiate DataFetcher via constructor for: " + fieldName, e);
             }

src/test/java/graphql/annotations/processor/util/DataFetcherConstructorTest.java

@@ -0,0 +1,62 @@
+package graphql.annotations.processor.util;
+
+import graphql.annotations.annotationTypes.GraphQLDataFetcher;
+import graphql.schema.DataFetcher;
+import org.testng.annotations.Test;
+
+import java.lang.annotation.Annotation;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNull;
+
+/**
+ * @author danieltaub on 07/05/2018.
+ */
+public class DataFetcherConstructorTest {
+    private DataFetcherConstructor constructor = new DataFetcherConstructor();
+
+    @Test
+    public void graphQLDataFetcherWithArgsTest() {
+        GraphQLDataFetcher graphQLDataFetcher = getGraphQLDataFetcher(DataFetcherMock.class, false, "Arg1", "Arg2");
+        DataFetcherMock dataFetcher = (DataFetcherMock) constructor.constructDataFetcher(null, graphQLDataFetcher);
+
+        assertEquals(dataFetcher.getArgs().length, 2);
+        assertEquals(dataFetcher.getArgs()[0], "Arg1");
+        assertEquals(dataFetcher.getArgs()[1], "Arg2");
+    }
+
+    @Test
+    public void graphQLDataFetcherDefaultCtorTest() {
+        GraphQLDataFetcher graphQLDataFetcher = getGraphQLDataFetcher(DataFetcherMock.class, false);
+        DataFetcherMock dataFetcher = (DataFetcherMock) constructor.constructDataFetcher(null, graphQLDataFetcher);
+
+        assertNull(dataFetcher.getArgs());
+    }
+
+    private GraphQLDataFetcher getGraphQLDataFetcher(final Class<? extends DataFetcher> value,
+                                                     boolean argsInTarget, String... args) {
+        GraphQLDataFetcher annotation = new GraphQLDataFetcher() {
+            @Override
+            public Class<? extends Annotation> annotationType() {
+                return GraphQLDataFetcher.class;
+            }
+
+            @Override
+            public Class<? extends DataFetcher> value() {
+                return value;
+            }
+
+            @Override
+            public String[] args() {
+                return args;
+            }
+
+            @Override
+            public boolean firstArgIsTargetName() {
+                return argsInTarget;
+            }
+        };
+
+        return annotation;
+    }
+}

src/test/java/graphql/annotations/processor/util/DataFetcherMock.java

@@ -0,0 +1,26 @@
+package graphql.annotations.processor.util;
+
+import graphql.schema.DataFetcher;
+import graphql.schema.DataFetchingEnvironment;
+
+/**
+ * @author danieltaub on 07/05/2018.
+ */
+public class DataFetcherMock implements DataFetcher {
+    private String[] args;
+
+    public DataFetcherMock(String... args){
+        this.args = args;
+    }
+
+    public  DataFetcherMock(){ }
+
+    @Override
+    public Object get(DataFetchingEnvironment environment) {
+        return null;
+    }
+
+    public String[] getArgs() {
+        return args;
+    }
+}