fix!: onError not called if cacheFlags is true and api is not reachable (#365)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: talissoncosta

flagsmith-core.ts

@@ -516,6 +516,7 @@ const Flagsmith = class {
                                 }
                             } catch (e) {
                                 this.log("Exception fetching cached logs", e);
+                                throw e;
                             }
                         } else {
                             if (!preventFetch) {
@@ -540,7 +541,15 @@ const Flagsmith = class {
                     try {
                         const res = AsyncStorage.getItemSync? AsyncStorage.getItemSync(this.getStorageKey()) : await AsyncStorage.getItem(this.getStorageKey());
                         await onRetrievedStorage(null, res)
-                    } catch (e) {}
+                    } catch (e) {
+                        // Only re-throw if we don't have fallback flags (defaultFlags or cached flags)
+                        if (!this.flags || Object.keys(this.flags).length === 0) {
+                            throw e;
+                        }
+                        // We have fallback flags, so call onError but don't reject init()
+                        const typedError = e instanceof Error ? e : new Error(`${e}`);
+                        this.onError?.(typedError);
+                    }
                 }
             } else if (!preventFetch) {
                 await this.getFlags();

lib/flagsmith/package.json

@@ -1,6 +1,6 @@
 {
   "name": "flagsmith",
-  "version": "9.3.5",
+  "version": "10.0.0",
   "description": "Feature flagging to support continuous development",
   "main": "./index.js",
   "module": "./index.mjs",

lib/react-native-flagsmith/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-flagsmith",
-  "version": "9.3.5",
+  "version": "10.0.0",
   "description": "Feature flagging to support continuous development",
   "main": "./index.js",
   "repository": {

test/init.test.ts

@@ -274,6 +274,21 @@ describe('Flagsmith.init', () => {
         });
         expect(onError).toHaveBeenCalledWith(new Error('Mocked fetch error'));
     });
+    test('should call onError when the API cannot be reached with cacheFlags enabled but no cache exists', async () => {
+        const onError = jest.fn();
+        const { flagsmith, initConfig } = getFlagsmith({
+            cacheFlags: true,
+            fetch: async () => {
+                return Promise.resolve({ text: () => Promise.resolve('Mocked fetch error'), ok: false, status: 401 });
+            },
+            onError,
+        });
+        // NOTE: No AsyncStorage.setItem() - cache is empty, and no defaultFlags provided
+
+        await expect(flagsmith.init(initConfig)).rejects.toThrow('Mocked fetch error');
+        expect(onError).toHaveBeenCalledTimes(1);
+        expect(onError).toHaveBeenCalledWith(new Error('Mocked fetch error'));
+    });
     test('should send app name and version headers when provided', async () => {
         const onChange = jest.fn();
         const { flagsmith, initConfig, AsyncStorage, mockFetch } = getFlagsmith({

utils/version.ts

@@ -1,2 +1,2 @@
 // Auto-generated by write-version.js
-export const SDK_VERSION = "9.3.2";
+export const SDK_VERSION = "10.0.0";