Updated restriction types

Added newly available restriction types With the update of Bitbucket (premium features) last year, there were some extra Branch Restrictions added: require_tasks_to_be_completed require_passing_builds_to_merge require_all_dependencies_merged require_approvals_to_merge enforce_merge_checks reset_pullrequest_approvals_on_change

Also created the option to add new restrictions to the list if Bitbucket adds them.

ref: Merged in vkerkhoffpon/bitbucket-api/feature/add-branchpermission-types (pull request #39)

Author: vkerkhoffpon

lib/Bitbucket/API/Repositories/BranchRestrictions.php

@@ -21,6 +21,23 @@
  */
 class BranchRestrictions extends Api
 {
+    /**
+     * Allowed restrictions to create a new branch permission for
+     * @var array
+     */
+    protected $allowedRestrictionTypes = array(
+        'require_tasks_to_be_completed',
+        'require_passing_builds_to_merge',
+        'force',
+        'require_all_dependencies_merged',
+        'push',
+        'require_approvals_to_merge',
+        'enforce_merge_checks',
+        'restrict_merges',
+        'reset_pullrequest_approvals_on_change',
+        'delete'
+    );
+
     /**
      * Get the information associated with a repository's branch restrictions
      *
@@ -64,7 +81,7 @@ public function create($account, $repo, $params = array())
 
         $params = array_merge($defaults, $params);
 
-        if (empty($params['kind']) || !in_array($params['kind'], array('push', 'delete', 'force','restrict_merges'))) {
+        if (empty($params['kind']) || !in_array($params['kind'], $this->allowedRestrictionTypes)) {
             throw new \InvalidArgumentException('Invalid restriction kind.');
         }
 
@@ -142,4 +159,14 @@ public function delete($account, $repo, $id)
             sprintf('repositories/%s/%s/branch-restrictions/%d', $account, $repo, $id)
         );
     }
+
+    /**
+     * Add allowed permission types
+     *
+     * @param array $restrictions
+     */
+    public function addAllowedRestrictionType($restrictions = array())
+    {
+        $this->allowedRestrictionTypes = array_merge($this->allowedRestrictionTypes, $restrictions);
+    }
 }

test/Bitbucket/Tests/API/Repositories/BranchRestrictionsTest.php

@@ -25,6 +25,25 @@ public function testGetAllRestrictions()
         $this->assertEquals($expectedResult, $actual);
     }
 
+    public function testAddRestrictionType()
+    {
+        $endpoint       = 'repositories/gentle/eof/branch-restrictions';
+        $params         = array(
+            'kind' => 'testpermission'
+        );
+
+        $client = $this->getHttpClientMock();
+        $client->expects($this->once())
+            ->method('post')
+            ->with($endpoint, json_encode($params));
+
+        /** @var \Bitbucket\API\Repositories\BranchRestrictions $restrictions */
+        $restrictions   = $this->getClassMock('Bitbucket\API\Repositories\BranchRestrictions', $client);
+        $restrictions->addAllowedRestrictionType(array('testpermission'));
+
+        $restrictions->create('gentle', 'eof', $params);
+    }
+
     public function testCreateRestrictionFromArray()
     {
         $endpoint       = 'repositories/gentle/eof/branch-restrictions';