updated validation for BranchRestrictions::update()

Author: vimishor

lib/Bitbucket/API/Repositories/BranchRestrictions.php

@@ -42,7 +42,7 @@ public function all($account, $repo)
      * @access public
      * @param  string           $account The team or individual account owning the repository.
      * @param  string           $repo    The repository identifier.
-     * @param  array            $params  Additional parameters
+     * @param  array|string     $params  Additional parameters as array or JSON string
      * @return MessageInterface
      *
      * @throws \InvalidArgumentException
@@ -98,15 +98,19 @@ public function get($account, $repo, $id)
      * @param  string           $account The team or individual account owning the repository.
      * @param  string           $repo    The repository identifier.
      * @param  int              $id      The restriction's identifier.
-     * @param  array            $params  Additional parameters
+     * @param  array|string     $params  Additional parameters as array or JSON string
      * @return MessageInterface
      *
      * @throws \InvalidArgumentException
      */
     public function update($account, $repo, $id, $params = array())
     {
         // allow developer to directly specify params as json if (s)he wants.
-        if (!empty($params) && is_string($params)) {
+        if ('array' !== gettype($params)) {
+            if (empty($params)) {
+                throw new \InvalidArgumentException('Invalid JSON provided.');
+            }
+
             $params = $this->decodeJSON($params);
         }
 

test/Bitbucket/Tests/API/Repositories/BranchRestrictionsTest.php

@@ -162,6 +162,19 @@ public function testUpdateRestrictionFromJSON()
         $restriction->update('gentle', 'eof', 1, $params);
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     */
+    public function testUpdateRestrictionWithInvalidParams()
+    {
+        /** @var \Bitbucket\API\Repositories\BranchRestrictions $restrictions */
+        $restrictions   = $this->getApiMock('Bitbucket\API\Repositories\BranchRestrictions');
+
+        $restrictions->update('gentle', 'eof', 1, '');
+        $restrictions->update('gentle', 'eof', 1, 3);
+        $restrictions->update('gentle', 'eof', 1, "{ 'foo': 'bar' }");
+    }
+
     /**
      * @expectedException \InvalidArgumentException
      */