Remove Result type

Author: michaelprichardson

firebase-database/src/androidMain/kotlin/dev/gitlive/firebase/database/database.kt

@@ -191,7 +191,7 @@ actual class DatabaseReference internal constructor(
         .run { Unit }
 
     actual suspend fun <T> runTransaction(strategy: KSerializer<T>, transactionUpdate: (currentData: T) -> T): DataSnapshot {
-        val deferred = CompletableDeferred<Result<DataSnapshot>>()
+        val deferred = CompletableDeferred<DataSnapshot>()
         android.runTransaction(object : Transaction.Handler {
 
             override fun doTransaction(currentData: MutableData) =
@@ -203,14 +203,14 @@ actual class DatabaseReference internal constructor(
                 snapshot: com.google.firebase.database.DataSnapshot?
             ) {
                 if(error != null) {
-                    throw error.toException()
+                    deferred.completeExceptionally(error.toException())
                 } else {
-                    deferred.complete(Result.success(DataSnapshot(snapshot!!)))
+                    deferred.complete(DataSnapshot(snapshot!!))
                 }
             }
 
         })
-        return deferred.await().getOrThrow()
+        return deferred.await()
     }
 }
 @Suppress("UNCHECKED_CAST")

firebase-database/src/iosMain/kotlin/dev/gitlive/firebase/database/database.kt

@@ -159,21 +159,21 @@ actual class DatabaseReference internal constructor(
     }
 
     actual suspend fun <T> runTransaction(strategy: KSerializer<T>, transactionUpdate: (currentData: T) -> T): DataSnapshot {
-        val deferred = CompletableDeferred<Result<DataSnapshot>>()
+        val deferred = CompletableDeferred<DataSnapshot>()
         ios.runTransactionBlock(
             block = { firMutableData ->
                 FIRTransactionResult.successWithValue(transactionUpdate(decode(strategy, firMutableData)) as FIRMutableData)
             },
             andCompletionBlock = { error, _, snapshot ->
                 if (error != null) {
-                    throw DatabaseException(error.toString(), null)
+                    deferred.completeExceptionally(DatabaseException(error.toString(), null))
                 } else {
-                    deferred.complete(Result.success(DataSnapshot(snapshot!!)))
+                    deferred.complete(DataSnapshot(snapshot!!))
                 }
             },
             withLocalEvents = false
         )
-        return deferred.await().getOrThrow()
+        return deferred.await()
     }
 }
 

firebase-database/src/jsMain/kotlin/dev/gitlive/firebase/database/database.kt

@@ -130,19 +130,19 @@ actual class DatabaseReference internal constructor(override val js: firebase.da
         rethrow { js.set(encode(strategy, value, encodeDefaults)).awaitWhileOnline() }
 
     actual suspend fun <T> runTransaction(strategy: KSerializer<T>, transactionUpdate: (currentData: T) -> T): DataSnapshot {
-        val deferred = CompletableDeferred<Result<DataSnapshot>>()
+        val deferred = CompletableDeferred<DataSnapshot>()
         js.runTransaction(
             transactionUpdate,
             { error, _, snapshot ->
                 if (error != null) {
-                    throw error
+                    deferred.completeExceptionally(error)
                 } else {
-                    deferred.complete(Result.success(DataSnapshot(snapshot!!)))
+                    deferred.complete(DataSnapshot(snapshot!!))
                 }
             },
             applyLocally = false
         ).await()
-        return deferred.await().getOrThrow()
+        return deferred.await()
     }
 
 }