Skip to content

chore: update dependencies and remove Suspense on ISR requests #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
conico974 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: update dependencies and remove Suspense on ISR requests #3852

conico974 wants to merge 2 commits into from
+166 −52

Conversation

@conico974
Copy link
Contributor

@conico974 conico974 commented Dec 6, 2025

  • Bump React and React-DOM versions to 19.0.1 in package.json.
  • Update @opennextjs/cloudflare to version 1.14.4 in packages/gitbook/package.json.
  • Update Next.js version to 15.4.8 in packages/gitbook/package.json.
  • Modify SitePage and EmbeddableDocsPage components to accept an isSSR prop for better server-side rendering handling.
  • Introduce OptionalSuspense component to conditionally wrap children in a Suspense boundary based on SSR status, improving UX for ISR pages.
  • Adjust page components to utilize the new isSSR prop for consistent rendering behavior.

@conico974
chore: update dependencies and remove Suspense on ISR requests
8722806 
- Bump React and React-DOM versions to 19.0.1 in package.json.
- Update @opennextjs/cloudflare to version 1.14.4 in packages/gitbook/package.json.
- Update Next.js version to 15.4.8 in packages/gitbook/package.json.
- Modify SitePage and EmbeddableDocsPage components to accept an `isSSR` prop for better server-side rendering handling.
- Introduce OptionalSuspense component to conditionally wrap children in a Suspense boundary based on SSR status, improving UX for ISR pages.
- Adjust page components to utilize the new `isSSR` prop for consistent rendering behavior.
@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b9b89b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025 •
edited
Loading

Summary of the deployments:

Version URL Status
Vercel https://gitbook-v2-qlh5cjrf1-gitbook.vercel.app ✅
Cloudflare https://e689c189-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site 2v 2c
GitBook https://gitbook-v2-qlh5cjrf1-gitbook.vercel.app/url/gitbook.com/docs https://e689c189-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.com/docs
E2E https://gitbook-v2-qlh5cjrf1-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://e689c189-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci
Copy link

argos-ci bot commented Dec 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) ⚠️ Changes detected (Review) 1 changed Dec 6, 2025, 12:53 PM
v2-cloudflare (Inspect) ⚠️ Changes detected (Review) 10 changed Dec 6, 2025, 1:19 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 15 changed Dec 6, 2025, 1:41 PM

@conico974 conico974 marked this pull request as ready for review December 6, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@conico974