Skip to content

Commit 7e08219

Browse files
committed
tests: drop unnecessary argument from DelegateBlocking::prepare_ls_refs()
1 parent df393f3 commit 7e08219

File tree

2 files changed

+5
-17
lines changed

2 files changed

+5
-17
lines changed

gix-protocol/tests/protocol/fetch/_impl.rs

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ mod fetch_fn {
9595
gix_protocol::ls_refs(
9696
&mut transport,
9797
&capabilities,
98-
|a, b| delegate.prepare_ls_refs(a, b),
98+
|a, _b| delegate.prepare_ls_refs(a),
9999
&mut progress,
100100
trace,
101101
("agent", Some(Cow::Owned(agent.clone()))),
@@ -195,7 +195,6 @@ mod delegate {
195195
ops::{Deref, DerefMut},
196196
};
197197

198-
use bstr::BString;
199198
use gix_protocol::{
200199
fetch::{Arguments, Response},
201200
handshake::Ref,
@@ -234,11 +233,7 @@ mod delegate {
234233
/// If the delegate returns [`ls_refs::Action::Skip`], no `ls-refs` command is sent to the server.
235234
///
236235
/// Note that this is called only if we are using protocol version 2.
237-
fn prepare_ls_refs(
238-
&mut self,
239-
_server: &Capabilities,
240-
_arguments: &mut Vec<BString>,
241-
) -> std::io::Result<ls_refs::Action> {
236+
fn prepare_ls_refs(&mut self, _server: &Capabilities) -> std::io::Result<ls_refs::Action> {
242237
Ok(ls_refs::Action::Continue)
243238
}
244239

@@ -303,12 +298,8 @@ mod delegate {
303298
self.deref().handshake_extra_parameters()
304299
}
305300

306-
fn prepare_ls_refs(
307-
&mut self,
308-
_server: &Capabilities,
309-
_arguments: &mut Vec<BString>,
310-
) -> io::Result<ls_refs::Action> {
311-
self.deref_mut().prepare_ls_refs(_server, _arguments)
301+
fn prepare_ls_refs(&mut self, _server: &Capabilities) -> io::Result<ls_refs::Action> {
302+
self.deref_mut().prepare_ls_refs(_server)
312303
}
313304

314305
fn prepare_fetch(
@@ -339,9 +330,8 @@ mod delegate {
339330
fn prepare_ls_refs(
340331
&mut self,
341332
_server: &Capabilities,
342-
_arguments: &mut Vec<BString>,
343333
) -> io::Result<ls_refs::Action> {
344-
self.deref_mut().prepare_ls_refs(_server, _arguments)
334+
self.deref_mut().prepare_ls_refs(_server)
345335
}
346336

347337
fn prepare_fetch(

gix-protocol/tests/protocol/fetch/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ impl DelegateBlocking for CloneRefInWantDelegate {
105105
fn prepare_ls_refs(
106106
&mut self,
107107
_server: &Capabilities,
108-
_arguments: &mut Vec<BString>,
109108
) -> io::Result<ls_refs::Action> {
110109
Ok(ls_refs::Action::Skip)
111110
}
@@ -148,7 +147,6 @@ impl DelegateBlocking for LsRemoteDelegate {
148147
fn prepare_ls_refs(
149148
&mut self,
150149
_server: &Capabilities,
151-
_arguments: &mut Vec<BString>,
152150
) -> std::io::Result<ls_refs::Action> {
153151
match self.abort_with.take() {
154152
Some(err) => Err(err),

0 commit comments

Comments
 (0)