Fix dead code warnings in gix and gitoxide-core

Add #[cfg(feature = "attributes")] guards to validator structs that are
only used when the attributes feature is enabled, and add
fields that are only used for serialization.

Co-authored-by: Byron <63622+Byron@users.noreply.github.com>

Author: Copilot

gitoxide-core/src/repository/odb.rs

@@ -17,10 +17,15 @@ pub fn info(
 
     #[cfg_attr(feature = "serde", derive(serde::Serialize))]
     pub struct Statistics {
+        #[cfg_attr(not(feature = "serde"), allow(dead_code))]
         pub path: std::path::PathBuf,
+        #[cfg_attr(not(feature = "serde"), allow(dead_code))]
         pub object_hash: String,
+        #[cfg_attr(not(feature = "serde"), allow(dead_code))]
         pub use_multi_pack_index: bool,
+        #[cfg_attr(not(feature = "serde"), allow(dead_code))]
         pub structure: Vec<gix::odb::store::structure::Record>,
+        #[cfg_attr(not(feature = "serde"), allow(dead_code))]
         pub metrics: gix::odb::store::Metrics,
     }
 

gitoxide-core/src/repository/tree.rs

@@ -25,6 +25,7 @@ mod entries {
         pub num_blobs_exec: usize,
         pub num_submodules: usize,
         #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))]
+        #[cfg_attr(not(feature = "serde"), allow(dead_code))]
         pub bytes: Option<u64>,
         #[cfg_attr(feature = "serde", serde(skip))]
         pub num_bytes: u64,

gix/src/config/tree/sections/core.rs

@@ -478,41 +478,41 @@ mod validate {
         }
     }
 
+    #[cfg(feature = "attributes")]
     pub struct SafeCrlf;
+    #[cfg(feature = "attributes")]
     impl keys::Validate for SafeCrlf {
-        #[cfg_attr(not(feature = "attributes"), allow(unused_variables))]
         fn validate(&self, value: &BStr) -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
-            #[cfg(feature = "attributes")]
             super::Core::SAFE_CRLF.try_into_safecrlf(value.into())?;
             Ok(())
         }
     }
 
+    #[cfg(feature = "attributes")]
     pub struct AutoCrlf;
+    #[cfg(feature = "attributes")]
     impl keys::Validate for AutoCrlf {
-        #[cfg_attr(not(feature = "attributes"), allow(unused_variables))]
         fn validate(&self, value: &BStr) -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
-            #[cfg(feature = "attributes")]
             super::Core::AUTO_CRLF.try_into_autocrlf(value.into())?;
             Ok(())
         }
     }
 
+    #[cfg(feature = "attributes")]
     pub struct Eol;
+    #[cfg(feature = "attributes")]
     impl keys::Validate for Eol {
-        #[cfg_attr(not(feature = "attributes"), allow(unused_variables))]
         fn validate(&self, value: &BStr) -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
-            #[cfg(feature = "attributes")]
             super::Core::EOL.try_into_eol(value.into())?;
             Ok(())
         }
     }
 
+    #[cfg(feature = "attributes")]
     pub struct CheckRoundTripEncoding;
+    #[cfg(feature = "attributes")]
     impl keys::Validate for CheckRoundTripEncoding {
-        #[cfg_attr(not(feature = "attributes"), allow(unused_variables))]
         fn validate(&self, value: &BStr) -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
-            #[cfg(feature = "attributes")]
             super::Core::CHECK_ROUND_TRIP_ENCODING.try_into_encodings(Some(value.into()))?;
             Ok(())
         }

gix/src/config/tree/sections/fetch.rs

@@ -87,11 +87,11 @@ mod validate {
         }
     }
 
+    #[cfg(feature = "attributes")]
     pub struct RecurseSubmodules;
+    #[cfg(feature = "attributes")]
     impl keys::Validate for RecurseSubmodules {
-        #[cfg_attr(not(feature = "attributes"), allow(unused_variables))]
         fn validate(&self, value: &BStr) -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
-            #[cfg(feature = "attributes")]
             {
                 let boolean = gix_config::Boolean::try_from(value).map(|b| b.0);
                 crate::config::tree::Fetch::RECURSE_SUBMODULES.try_into_recurse_submodules(boolean)?;