Merge pull request #2218 from GitoxideLabs/hash

hash: Future Proofing - rewritten commits of #2213

Author: Byron

gix-hash/Cargo.toml

@@ -16,6 +16,9 @@ doctest = false
 test = false
 
 [features]
+default = ["sha1"]
+## Support for SHA-1 digests.
+sha1 = []
 ## Data structures implement `serde::Serialize` and `serde::Deserialize`.
 serde = ["dep:serde", "faster-hex/serde"]
 

gix-hash/src/lib.rs

@@ -9,6 +9,11 @@
 #![cfg_attr(all(doc, feature = "document-features"), feature(doc_cfg, doc_auto_cfg))]
 #![deny(missing_docs, rust_2018_idioms, unsafe_code)]
 
+// Remove this once other hashes (e.g., SHA-256, and potentially others)
+// are supported, and this crate can build without [`ObjectId::Sha1`].
+#[cfg(not(feature = "sha1"))]
+compile_error!("Please set the `sha1` feature flag");
+
 #[path = "oid.rs"]
 mod borrowed;
 pub use borrowed::{oid, Error};

gix-hash/src/object_id.rs

@@ -9,6 +9,7 @@ use crate::{borrowed::oid, Kind, SIZE_OF_SHA1_DIGEST};
 /// An owned hash identifying objects, most commonly `Sha1`
 #[derive(PartialEq, Eq, Ord, PartialOrd, Clone, Copy)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
+#[non_exhaustive]
 pub enum ObjectId {
     /// A SHA 1 hash digest
     Sha1([u8; SIZE_OF_SHA1_DIGEST]),