Skip to content

Conversation

@renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Confidence
Werkzeug (changelog) ==3.0.3 -> ==3.1.4 age confidence
Werkzeug (changelog) ==2.3.8 -> ==3.1.4 age confidence
Werkzeug (changelog) ==1.0.1 -> ==3.1.4 age confidence
werkzeug (changelog) ==2.3.8 -> ==3.1.4 age confidence
werkzeug (changelog) ==3.0.3 -> ==3.1.4 age confidence

GitHub Vulnerability Alerts

CVE-2025-66221

Werkzeug's safe_join function allows path segments with Windows device names. On Windows, there are special device names such as CON, AUX, etc that are implicitly present and readable in every directory. send_from_directory uses safe_join to safely serve files at user-specified paths under a directory. If the application is running on Windows, and the requested path ends with a special device name, the file will be opened successfully, but reading will hang indefinitely.


Release Notes

pallets/werkzeug (Werkzeug)

v3.1.4

Compare Source

Released 2025-11-28

  • safe_join on Windows does not allow special device names. This prevents
    reading from these when using send_from_directory. secure_filename
    already prevented writing to these. :ghsa:hgf8-39gv-g3f2
  • The debugger pin fails after 10 attempts instead of 11. :pr:3020
  • The multipart form parser handles a \r\n sequence at a chunk boundary.
    :issue:3065
  • Improve CPU usage during Watchdog reloader. :issue:3054
  • Request.json annotation is more accurate. :issue:3067
  • Traceback rendering handles when the line number is beyond the available
    source lines. :issue:3044
  • HTTPException.get_response annotation and doc better conveys the
    distinction between WSGI and sans-IO responses. :issue:3056

v3.1.3

Compare Source

Released 2024-11-08

  • Initial data passed to MultiDict and similar interfaces only accepts
    list, tuple, or set when passing multiple values. It had been
    changed to accept any Collection, but this matched types that should be
    treated as single values, such as bytes. :issue:2994
  • When the Host header is not set and Request.host falls back to the
    WSGI SERVER_NAME value, if that value is an IPv6 address it is wrapped
    in [] to match the Host header. :issue:2993

v3.1.2

Compare Source

Released 2024-11-04

  • Improve type annotation for TypeConversionDict.get to allow the type
    parameter to be a callable. :issue:2988
  • Headers does not inherit from MutableMapping, as it is does not
    exactly match that interface. :issue:2989

v3.1.1

Compare Source

Released 2024-11-01

  • Fix an issue that caused str(Request.headers) to always appear empty.
    :issue:2985

v3.1.0

Compare Source

Released 2024-10-31

  • Drop support for Python 3.8. :pr:2966

  • Remove previously deprecated code. :pr:2967

  • Request.max_form_memory_size defaults to 500kB instead of unlimited.
    Non-file form fields over this size will cause a RequestEntityTooLarge
    error. :issue:2964

  • OrderedMultiDict and ImmutableOrderedMultiDict are deprecated.
    Use MultiDict and ImmutableMultiDict instead. :issue:2968

  • Behavior of properties on request.cache_control and
    response.cache_control has been significantly adjusted.

    • Dict values are always str | None. Setting properties will convert
      the value to a string. Setting a property to False is equivalent to
      setting it to None. Getting typed properties will return None if
      conversion raises ValueError, rather than the string. :issue:2980
    • max_age is None if present without a value, rather than -1.
      :issue:2980
    • no_cache is a boolean for requests, it is True instead of
      "*" when present. It remains a string for responses. :issue:2980
    • max_stale is True if present without a value, rather
      than "*". :issue:2980
    • no_transform is a boolean. Previously it was mistakenly always
      None. :issue:2881
    • min_fresh is None if present without a value, rather than
      "*". :issue:2881
    • private is True if present without a value, rather than "*".
      :issue:2980
    • Added the must_understand property. :issue:2881
    • Added the stale_while_revalidate, and stale_if_error
      properties. :issue:2948
    • Type annotations more accurately reflect the values. :issue:2881
  • Support Cookie CHIPS (Partitioned Cookies). :issue:2797

  • Add 421 MisdirectedRequest HTTP exception. :issue:2850

  • Increase default work factor for PBKDF2 to 1,000,000 iterations.
    :issue:2969

  • Inline annotations for datastructures, removing stub files.
    :issue:2970

  • MultiDict.getlist catches TypeError in addition to ValueError
    when doing type conversion. :issue:2976

  • Implement | and |= operators for MultiDict, Headers, and
    CallbackDict, and disallow |= on immutable types. :issue:2977

v3.0.6

Compare Source

Released 2024-10-25

  • Fix how max_form_memory_size is applied when parsing large non-file
    fields. :ghsa:q34m-jh98-gwm2
  • safe_join catches certain paths on Windows that were not caught by
    ntpath.isabs on Python < 3.11. :ghsa:f9vj-2wh5-fj8j

v3.0.5

Compare Source

Released 2024-10-24

  • The Watchdog reloader ignores file closed no write events. :issue:2945
  • Logging works with client addresses containing an IPv6 scope :issue:2952
  • Ignore invalid authorization parameters. :issue:2955
  • Improve type annotation fore SharedDataMiddleware. :issue:2958
  • Compatibility with Python 3.13 when generating debugger pin and the current
    UID does not have an associated name. :issue:2957

v3.0.4

Compare Source

Released 2024-08-21

  • Restore behavior where parsing multipart/x-www-form-urlencoded data with
    invalid UTF-8 bytes in the body results in no form data parsed rather than a
    413 error. :issue:2930
  • Improve parse_options_header performance when parsing unterminated
    quoted string values. :issue:2904
  • Debugger pin auth is synchronized across threads/processes when tracking
    failed entries. :issue:2916
  • Dev server handles unexpected SSLEOFError due to issue in Python < 3.13.
    :issue:2926
  • Debugger pin auth works when the URL already contains a query string.
    :issue:2918

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 2, 2025
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. api: bigquery Issues related to the BigQuery API. api: cloudfunctions Issues related to the Cloud Run functions API. api: cloudsql api: compute Issues related to the Compute Engine API. api: iap Issues related to the Identity-Aware Proxy API. api: memorystore api: monitoring Issues related to the Cloud Monitoring API. labels Dec 2, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a crucial dependency update, upgrading the Werkzeug library to version 3.1.4 across multiple Python sample applications. The primary motivation for this update is to patch a recently identified security vulnerability (CVE-2025-66221) related to the safe_join function on Windows, which could lead to denial-of-service. Beyond the security fix, this update also brings in various bug fixes and minor improvements from the latest Werkzeug releases, ensuring the sample applications benefit from enhanced stability and features.

Highlights

  • Security Update: Upgrades the Werkzeug dependency to v3.1.4 to address CVE-2025-66221, a security vulnerability affecting safe_join on Windows that could lead to denial-of-service.
  • Dependency Consolidation: Standardizes the Werkzeug version across numerous requirements.txt files, updating from various older versions including 3.0.3, 2.3.8, and 1.0.1.
  • Bug Fixes and Improvements: Incorporates several bug fixes and minor enhancements introduced in the Werkzeug 3.1.x release series, improving overall stability and functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the werkzeug dependency to version 3.1.4 across many requirements.txt files to address a security vulnerability. While updating is necessary, the chosen version 3.1.4 introduces breaking changes for several samples.

Specifically, Werkzeug 3.1.4 requires Python 3.9 or newer. Many of the samples are configured to support older Python versions (like 3.7 and 3.8), so this update will cause installation to fail on those versions. In some cases, the update to Werkzeug 3.1.4 is also incompatible with other pinned dependencies like Flask==1.1.4, which requires Werkzeug<2.0.

I've added specific comments on a few files to illustrate the issues. The main recommendations are:

  • For projects supporting Python 3.8+, update to Werkzeug==3.0.4. This version includes the security fix and maintains Python 3.8 compatibility.
  • For projects using older versions of Flask (e.g., 1.x), a simple Werkzeug update is not possible. It requires a more careful upgrade of multiple packages.
  • For projects supporting Python 3.7, please be aware that the Werkzeug 2.3.x series does not seem to have a security patch for this vulnerability. You may need to consider dropping support for Python 3.7 or accepting the risk.

Please review the individual comments for detailed suggestions. The same logic should be applied to all other requirements.txt files changed in this PR.

Comment on lines +3 to +4
Werkzeug==3.1.4; python_version > '3.6'
Werkzeug==3.1.4; python_version < '3.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating Werkzeug to 3.1.4 is problematic as this version requires Python 3.9+. The previous configuration supported older Python versions, and this change would break compatibility for environments using Python < 3.9.

To address the security vulnerability (GHSA-hgf8-39gv-g3f2) while maintaining broader Python version support, I recommend using different versions of Werkzeug depending on the Python version. The vulnerability is patched in version 3.0.4, which supports Python 3.8+.

For Python 3.7, Werkzeug 2.3.8 was used. The security advisory does not list a patch for the 2.3.x series, which implies it might be vulnerable and unpatched. You should consider dropping support for Python 3.7 for this sample if security is a high priority, or accept the risk.

A better approach would be to use version-specific dependencies that are secure and compatible.

Werkzeug==3.0.4; python_version >= '3.8'
Werkzeug==2.3.8; python_version == '3.7'

requests==2.31.0
markupsafe==2.0.1
Werkzeug==1.0.1;
Werkzeug==3.1.4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to Werkzeug==3.1.4 is incompatible with Flask==1.1.4 used in this project. Flask==1.1.4 requires Werkzeug<2.0. This change will break the application.

To address the security vulnerability, both Flask and Werkzeug would need to be updated. However, as the comment on line 1 notes, Flask-Sockets may have compatibility issues with newer versions of Flask. This dependency conflict needs to be resolved carefully. A simple version bump of Werkzeug is not a valid solution here.

Comment on lines +3 to +4
werkzeug==3.1.4; python_version > '3.7'
werkzeug==3.1.4; python_version <= '3.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating werkzeug to 3.1.4 across all Python versions is incorrect. Werkzeug 3.1.4 requires Python 3.9+, so this change will break the application for Python 3.7 and 3.8.

To fix the security vulnerability (GHSA-hgf8-39gv-g3f2) correctly, you should use patched versions that are compatible with the respective Python versions. The vulnerability is patched in 3.0.4 (for Python 3.8+).

For Python 3.7, werkzeug 2.3.8 is likely vulnerable and unpatched. You should consider the security implications of continuing to support Python 3.7 with this package.

werkzeug==3.0.4; python_version > '3.7'
werkzeug==2.3.8; python_version <= '3.7'

Comment on lines +5 to +6
Werkzeug==3.1.4; python_version >= '3.7'
Werkzeug==3.1.4; python_version < '3.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating Werkzeug to 3.1.4 is problematic as this version requires Python 3.9+. The previous configuration, although having some inconsistencies in Python version markers, aimed to support older Python versions. This change will break the setup for Python versions < 3.9.

To correctly address the security vulnerability (GHSA-hgf8-39gv-g3f2), you should use patched versions compatible with each Python version. The vulnerability is patched in version 3.0.4 (for Python 3.8+).

The existing markers seem inconsistent with package requirements. A corrected and secure setup would be as suggested.

Werkzeug==3.0.4; python_version >= '3.8'
Werkzeug==2.3.8; python_version == '3.7'

requests==2.31.0
markupsafe==2.0.1
Werkzeug==1.0.1;
Werkzeug==3.1.4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to Werkzeug==3.1.4 is incompatible with Flask==1.1.4 used in this project. Flask==1.1.4 requires Werkzeug<2.0. This change will break the application.

To address the security vulnerability, both Flask and Werkzeug would need to be updated. However, as the comment on line 1 notes, Flask-Sockets may have compatibility issues with newer versions of Flask. This dependency conflict needs to be resolved carefully. A simple version bump of Werkzeug is not a valid solution here.

functions-framework==3.9.2
google-cloud-documentai==3.0.1
Werkzeug==2.3.8
Werkzeug==3.1.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating Werkzeug to 3.1.4 drops support for Python 3.7 and 3.8, as Werkzeug 3.1.4 requires Python 3.9+. This is a significant breaking change.

To fix the security vulnerability (GHSA-hgf8-39gv-g3f2) while maintaining support for Python 3.8, you should update to Werkzeug==3.0.4. This version is patched and compatible with Python 3.8+.

Note that Werkzeug 2.3.8 (used for Python 3.7) is likely vulnerable and does not have a security patch. You may need to consider dropping support for Python 3.7 to be fully secure.

Werkzeug==3.0.4

Flask==3.0.3
requests==2.31.0
Werkzeug==3.0.3
Werkzeug==3.1.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating Werkzeug from 3.0.3 to 3.1.4 drops support for Python 3.8, as Werkzeug 3.1.4 requires Python 3.9+. This might be an unintended breaking change.

To fix the security vulnerability (GHSA-hgf8-39gv-g3f2) while retaining Python 3.8 support, you should update to Werkzeug==3.0.4. This version contains the security patch and is compatible with Python 3.8.

Werkzeug==3.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. api: bigquery Issues related to the BigQuery API. api: cloudfunctions Issues related to the Cloud Run functions API. api: cloudsql api: compute Issues related to the Compute Engine API. api: iap Issues related to the Identity-Aware Proxy API. api: memorystore api: monitoring Issues related to the Cloud Monitoring API. owlbot:run Add this label to trigger the Owlbot post processor. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants