Skip to content

Commit 576d800

Browse files
committed
prefix missing parameter inspection with "Symfony"
1 parent adc2788 commit 576d800

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

src/main/java/fr/adrienbrault/idea/symfony2plugin/dic/inspection/YamlParameterInspection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ private void invoke(@NotNull final PsiElement psiElement, @NotNull ProblemsHolde
6363
// parameter a always lowercase see #179
6464
parameterName = parameterName.toLowerCase();
6565
if (!ContainerCollectionResolver.hasParameterName(lazyServiceCollector, parameterName)) {
66-
holder.registerProblem(psiElement, "Missing Parameter", ProblemHighlightType.GENERIC_ERROR_OR_WARNING);
66+
holder.registerProblem(psiElement, "Symfony: Missing Parameter", ProblemHighlightType.GENERIC_ERROR_OR_WARNING);
6767
}
6868
}
6969
}

src/main/resources/META-INF/plugin.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<idea-plugin url="https://github.com/Haehnchen/idea-php-symfony2-plugin">
22
<id>fr.adrienbrault.idea.symfony2plugin</id>
33
<name>Symfony Support</name>
4-
<version>0.23.223</version>
4+
<version>0.23.224</version>
55
<vendor email="daniel@espendiller.net" url="http://espend.de?p=fr.adrienbrault.idea.symfony2plugin">espend_de</vendor>
66

77
<description><![CDATA[
@@ -431,7 +431,7 @@
431431
language="XML"
432432
implementationClass="fr.adrienbrault.idea.symfony2plugin.dic.inspection.XmlServiceInstanceInspection"/>
433433

434-
<localInspection groupPath="Symfony" shortName="YamlParameterInspection" displayName="Yaml: Missing Parameter"
434+
<localInspection groupPath="Symfony" shortName="YamlParameterInspection" displayName="Symfony: Missing Parameter"
435435
groupName="Service"
436436
enabledByDefault="true"
437437
level="WARNING"

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/dic/inspection/YamlParameterInspectionTest.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@ public String getTestDataPath() {
1818
}
1919

2020
public void testParameterInspection() {
21-
assertLocalInspectionContains("services.yml", "services:\n %foo_<caret>missing%", "Missing Parameter");
22-
assertLocalInspectionNotContains("services.yml", "services:\n %foo_p<caret>arameter%", "Missing Parameter");
21+
assertLocalInspectionContains("services.yml", "services:\n %foo_<caret>missing%", "Symfony: Missing Parameter");
22+
assertLocalInspectionNotContains("services.yml", "services:\n %foo_p<caret>arameter%", "Symfony: Missing Parameter");
2323

24-
assertLocalInspectionContains("services.yml", "services:\n %Foo_<caret>missing%", "Missing Parameter");
25-
assertLocalInspectionNotContains("services.yml", "services:\n %Foo_p<caret>arameter%", "Missing Parameter");
24+
assertLocalInspectionContains("services.yml", "services:\n %Foo_<caret>missing%", "Symfony: Missing Parameter");
25+
assertLocalInspectionNotContains("services.yml", "services:\n %Foo_p<caret>arameter%", "Symfony: Missing Parameter");
2626

27-
assertLocalInspectionContains("services.yml", "services:\n [ '%Foo_<caret>missing%' ]\n", "Missing Parameter");
28-
assertLocalInspectionContains("services.yml", "services:\n [ \"%Foo_<caret>missing%\" ]\n", "Missing Parameter");
29-
assertLocalInspectionNotContains("services.yml", "services:\n %kernel.root_dir%/../we<caret>b/%webpath_modelmasks%", "Missing Parameter");
27+
assertLocalInspectionContains("services.yml", "services:\n [ '%Foo_<caret>missing%' ]\n", "Symfony: Missing Parameter");
28+
assertLocalInspectionContains("services.yml", "services:\n [ \"%Foo_<caret>missing%\" ]\n", "Symfony: Missing Parameter");
29+
assertLocalInspectionNotContains("services.yml", "services:\n %kernel.root_dir%/../we<caret>b/%webpath_modelmasks%", "Symfony: Missing Parameter");
3030
}
3131

3232
public void testParameterInspectionForEnvMustNotAnnotationAsMissing() {
33-
assertLocalInspectionNotContains("services.yml", "services:\n %env(FO<caret>O)%", "Missing Parameter");
34-
assertLocalInspectionNotContains("services.yml", "services:\n '%env(FO<caret>O)%'", "Missing Parameter");
35-
assertLocalInspectionNotContains("services.yml", "services:\n \"%env(FO<caret>O)%\"", "Missing Parameter");
36-
assertLocalInspectionNotContains("services.yml", "services:\n '%ENV(FO<caret>O)%'", "Missing Parameter");
33+
assertLocalInspectionNotContains("services.yml", "services:\n %env(FO<caret>O)%", "Symfony: Missing Parameter");
34+
assertLocalInspectionNotContains("services.yml", "services:\n '%env(FO<caret>O)%'", "Symfony: Missing Parameter");
35+
assertLocalInspectionNotContains("services.yml", "services:\n \"%env(FO<caret>O)%\"", "Symfony: Missing Parameter");
36+
assertLocalInspectionNotContains("services.yml", "services:\n '%ENV(FO<caret>O)%'", "Symfony: Missing Parameter");
3737
}
3838
}

0 commit comments

Comments
 (0)