[MOB-9326] Use ArgsRegistry as SSOT (#699)

* Use `ArgsRegistry` as SSOT on Android

 * Use a more type-safe implementation instead of `getDeserializedValue`
   and `getRawValue`.
 * Centralize the constant conversion logic in one place, instead of the
   scattered methods and implementations.
 * Reduce the complexity and boilerplate of adding new constant.

* Use `ArgsRegistry` as SSOT on iOS

 * Centralize constants values in `ArgsRegistry`, instead of defining it
   in both `constantsToExport` and `RCTConvert`.

* Remove Deprecated Strings

* Remove Inovation Modes

* Remove `doneButtonText`

* Update Android Unit Tests

Author: TheBuggedYRN

android/src/main/java/com/instabug/reactlibrary/ArgsRegistry.java

@@ -12,6 +12,7 @@
 import com.facebook.react.bridge.ReactMethod;
 import com.instabug.apm.APM;
 import com.instabug.apm.model.ExecutionTrace;
+import com.instabug.apm.model.LogLevel;
 import com.instabug.apm.networking.APMNetworkLogger;
 import com.instabug.bug.BugReporting;
 import com.instabug.library.Feature;
@@ -80,10 +81,9 @@ public void setLogLevel(final String logLevel) {
             @Override
             public void run() {
                 try {
-                    if (ArgsRegistry.getDeserializedValue(logLevel, Integer.class) == null) {
-                        return;
-                    }
-                    APM.setLogLevel((int) ArgsRegistry.getRawValue(logLevel));
+                    final Integer parsedLevel = ArgsRegistry.logLevels.get(logLevel);
+                    if (parsedLevel == null) return;
+                    APM.setLogLevel(parsedLevel);
                 } catch (Exception e) {
                     e.printStackTrace();
                 }

android/src/main/java/com/instabug/reactlibrary/RNInstabugAPMModule.java

@@ -2,8 +2,6 @@
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
-import android.os.Handler;
-import android.os.Looper;
 
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.Callback;
@@ -14,7 +12,6 @@
 import com.facebook.react.bridge.WritableMap;
 import com.instabug.bug.BugReporting;
 import com.instabug.bug.invocation.Option;
-import com.instabug.chat.Replies;
 import com.instabug.library.Feature;
 import com.instabug.library.OnSdkDismissCallback;
 import com.instabug.library.extendedbugreport.ExtendedBugReport;
@@ -27,7 +24,6 @@
 import com.instabug.reactlibrary.utils.MainThreadHandler;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 
 import javax.annotation.Nonnull;
 
@@ -100,8 +96,9 @@ public void setExtendedBugReportMode(final String extendedBugReportMode) {
             @Override
             public void run() {
                 try {
-                    BugReporting.setExtendedBugReportState(
-                            ArgsRegistry.getDeserializedValue(extendedBugReportMode, ExtendedBugReport.State.class));
+                    final ExtendedBugReport.State parsedState = ArgsRegistry.extendedBugReportStates.get(extendedBugReportMode);
+                    if (parsedState == null) return;
+                    BugReporting.setExtendedBugReportState(parsedState);
                 } catch (Exception e) {
                     e.printStackTrace();
                 }
@@ -142,8 +139,9 @@ public void setVideoRecordingFloatingButtonPosition(final String corner) {
             @Override
             public void run() {
                 try {
-                    BugReporting.setVideoRecordingFloatingButtonPosition(
-                            ArgsRegistry.getDeserializedValue(corner, InstabugVideoRecordingButtonPosition.class));
+                    final InstabugVideoRecordingButtonPosition parsedPosition = ArgsRegistry.recordButtonPositions.get(corner);
+                    if (parsedPosition == null) return;
+                    BugReporting.setVideoRecordingFloatingButtonPosition(parsedPosition);
                 } catch (Exception e) {
                     e.printStackTrace();
                 }
@@ -183,28 +181,18 @@ public void run() {
      */
     @ReactMethod
     public void setInvocationEvents(ReadableArray invocationEventValues) {
-
-        try {
-            Object[] objectArray = ArrayUtil.toArray(invocationEventValues);
-            String[] stringArray = Arrays.copyOf(objectArray, objectArray.length, String[].class);
-            final ArrayList<InstabugInvocationEvent> parsedInvocationEvents = new ArrayList<>();
-
-            for (String event : stringArray) {
-                parsedInvocationEvents.add(ArgsRegistry.getDeserializedValue(event, InstabugInvocationEvent.class));
-            }
-            MainThreadHandler.runOnMainThread(new Runnable() {
-                @Override
-                public void run() {
-                    try {
-                        BugReporting.setInvocationEvents(parsedInvocationEvents.toArray(new InstabugInvocationEvent[0]));
-                    } catch (Exception e) {
-                        e.printStackTrace();
-                    }
+        MainThreadHandler.runOnMainThread(new Runnable() {
+            @Override
+            public void run() {
+                try {
+                    final ArrayList<String> keys = ArrayUtil.parseReadableArrayOfStrings(invocationEventValues);
+                    final ArrayList<InstabugInvocationEvent> parsedInvocationEvents = ArgsRegistry.invocationEvents.getAll(keys);
+                    BugReporting.setInvocationEvents(parsedInvocationEvents.toArray(new InstabugInvocationEvent[0]));
+                } catch (Exception e) {
+                    e.printStackTrace();
                 }
-            });
-        } catch (Exception e) {
-            e.printStackTrace();
-        }
+            }
+        });
     }
 
     /**
@@ -215,14 +203,17 @@ public void run() {
     @ReactMethod
     public void setOptions(final ReadableArray optionValues) {
         MainThreadHandler.runOnMainThread(new Runnable() {
+            @SuppressLint("WrongConstant")
             @Override
             public void run() {
                 try {
-                    Object[] objectArray = ArrayUtil.toArray(optionValues);
-                    String[] stringArray = Arrays.copyOf(objectArray, objectArray.length, String[].class);
-                    for (String option : stringArray) {
-                        BugReporting.setOptions((int) ArgsRegistry.getRawValue(option));
+                    final ArrayList<String> keys = ArrayUtil.parseReadableArrayOfStrings(optionValues);
+                    final ArrayList<Integer> options = ArgsRegistry.invocationOptions.getAll(keys);
+
+                    for (int i = 0; i < options.size(); i++) {
+                        BugReporting.setOptions(options.get(i));
                     }
+
                 } catch (Exception e) {
                     e.printStackTrace();
                 }
@@ -267,11 +258,10 @@ public void setFloatingButtonEdge(final String floatingButtonEdge, final int flo
         MainThreadHandler.runOnMainThread(new Runnable() {
             @Override
             public void run() {
+                final InstabugFloatingButtonEdge parsedEdge = ArgsRegistry.floatingButtonEdges
+                        .getOrDefault(floatingButtonEdge, InstabugFloatingButtonEdge.RIGHT);
                 BugReporting.setFloatingButtonOffset(floatingButtonOffset);
-                if (floatingButtonEdge.equals("left"))
-                    BugReporting.setFloatingButtonEdge(InstabugFloatingButtonEdge.LEFT);
-                else
-                    BugReporting.setFloatingButtonEdge(InstabugFloatingButtonEdge.RIGHT);
+                BugReporting.setFloatingButtonEdge(parsedEdge);
             }
         });
     }
@@ -333,20 +323,22 @@ public void run() {
      * @param types
      * @see BugReporting.ReportType
      */
-    @SuppressLint("WrongConstant")
     @ReactMethod
     public void setReportTypes(ReadableArray types) {
-        Object[] objectArray = ArrayUtil.toArray(types);
-        String[] stringArray = Arrays.copyOf(objectArray, objectArray.length, String[].class);
-        final int[] parsedReportTypes = new int[stringArray.length];
-        for (int i = 0; i < stringArray.length; i++) {
-            parsedReportTypes[i] = (int) ArgsRegistry.getRawValue(stringArray[i]);
-        }
         MainThreadHandler.runOnMainThread(new Runnable() {
+            @SuppressLint("WrongConstant")
             @Override
             public void run() {
                 try {
-                    BugReporting.setReportTypes(parsedReportTypes);
+                    final ArrayList<String> keys = ArrayUtil.parseReadableArrayOfStrings(types);
+                    final ArrayList<Integer> types = ArgsRegistry.reportTypes.getAll(keys);
+
+                    final int[] typesInts = new int[types.size()];
+                    for (int i = 0; i < types.size(); i++) {
+                        typesInts[i] = types.get(i);
+                    }
+
+                    BugReporting.setReportTypes(typesInts);
                 } catch (Exception e) {
                     e.printStackTrace();
                 }
@@ -366,10 +358,9 @@ public void show(final String reportType, final ReadableArray options) {
         MainThreadHandler.runOnMainThread(new Runnable() {
             @Override
             public void run() {
-                if (ArgsRegistry.getDeserializedValue(reportType, Integer.class) == null) {
-                    return;
-                }
-                BugReporting.show((int) ArgsRegistry.getRawValue(reportType));
+                final Integer parsedReportType = ArgsRegistry.reportTypes.get(reportType);
+                if (parsedReportType == null) return;
+                BugReporting.show(parsedReportType);
                 setOptions(options);
             }
         });

android/src/main/java/com/instabug/reactlibrary/RNInstabugBugReportingModule.java

@@ -14,6 +14,7 @@
 import com.instabug.reactlibrary.utils.InstabugUtil;
 import com.instabug.reactlibrary.utils.MainThreadHandler;
 
+import java.util.ArrayList;
 import java.util.Arrays;
 
 import javax.annotation.Nonnull;
@@ -37,22 +38,22 @@ public String getName() {
      * @param isEmailRequired set true to make email field required
      * @param actionTypes Bitwise-or of actions
      */
-    @SuppressLint("WrongConstant")
     @ReactMethod
     public void setEmailFieldRequiredForFeatureRequests(final boolean isEmailRequired, final ReadableArray actionTypes) {
         MainThreadHandler.runOnMainThread(new Runnable() {
+            @SuppressLint("WrongConstant")
             @Override
             public void run() {
                 try {
-                    Object[] objectArray = ArrayUtil.toArray(actionTypes);
-                    String[] stringArray = Arrays.copyOf(objectArray, objectArray.length, String[].class);
-                    int[] parsedActionTypes = new int[stringArray.length];
-                    int i = 0;
-                    for (String action : stringArray) {
-                        parsedActionTypes[i++] = (int) ArgsRegistry.getRawValue(action);
+                    final ArrayList<String> keys = ArrayUtil.parseReadableArrayOfStrings(actionTypes);
+                    final ArrayList<Integer> types = ArgsRegistry.actionTypes.getAll(keys);
+
+                    final int[] typesInts = new int[types.size()];
+                    for (int i = 0; i < types.size(); i++) {
+                        typesInts[i] = types.get(i);
                     }
 
-                    FeatureRequests.setEmailFieldRequired(isEmailRequired, parsedActionTypes);
+                    FeatureRequests.setEmailFieldRequired(isEmailRequired, typesInts);
                 } catch (Exception e) {
                     e.printStackTrace();
                 }