Merge pull request #601 from Instabug/fix/discard-attachment-string-keys

[MOB-5448] Add discard attachment string keys

Author: Ali Abdelfattah

CHANGELOG.md

@@ -1,6 +1,7 @@
-## v10.8.0 (2021-08-02)
+## v10.8.0 (2021-08-04)
 
 * Bumps Instabug native SDKs to v10.8
+* Adds string keys for the discard attachment prompt dialog.
 
 ## v10.4.0 (2021-05-10)
 

android/src/main/java/com/instabug/reactlibrary/ArgsRegistry.java

@@ -200,6 +200,11 @@ static void registerCustomTextPlaceHolderKeysArgs(Map<String, Object> args) {
         args.put("betaWelcomeMessageFinishStepContent", InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_FINISH_STEP_CONTENT);
         args.put("liveWelcomeMessageTitle", InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_TITLE);
         args.put("liveWelcomeMessageContent", InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_CONTENT);
+        args.put("discardAlertTitle", InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_TITLE);
+        args.put("discardAlertMessage", InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_BODY);
+        args.put("discardAlertCancel", InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_NEGATIVE_ACTION);
+        args.put("discardAlertAction", InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_POSITIVE_ACTION);
+        args.put("addAttachmentButtonTitleStringName", InstabugCustomTextPlaceHolder.Key.REPORT_ADD_ATTACHMENT_HEADER);
     }
 
     static void registerInstabugReportTypesArgs(Map<String, Object> args) {

android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

@@ -228,6 +228,12 @@ public class RNInstabugReactnativeModule extends ReactContextBaseJavaModule {
     private final String REPORT_QUESTION_DESCRIPTION = "reportQuestionDescription";
     private final String REQUEST_FEATURE_DESCRIPTION = "requestFeatureDescription";
 
+    private final String REPORT_DISCARD_DIALOG_TITLE = "discardAlertTitle";
+    private final String REPORT_DISCARD_DIALOG_BODY = "discardAlertMessage";
+    private final String REPORT_DISCARD_DIALOG_NEGATIVE_ACTION = "discardAlertCancel";
+    private final String REPORT_DISCARD_DIALOG_POSITIVE_ACTION = "discardAlertAction";
+    private final String REPORT_ADD_ATTACHMENT_HEADER = "addAttachmentButtonTitleStringName";
+
     private Application androidApplication;
     private Instabug mInstabug;
     private InstabugInvocationEvent invocationEvent;
@@ -2309,6 +2315,16 @@ private InstabugCustomTextPlaceHolder.Key getStringToKeyConstant(String key) {
                 return InstabugCustomTextPlaceHolder.Key.REPORT_QUESTION_DESCRIPTION;
             case REQUEST_FEATURE_DESCRIPTION:
                 return InstabugCustomTextPlaceHolder.Key.REQUEST_FEATURE_DESCRIPTION;
+            case REPORT_DISCARD_DIALOG_TITLE:
+                return InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_TITLE;
+            case REPORT_DISCARD_DIALOG_BODY:
+                return InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_BODY;
+            case REPORT_DISCARD_DIALOG_NEGATIVE_ACTION:
+                return InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_NEGATIVE_ACTION;
+            case REPORT_DISCARD_DIALOG_POSITIVE_ACTION:
+                return InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_POSITIVE_ACTION;
+            case REPORT_ADD_ATTACHMENT_HEADER:
+                return InstabugCustomTextPlaceHolder.Key.REPORT_ADD_ATTACHMENT_HEADER;
             default:
                 return null;
         }
@@ -2484,6 +2500,12 @@ public Map<String, Object> getConstants() {
         constants.put(REPORT_QUESTION_DESCRIPTION, REPORT_QUESTION_DESCRIPTION);
         constants.put(REQUEST_FEATURE_DESCRIPTION, REQUEST_FEATURE_DESCRIPTION);
 
+        constants.put(REPORT_DISCARD_DIALOG_TITLE, REPORT_DISCARD_DIALOG_TITLE);
+        constants.put(REPORT_DISCARD_DIALOG_BODY, REPORT_DISCARD_DIALOG_BODY);
+        constants.put(REPORT_DISCARD_DIALOG_NEGATIVE_ACTION, REPORT_DISCARD_DIALOG_NEGATIVE_ACTION);
+        constants.put(REPORT_DISCARD_DIALOG_POSITIVE_ACTION, REPORT_DISCARD_DIALOG_POSITIVE_ACTION);
+        constants.put(REPORT_ADD_ATTACHMENT_HEADER, REPORT_ADD_ATTACHMENT_HEADER);
+
         return constants;
     }
 }

index.d.ts

@@ -432,7 +432,12 @@ export enum strings {
   reportBugDescription,
   reportFeedbackDescription,
   reportQuestionDescription,
-  requestFeatureDescription
+  requestFeatureDescription,
+  discardAlertTitle,
+  discardAlertMessage,
+  discardAlertCancel,
+  discardAlertAction,
+  addAttachmentButtonTitleStringName
 }
 
 interface Report {

index.js

@@ -1074,7 +1074,12 @@ const InstabugModule = {
     reportBugDescription: Instabug.reportBugDescription,
     reportFeedbackDescription: Instabug.reportFeedbackDescription,
     reportQuestionDescription: Instabug.reportQuestionDescription,
-    requestFeatureDescription: Instabug.requestFeatureDescription
+    requestFeatureDescription: Instabug.requestFeatureDescription,
+    discardAlertTitle: Instabug.discardAlertTitle,
+    discardAlertMessage: Instabug.discardAlertMessage,
+    discardAlertCancel: Instabug.discardAlertCancel,
+    discardAlertAction: Instabug.discardAlertAction,
+    addAttachmentButtonTitleStringName: Instabug.addAttachmentButtonTitleStringName
   },
 
 };

ios/RNInstabug/InstabugReactBridge.m

@@ -581,9 +581,14 @@ - (NSDictionary *)constantsToExport
               @"reportBugDescription": kIBGReportBugDescriptionStringName,
               @"reportFeedbackDescription": kIBGReportFeedbackDescriptionStringName,
               @"reportQuestionDescription": kIBGReportQuestionDescriptionStringName,
-              @"requestFeatureDescription": kIBGRequestFeatureDescriptionStringName
+              @"requestFeatureDescription": kIBGRequestFeatureDescriptionStringName,
 
-              };
+              @"discardAlertTitle": kIBGDiscardAlertTitle,
+              @"discardAlertMessage": kIBGDiscardAlertMessage,
+              @"discardAlertCancel": kIBGDiscardAlertCancel,
+              @"discardAlertAction": kIBGDiscardAlertAction,
+              @"addAttachmentButtonTitleStringName": kIBGAddAttachmentButtonTitleStringName
+            };
 };
 
 - (void) setBaseUrlForDeprecationLogs {