[MOB-11562] Fix Original Error Handler Not Called (#886)

The original global error handler was initialized in the global scope, so it used to have the default value set by React Native. When users try to set a global error handler themselves, the handler will be ignored, due to the early initialization of `originalHandler`.

This PR fixes this issue by getting the global error handler within Instabug.init scope. Allowing the users to set global error handlers before initializing Instabug. Setting handlers after Instabug's initialization would still not be possible.

Author: TheBuggedYRN

CHANGELOG.md

@@ -1,5 +1,6 @@
 ## Unreleased
 
+- Fixes global error handler not being called.
 - Deprecates Instabug.start in favour of Instabug.init that takes a configuration object for SDK initialization.
 - Deprecates Instabug.setDebugEnabled, Instabug.setSdkDebugLogsLevel, and APM.setLogLevel in favour of debugLogsLevel property, which can be passed to InstabugConfig while initializing the SDK using Instabug.init.
 - Deprecates the enums: sdkDebugLogsLevel and logLevel in favour of a new enum LogLevel.

src/utils/InstabugUtils.ts

@@ -67,23 +67,23 @@ export const getStackTrace = (e: ExtendedError): StackFrame[] => {
   return jsStackTrace;
 };
 
-const originalHandler = ErrorUtils.getGlobalHandler();
-
 export const captureJsErrors = () => {
   if (!process.env.JEST_WORKER_ID) {
     if (__DEV__) {
       return;
     }
   }
 
-  const errorHandler: ErrorHandlerCallback = (e, isFatal) => {
-    const jsStackTrace = getStackTrace(e);
+  const originalErrorHandler = ErrorUtils.getGlobalHandler();
+
+  const instabugErrorHandler: ErrorHandlerCallback = (err) => {
+    const jsStackTrace = getStackTrace(err);
 
     // JSON object to be sent to the native SDK
     const jsonObject = {
-      message: e.name + ' - ' + e.message,
-      e_message: e.message,
-      e_name: e.name,
+      message: err.name + ' - ' + err.message,
+      e_message: err.message,
+      e_name: err.name,
       os: Platform.OS,
       platform: 'react_native',
       exception: jsStackTrace,
@@ -98,19 +98,14 @@ export const captureJsErrors = () => {
     } else {
       NativeCrashReporting.sendJSCrash(jsonObject);
     }
-
-    if (originalHandler && !process.env.JEST_WORKER_ID) {
-      if (Platform.OS === 'ios') {
-        originalHandler(e, isFatal);
-      } else {
-        setTimeout(() => {
-          originalHandler(e, isFatal);
-        }, 500);
-      }
-    }
   };
 
-  ErrorUtils.setGlobalHandler(errorHandler);
+  ErrorUtils.setGlobalHandler((err, isFatal) => {
+    if (!process.env.JEST_WORKER_ID) {
+      originalErrorHandler(err, isFatal);
+    }
+    instabugErrorHandler(err, isFatal);
+  });
 };
 
 export const stringifyIfNotString = (input: unknown) => {