Skip to content

Commit f4708b0

Browse files
SalmaAliSalmaAli
authored andcommitted
🐛 fix wrong ActionTypes class being imported in android
1 parent eceab2f commit f4708b0

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import com.instabug.chat.InstabugChat;
2828
import com.instabug.crash.CrashReporting;
2929
import com.instabug.featuresrequest.FeatureRequests;
30-
import com.instabug.library.ActionType;
30+
import com.instabug.featuresrequest.ActionType;
3131
import com.instabug.library.Feature;
3232
import com.instabug.library.Instabug;
3333
import com.instabug.library.OnSdkDismissCallback;
@@ -1697,19 +1697,23 @@ public void setEmailFieldRequiredForFeatureRequests(boolean isEmailRequired, Rea
16971697
try {
16981698
Object[] objectArray = ArrayUtil.toArray(actionTypes);
16991699
String[] stringArray = Arrays.copyOf(objectArray, objectArray.length, String[].class);
1700+
int[] parsedActionTypes = new int[stringArray.length];
1701+
int i = 0;
17001702
for (String action : stringArray) {
17011703
switch (action) {
17021704
case ACTION_TYPE_REQUEST_NEW_FEATURE:
1703-
FeatureRequests.setEmailFieldRequired(isEmailRequired, ActionType.REQUEST_NEW_FEATURE);
1705+
parsedActionTypes[i++] = ActionType.REQUEST_NEW_FEATURE;
17041706
break;
17051707
case ACTION_TYPE_ADD_COMMENT_TO_FEATURE:
1706-
FeatureRequests.setEmailFieldRequired(isEmailRequired, ActionType.ADD_COMMENT_TO_FEATURE);
1708+
parsedActionTypes[i++] = ActionType.ADD_COMMENT_TO_FEATURE;
17071709
break;
17081710
default:
1709-
FeatureRequests.setEmailFieldRequired(isEmailRequired);
1711+
17101712
break;
17111713
}
17121714
}
1715+
1716+
FeatureRequests.setEmailFieldRequired(isEmailRequired, parsedActionTypes);
17131717
} catch (Exception e) {
17141718
e.printStackTrace();
17151719
}
@@ -1721,8 +1725,6 @@ public void setEmailFieldRequiredForFeatureRequests(boolean isEmailRequired, Rea
17211725
*
17221726
* @param isEmailRequired set true to make email field required
17231727
* @param actionTypes Bitwise-or of actions
1724-
* {@link ActionType#ALL_ACTIONS}
1725-
* {@link ActionType#REPORT_BUG}
17261728
* {@link ActionType#ADD_COMMENT_TO_FEATURE}
17271729
* {@link ActionType#REQUEST_NEW_FEATURE}
17281730
*/
@@ -1733,12 +1735,12 @@ public void setEmailFieldRequiredForActions(boolean isEmailRequired, ReadableArr
17331735
String[] stringArray = Arrays.copyOf(objectArray, objectArray.length, String[].class);
17341736
for (String action : stringArray) {
17351737
switch (action) {
1736-
case ACTION_TYPE_ALL_ACTIONS:
1737-
Instabug.setEmailFieldRequired(isEmailRequired, ActionType.ALL_ACTIONS);
1738-
return;
1739-
case ACTION_TYPE_REPORT_BUG:
1740-
Instabug.setEmailFieldRequired(isEmailRequired, ActionType.REPORT_BUG);
1741-
break;
1738+
// case ACTION_TYPE_ALL_ACTIONS:
1739+
// Instabug.setEmailFieldRequired(isEmailRequired, ActionType.ALL_ACTIONS);
1740+
// return;
1741+
// case ACTION_TYPE_REPORT_BUG:
1742+
// Instabug.setEmailFieldRequired(isEmailRequired, ActionType.REPORT_BUG);
1743+
// break;
17421744
case ACTION_TYPE_REQUEST_NEW_FEATURE:
17431745
Instabug.setEmailFieldRequired(isEmailRequired, ActionType.REQUEST_NEW_FEATURE);
17441746
break;

0 commit comments

Comments
 (0)