fix: ConversionWebhook (#77)

IvanJosipovic · web-flow · commit b1b934ddbcf9 · 2025-08-25T23:36:40.000-07:00
diff --git a/src/Function.SDK.CSharp.Sample/ConversionEndpoint.cs b/src/Function.SDK.CSharp.Sample/ConversionEndpoint.cs
diff --git a/src/Function.SDK.CSharp.Sample/ConversionWebhook.cs b/src/Function.SDK.CSharp.Sample/ConversionWebhook.cs
@@ -9,8 +9,8 @@ public static class ConversionWebhook
     {
         public static V1ConversionReview Convert(V1ConversionReview conversion)
         {
-            if (conversion.Kind == V1alpha2XStorageBucket.KubeKind
-                && conversion.ApiVersion == V1alpha2XStorageBucket.KubeApiVersion
+            if (conversion.Kind == "ConversionReview"
+                && conversion.ApiVersion == "apiextensions.k8s.io/v1"
                 && conversion.Request?.DesiredApiVersion == V1alpha1XStorageBucket.KubeApiVersion
                )
             {
diff --git a/tests/Function.SDK.CSharp.Sample.Tests/ConversionWebhookTests.cs b/tests/Function.SDK.CSharp.Sample.Tests/ConversionWebhookTests.cs
@@ -14,8 +14,8 @@ public void V2toV1ConversionTest()
     {
         var input = new V1ConversionReview()
         {
-            ApiVersion = V1alpha2XStorageBucket.KubeApiVersion,
-            Kind = V1alpha2XStorageBucket.KubeKind,
+            ApiVersion = "apiextensions.k8s.io/v1",
+            Kind = "ConversionReview",
 
             Request = new()
             {

Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,8 @@ public static class ConversionWebhook`
`9`	`9`	`{`
`10`	`10`	`public static V1ConversionReview Convert(V1ConversionReview conversion)`
`11`	`11`	`{`
`12`		`- if (conversion.Kind == V1alpha2XStorageBucket.KubeKind`
`13`		`- && conversion.ApiVersion == V1alpha2XStorageBucket.KubeApiVersion`
	`12`	`+ if (conversion.Kind == "ConversionReview"`
	`13`	`+ && conversion.ApiVersion == "apiextensions.k8s.io/v1"`
`14`	`14`	`&& conversion.Request?.DesiredApiVersion == V1alpha1XStorageBucket.KubeApiVersion`
`15`	`15`	`)`
`16`	`16`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,8 @@ public void V2toV1ConversionTest()`
`14`	`14`	`{`
`15`	`15`	`var input = new V1ConversionReview()`
`16`	`16`	`{`
`17`		`- ApiVersion = V1alpha2XStorageBucket.KubeApiVersion,`
`18`		`- Kind = V1alpha2XStorageBucket.KubeKind,`
	`17`	`+ ApiVersion = "apiextensions.k8s.io/v1",`
	`18`	`+ Kind = "ConversionReview",`
`19`	`19`
`20`	`20`	`Request = new()`
`21`	`21`	`{`