issues to runtests, fix indexing stragglers

Author: rayegun

src/indexutils.jl

@@ -39,7 +39,8 @@ end
 # 1 <= length(szA | szB) <= 2
 # size checks should be done elsewhere.
 function _combinesizes(A, B)
-    if A isa AbstractVector || B isa AbstractVector
+    if (A isa AbstractVector && B isa AbstractMatrix) ||
+        (B isa AbstractVector && A isa AbstractMatrix)
         return (size(A, 1), size(A, 2))
     else
         return size(A)

src/operations/extract.jl

@@ -69,8 +69,8 @@ function extract!(
     I = decrement!(I)
     J = decrement!(J)
     @wraperror LibGraphBLAS.GrB_Matrix_extract(gbpointer(C), mask, getaccum(accum, eltype(C)), gbpointer(parent(A)), I, ni, J, nj, desc)
-    I isa Vector && increment!(I)
-    J isa Vector && increment!(J)
+    I isa AbstractVector && increment!(I)
+    J isa AbstractVector && increment!(J)
     return C
 end
 """
@@ -138,7 +138,7 @@ function extract!(
     desc = _handledescriptor(desc)
     mask === nothing && (mask = C_NULL)
     @wraperror LibGraphBLAS.GrB_Matrix_extract(gbpointer(w), mask, getaccum(accum, eltype(w)), gbpointer(u), I, ni, UInt64[0], 1, desc)
-    I isa Vector && increment!(I)
+    I isa AbstractVector && increment!(I)
     return w
 end
 

test/issues.jl

@@ -5,7 +5,7 @@
         A = GBMatrix([1,1,2,2,3,4,4,5,6,7,7,7], [2,4,5,7,6,1,3,6,3,3,4,5], [1:12...])
         @test A[:, 2] isa GBVector
         @test A[2, :] isa GBVector
-        @test emul(A[:, 2], B) == GBVector([1], [1])
+        @test emul(A[:, 2], B) == GBVector([1], [1], nrows = 7)
 
         # test that GBMatrix <ewise> GBVector is allowed
         # with correct sizes:
@@ -43,3 +43,4 @@
         @test_throws ArgumentError GBMatrix{Int, Int}(10, 10)
         @test_throws ArgumentError GBVector{Int, Int}(10)
     end
+end

test/runtests.jl

@@ -76,6 +76,7 @@ println("$(SuiteSparseGraphBLAS.get_lib())")
     include_test("operatorutils.jl")
     include_test("ops.jl")
     include_test("gbarray.jl")
+    include_test("issues.jl")
     include_test("operations/ewise.jl")
     include_test("operations/kron.jl")
     include_test("operations/map.jl")