Remove kron piracy (#119)

* rm `kron` pirated method

* add test

Author: ericphanson

src/operations/kronecker.jl

@@ -55,16 +55,14 @@ function LinearAlgebra.kron(
     return C
 end
 
-LinearAlgebra.kron!(C::GBVecOrMat, A::VecMatOrTrans, B::GBArrayOrTranspose, op = *; kwargs...) = 
+LinearAlgebra.kron!(C::GBVecOrMat, A::VecMatOrTrans, B::GBArrayOrTranspose, op = *; kwargs...) =
     @_densepack A kron!(C, A, B, op; kwargs...)
-LinearAlgebra.kron!(C::GBVecOrMat, A::GBArrayOrTranspose, B::VecMatOrTrans, op = *; kwargs...) = 
+LinearAlgebra.kron!(C::GBVecOrMat, A::GBArrayOrTranspose, B::VecMatOrTrans, op = *; kwargs...) =
     @_densepack B kron!(C, A, B, op; kwargs...)
-LinearAlgebra.kron!(C::GBVecOrMat, A::VecMatOrTrans, B::VecMatOrTrans, op = *; kwargs...) = 
+LinearAlgebra.kron!(C::GBVecOrMat, A::VecMatOrTrans, B::VecMatOrTrans, op = *; kwargs...) =
     @_densepack A B kron!(C, A, B, op; kwargs...)
 
-LinearAlgebra.kron(A::VecMatOrTrans, B::GBArrayOrTranspose, op = *; kwargs...) = 
+LinearAlgebra.kron(A::VecMatOrTrans, B::GBArrayOrTranspose, op = *; kwargs...) =
     @_densepack A kron(A, B, op; kwargs...)
-LinearAlgebra.kron(A::GBArrayOrTranspose, B::VecMatOrTrans, op = *; kwargs...) = 
+LinearAlgebra.kron(A::GBArrayOrTranspose, B::VecMatOrTrans, op = *; kwargs...) =
     @_densepack B kron(A, B, op; kwargs...)
-LinearAlgebra.kron(A::VecMatOrTrans, B::VecMatOrTrans, op = *; kwargs...) = 
-    @_densepack A B kron(A, B, op; kwargs...)

test/operations/kron.jl

@@ -11,4 +11,10 @@
     o2 = kron(m1, n1; mask, desc=Descriptor(structural_mask=true, complement_mask=true))
     @test o2[20, 5] === getfill(o2) #We don't want values in masked out area
     @test o2[1:2:15, :] == o1[1:2:15, :] #The rest should match, test indexing too.
+
+    # Ensure we don't break usual `kron`
+    # https://github.com/JuliaSparse/SuiteSparseGraphBLAS.jl/issues/118
+    A = zeros(2,3)
+    B = rand(3,4)
+    @test kron(A,B) isa Matrix{Float64}
 end