fix test 001

Author: MagicalTux

git2_repository.c

@@ -147,7 +147,7 @@ static PHP_METHOD(Repository, clone) {
 	git2_repository_object_t *intern;
 	git_clone_options opts_libgit2 = GIT_CLONE_OPTIONS_INIT;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ssh", &url, &url_len, &local_path, &local_path_len, &opts) == FAILURE)
+	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ss|h", &url, &url_len, &local_path, &local_path_len, &opts) == FAILURE)
 		return;
 
 	if (opts != NULL) {

git2_tests/001_pull_anonymous.php

@@ -1,30 +1,15 @@
 <?php
-exit; // XXX TEST DISABLED XXX (fails, need to check why, maybe initial checkout should be done through git_clone())
 
 $tmp = sys_get_temp_dir().'/php-git2_test';
 
-$repo = Git2\Repository::init_ext($tmp, ['flags' => Git2\Repository::INIT_MKDIR]);
-if (!$repo) {
-	echo "Failed to initialize repo in $tmp\n";
-	exit(1);
+if (file_exists($tmp)) {
+	echo "Skipping test - Remove $tmp to run test - rm -fr ".escapeshellarg($tmp)."\n";
+	exit(0); // skip test
 }
 
-// config repo
-$config = $repo->config();
-$config->set_string('branch.master.remote', 'origin');
-$config->set_string('branch.master.merge', 'refs/heads/master');
-$config_array = $config->export();
+echo "Cloning repository...\n";
+$repo = Git2\Repository::clone('https://github.com/MagicalTux/php-git2.git', $tmp);
 
-
-echo "Fetching remote...\n";
-#$remote = Git2\Remote::create_anonymous($repo, 'https://github.com/MTYoujou/php-git2.git');
-if (!isset($config_array['remote.origin.url'])) {
-	$remote = Git2\Remote::create_with_fetchspec($repo, 'origin', 'https://github.com/MTYoujou/php-git2.git', '+refs/heads/*:refs/remotes/origin/*');
-} else {
-	$remote = Git2\Remote::lookup_name($repo, 'origin');
-}
-#var_dump($remote->connect(false));
-var_dump($remote->fetch(['+refs/*', 'refs/*']));
 #var_dump($repo->checkout_head());
 var_dump($repo->head());