Fixing issue with pipeline milestone closing not using right version number (#3755)

Author: Keboo

.github/workflows/release.yml

@@ -258,14 +258,15 @@ jobs:
         steps:
             # Doing a checkout, until this issue is resolved.
             # https://github.com/valeriobelli/gh-milestone/issues/15
+            # As of version 2.1.0 the -R doesn't appear to output valid json when filtering. So still using the checkout.
             - uses: actions/checkout@v4
 
             - name: Close Milestone
               run: |
                   gh extension install valeriobelli/gh-milestone
                   Write-Host "Using extension version $(gh milestone --version)"
                   $milestones = $(gh milestone list --json number,title) | ConvertFrom-Json
-                  $milestoneNumber = ($milestones | Where-Object { $_.title -eq "5.1.0" }).number
+                  $milestoneNumber = ($milestones | Where-Object { $_.title -eq "${{ inputs.milestone }}" }).number
                   gh milestone edit $milestoneNumber --state closed
               env:
                 GITHUB_TOKEN: ${{ secrets.SA_PAT }}
@@ -277,7 +278,7 @@ jobs:
         environment: production
 
         permissions:
-            actions: write
+          actions: write
 
         steps:
             # Checkout is needed so that we can update the get_versions.yml file