Revert "Limit operands to integer types"

rvermeulen · rvermeulen · commit e5881a98e07c · 2024-02-08T15:17:39.000-08:00
This reverts commit f9915445ef206ad3a0d91ecb92547abd50b0a804. This is already addressed in PR github#490
diff --git a/cpp/common/src/codingstandards/cpp/Overflow.qll b/cpp/common/src/codingstandards/cpp/Overflow.qll
@@ -14,7 +14,6 @@ import semmle.code.cpp.valuenumbering.GlobalValueNumbering
  */
 class InterestingOverflowingOperation extends Operation {
   InterestingOverflowingOperation() {
-    forex(Expr operand | operand = this.getAnOperand() | operand.getUnderlyingType() instanceof IntegralType) and
     // Might overflow or underflow
     (
       exprMightOverflowNegatively(this)

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@ import semmle.code.cpp.valuenumbering.GlobalValueNumbering`
`14`	`14`	`*/`
`15`	`15`	`class InterestingOverflowingOperation extends Operation {`
`16`	`16`	`InterestingOverflowingOperation() {`
`17`		`- forex(Expr operand \| operand = this.getAnOperand() \| operand.getUnderlyingType() instanceof IntegralType) and`
`18`	`17`	`// Might overflow or underflow`
`19`	`18`	`(`
`20`	`19`	`exprMightOverflowNegatively(this)`