Skip to content

Commit b590d64

Browse files
yt-msMidnighter
authored andcommitted
fix: PR feedback
1 parent bb84ce9 commit b590d64

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/structurizr/view/dynamic_view.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def add(
9696
9797
Examples:
9898
Example of a request/response, assuming a single relationship in the model:
99-
99+
100100
dynamic_view.add(container1, container2, "Requests data from")
101101
dynamic_view.add(container2, container1, "Sends response back to")
102102
@@ -157,7 +157,7 @@ def subsequence(self):
157157
self.sequence_number.end_subsequence()
158158

159159
@contextmanager
160-
def parallel_sequence(self, continue_numbering: bool):
160+
def parallel_sequence(self, *, continue_numbering: bool = False):
161161
r"""
162162
Start a context-managed parallel sequence.
163163
@@ -181,10 +181,10 @@ def parallel_sequence(self, continue_numbering: bool):
181181
you would do:
182182
183183
dynamic_view.add(a, b) # Will be order "1"
184-
with dynamic_view.parallel_sequence(False):
184+
with dynamic_view.parallel_sequence():
185185
dynamic_view.add(b, c) # "2"
186186
dynamic_view.add(c, e) # "3"
187-
with dynamic_view.parallel_sequence(True):
187+
with dynamic_view.parallel_sequence(continue_numbering=True):
188188
dynamic_view.add(b, d) # "2" again
189189
dynamic_view.add(d, e) # "3"
190190
dynamiic_view.add(e, f) # "4"
@@ -250,6 +250,8 @@ def _find_relationship(
250250
destination: Element,
251251
technology: Optional[str],
252252
) -> Tuple[Optional[Relationship], bool]:
253+
"""Return the best matching relationship and whether it is a response."""
254+
253255
# First preference is exactly matching description
254256
rel = next(
255257
(

tests/unit/view/test_dynamic_view.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,10 +308,10 @@ def test_parallel_sequencing(empty_view: DynamicView):
308308
e.uses(f)
309309

310310
r1 = empty_view.add(a, b)
311-
with empty_view.parallel_sequence(False):
311+
with empty_view.parallel_sequence():
312312
r2 = empty_view.add(b, c)
313313
r3 = empty_view.add(c, e)
314-
with empty_view.parallel_sequence(True):
314+
with empty_view.parallel_sequence(continue_numbering=True):
315315
r4 = empty_view.add(b, d)
316316
r5 = empty_view.add(d, e)
317317
r6 = empty_view.add(e, f)

0 commit comments

Comments
 (0)