Convert lessons external link icon to icon button

Author: MihaiCristianCondrea

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/AndroidStudioFragment.java

@@ -34,6 +34,7 @@
 import com.d4rk.androidtutorials.java.databinding.ItemAndroidStudioLessonBinding;
 import com.google.android.gms.ads.AdListener;
 import com.google.android.gms.ads.LoadAdError;
+import com.google.android.material.button.MaterialButton;
 import com.google.android.material.card.MaterialCardView;
 import com.google.android.material.shape.CornerFamily;
 import com.google.android.material.shape.ShapeAppearanceModel;
@@ -427,15 +428,15 @@ static class LessonHolder extends RecyclerView.ViewHolder {
             final AppCompatImageView icon;
             final MaterialTextView title;
             final MaterialTextView summary;
-            final AppCompatImageView externalIcon;
+            final MaterialButton externalButton;
 
             LessonHolder(@NonNull ItemAndroidStudioLessonBinding binding) {
                 super(binding.getRoot());
                 card = binding.lessonCard;
                 icon = binding.lessonIcon;
                 title = binding.lessonTitle;
                 summary = binding.lessonSummary;
-                externalIcon = binding.lessonExternalIcon;
+                externalButton = binding.lessonExternalIcon;
             }
 
             void bind(Lesson lesson, boolean first, boolean last) {
@@ -452,7 +453,13 @@ void bind(Lesson lesson, boolean first, boolean last) {
                 } else {
                     summary.setVisibility(View.GONE);
                 }
-                externalIcon.setVisibility(lesson.opensInBrowser ? View.VISIBLE : View.GONE);
+                boolean showExternalButton = lesson.opensInBrowser && lesson.intent != null;
+                externalButton.setVisibility(showExternalButton ? View.VISIBLE : View.GONE);
+                if (showExternalButton) {
+                    externalButton.setOnClickListener(v -> v.getContext().startActivity(lesson.intent));
+                } else {
+                    externalButton.setOnClickListener(null);
+                }
                 itemView.setOnClickListener(v -> {
                     if (lesson.intent != null) {
                         v.getContext().startActivity(lesson.intent);

app/src/main/res/layout/item_android_studio_lesson.xml

@@ -45,14 +45,20 @@
                 android:textAppearance="@style/TextAppearance.Material3.BodySmall" />
         </androidx.appcompat.widget.LinearLayoutCompat>
 
-        <androidx.appcompat.widget.AppCompatImageView
+        <com.google.android.material.button.MaterialButton
             android:id="@+id/lesson_external_icon"
-            android:layout_width="24dp"
-            android:layout_height="24dp"
+            style="@style/Widget.Material3.Button.IconButton"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
             android:layout_marginStart="12dp"
-            android:contentDescription="@null"
-            android:importantForAccessibility="no"
-            app:srcCompat="@drawable/ic_open_in_new"
-            android:visibility="gone" />
+            android:contentDescription="@string/lesson_open_in_browser"
+            android:tooltipText="@string/lesson_open_in_browser"
+            android:visibility="gone"
+            android:text="@null"
+            android:minHeight="0dp"
+            android:minWidth="0dp"
+            app:icon="@drawable/ic_open_in_new"
+            app:iconPadding="0dp"
+            app:iconSize="24dp" />
     </androidx.appcompat.widget.LinearLayoutCompat>
 </com.google.android.material.card.MaterialCardView>

app/src/main/res/values/strings.xml

@@ -10,6 +10,7 @@
     <string name="menu">Menu</string>
     <string name="press_back_again_to_exit">Press back again to exit</string>
     <string name="error_no_app_for_link">No app found to open this link.</string>
+    <string name="lesson_open_in_browser">Open lesson in browser</string>
 
     <string name="welcome">Welcome</string>
     <string name="summary_browse_terms_of_service_and_privacy_policy">Read and agree to the Terms of Service and Privacy Policy to continue</string>