Skip to content

Commit 2e83f18

Browse files
authored
refactor: rename main.ns.ts to main.tns.ts (#169)
The file was named `main.ns.ts` because of reasons explained in #102 (comment). However, it can be included in the TS build from the `files` property in `tsconfig.tns.json`. follows up #168 fixes #102
1 parent fba2514 commit 2e83f18

File tree

8 files changed

+17
-16
lines changed

8 files changed

+17
-16
lines changed
File renamed without changes.

src/add-ns/_ns-files/__sourceDir__/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"android": {
33
"v8Flags": "--expose_gc"
44
},
5-
"main": "<%= main %>.ns.js",
5+
"main": "<%= main %><%= nsext %>.js",
66
"name": "migration-ng",
77
"version": "4.1.0"
8-
}
8+
}

src/add-ns/_ns-files/tsconfig__nsext__.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
]
1515
}
1616
},
17-
"exclude": [
18-
"**/*<%= nsext %>.ts",
19-
"**/*.android.ts",
20-
"**/*.ios.ts"
17+
"files": [
18+
"src/main<%= nsext %>.ts"
2119
]
2220
}

src/add-ns/index_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ describe('Add {N} schematic', () => {
4545
expect(files.includes('/nsconfig.json')).toBeTruthy();
4646
expect(files.includes('/tsconfig.tns.json')).toBeTruthy();
4747
expect(files.includes('/foo/src/app.css')).toBeTruthy();
48-
expect(files.includes('/foo/src/main.ns.ts')).toBeTruthy();
48+
expect(files.includes('/foo/src/main.tns.ts')).toBeTruthy();
4949
expect(files.includes('/foo/src/package.json')).toBeTruthy();
5050
expect(files.includes('/foo/src/app/app.module.tns.ts')).toBeTruthy();
5151
expect(files.includes('/foo/src/app/app.component.tns.ts')).toBeTruthy();
File renamed without changes.

src/ng-new/shared/_files/__sourcedir__/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"android": {
33
"v8Flags": "--expose_gc"
44
},
5-
"main": "main.ns.js",
5+
"main": "main.tns.js",
66
"name": "migration-ng",
77
"version": "4.1.0"
8-
}
8+
}
Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
{
2-
"extends": "./tsconfig",
3-
"compilerOptions": {
4-
"module": "es2015",
5-
"moduleResolution": "node"
6-
}
7-
}
2+
"extends": "./tsconfig.json",
3+
"compilerOptions": {
4+
"module": "es2015",
5+
"moduleResolution": "node"
6+
},
7+
"files": [
8+
"src/main.tns.ts"
9+
]
10+
}

src/ng-new/shared/index_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('Shared Application Schematic', () => {
2828
expect(files.indexOf('/foo/tsconfig.tns.json')).toBeGreaterThanOrEqual(0);
2929

3030
expect(files.indexOf('/foo/src/package.json')).toBeGreaterThanOrEqual(0);
31-
expect(files.indexOf('/foo/src/main.ns.ts')).toBeGreaterThanOrEqual(0);
31+
expect(files.indexOf('/foo/src/main.tns.ts')).toBeGreaterThanOrEqual(0);
3232
expect(files.indexOf('/foo/src/app/app.module.ts')).toBeGreaterThanOrEqual(0);
3333

3434
expect(files.indexOf('/foo/src/app/app.component.ts')).toBeGreaterThanOrEqual(0);

0 commit comments

Comments
 (0)