fixed tests... I think.

Author: ljonesfl

composer.json

@@ -33,7 +33,8 @@
     },
     "autoload-dev": {
       "psr-4": {
-        "Mvc\\": "tests/Mvc"
+        "Mvc\\": "tests/Mvc",
+        "Tests\\": "tests/Tests"
       }
     },
     "extra": {

examples/views/Base/index.php

@@ -2,4 +2,4 @@
 
 ## Header 2
 
-This is a test.
+This is a test.

examples/views/Base/index.md examples/views/base/index.mdexamples/views/Base/index.md renamed to examples/views/base/index.md

@@ -0,0 +1,2 @@
+<h2><?=$var_one?></h2>
+<p><?=$two?> + <?=$three?> = <?= ($two + $three) ?></p>

examples/views/base/index.php

@@ -1,3 +1,4 @@
+[![CI](https://github.com/Neuron-PHP/mvc/actions/workflows/ci.yml/badge.svg)](https://github.com/Neuron-PHP/mvc/actions)
 # Neuron-PHP MVC
 
 A lightweight MVC (Model-View-Controller) framework component for PHP 8.4+ that provides core MVC functionality including controllers, views, routing integration, request handling, and a powerful view caching system.

readme.md

@@ -7,6 +7,7 @@
 use Neuron\Routing\Router;
 use Neuron\Routing\RouteMap;
 use PHPUnit\Framework\TestCase;
+use Tests\Mock\MockRouter;
 
 /**
  * Unit tests for the UrlHelper class.
@@ -16,26 +17,20 @@
  */
 class UrlHelperTest extends TestCase
 {
-	private Router $router;
+	private MockRouter $router;
 	private UrlHelper $urlHelper;
 
 	protected function setUp(): void
 	{
 		parent::setUp();
 
-		// Create a fresh router instance for testing
-		$this->router = new Router();
+		// Create a mock router instance for testing
+		$this->router = new MockRouter();
 		$this->urlHelper = new UrlHelper( $this->router );
 
 		// Set up Registry for URL generation
 		$registry = Registry::getInstance();
 		$registry->set( 'Base.Url', 'https://example.com' );
-
-		// Skip tests if the Router doesn't have the required URL helper methods
-		if( !method_exists( $this->router, 'generateUrl' ) )
-		{
-			$this->markTestSkipped( 'Router URL helper methods not available. Install neuron-php/routing dev version.' );
-		}
 	}
 
 	protected function tearDown(): void
@@ -56,9 +51,7 @@ private function createMockRoute( string $name, string $path ): RouteMap
 	public function testRoutePathGeneratesRelativeUrl(): void
 	{
 		// Arrange
-		$route = $this->createMockRoute( 'user_profile', '/users/:id' );
-		$this->router->get( '/users/:id', function() { return 'test'; } )
-		              ->setName( 'user_profile' );
+		$this->router->addNamedRoute( 'user_profile', '/users/:id' );
 
 		// Act
 		$url = $this->urlHelper->routePath( 'user_profile', ['id' => 123] );
@@ -70,9 +63,7 @@ public function testRoutePathGeneratesRelativeUrl(): void
 	public function testRouteUrlGeneratesAbsoluteUrl(): void
 	{
 		// Arrange
-		$route = $this->createMockRoute( 'user_profile', '/users/:id' );
-		$this->router->get( '/users/:id', function() { return 'test'; } )
-		              ->setName( 'user_profile' );
+		$this->router->addNamedRoute( 'user_profile', '/users/:id' );
 
 		// Act
 		$url = $this->urlHelper->routeUrl( 'user_profile', ['id' => 123] );
@@ -102,8 +93,7 @@ public function testRouteUrlReturnsNullForMissingRoute(): void
 	public function testRouteExistsReturnsTrueForExistingRoute(): void
 	{
 		// Arrange
-		$this->router->get( '/users/:id', function() { return 'test'; } )
-		              ->setName( 'user_profile' );
+		$this->router->addNamedRoute( 'user_profile', '/users/:id' );
 
 		// Act & Assert
 		$this->assertTrue( $this->urlHelper->routeExists( 'user_profile' ) );
@@ -118,8 +108,7 @@ public function testRouteExistsReturnsFalseForMissingRoute(): void
 	public function testMagicMethodPathGeneration(): void
 	{
 		// Arrange
-		$this->router->get( '/users/:id', function() { return 'test'; } )
-		              ->setName( 'user_profile' );
+		$this->router->addNamedRoute( 'user_profile', '/users/:id' );
 
 		// Act
 		$url = $this->urlHelper->userProfilePath( ['id' => 456] );
@@ -131,8 +120,7 @@ public function testMagicMethodPathGeneration(): void
 	public function testMagicMethodUrlGeneration(): void
 	{
 		// Arrange
-		$this->router->get( '/users/:id', function() { return 'test'; } )
-		              ->setName( 'user_profile' );
+		$this->router->addNamedRoute( 'user_profile', '/users/:id' );
 
 		// Act
 		$url = $this->urlHelper->userProfileUrl( ['id' => 456] );
@@ -144,8 +132,7 @@ public function testMagicMethodUrlGeneration(): void
 	public function testMagicMethodWithComplexRouteName(): void
 	{
 		// Arrange
-		$this->router->get( '/admin/users/:id/posts/:post_id', function() { return 'test'; } )
-		              ->setName( 'admin_user_posts' );
+		$this->router->addNamedRoute( 'admin_user_posts', '/admin/users/:id/posts/:post_id' );
 
 		// Act
 		$url = $this->urlHelper->adminUserPostsPath( ['id' => 1, 'post_id' => 2] );
@@ -167,10 +154,8 @@ public function testMagicMethodThrowsExceptionForInvalidMethod(): void
 	public function testGetAvailableRoutesReturnsNamedRoutes(): void
 	{
 		// Arrange
-		$this->router->get( '/users', function() { return 'index'; } )
-		              ->setName( 'users_index' );
-		$this->router->post( '/users', function() { return 'create'; } )
-		              ->setName( 'users_create' );
+		$this->router->addNamedRoute( 'users_index', '/users', 'GET' );
+		$this->router->addNamedRoute( 'users_create', '/users', 'POST' );
 
 		// Act
 		$routes = $this->urlHelper->getAvailableRoutes();
@@ -202,8 +187,7 @@ public function testGetSetRouter(): void
 	public function testRouteWithoutParametersGeneratesCorrectUrl(): void
 	{
 		// Arrange
-		$this->router->get( '/about', function() { return 'about'; } )
-		              ->setName( 'about' );
+		$this->router->addNamedRoute( 'about', '/about' );
 
 		// Act
 		$url = $this->urlHelper->routePath( 'about' );
@@ -215,8 +199,7 @@ public function testRouteWithoutParametersGeneratesCorrectUrl(): void
 	public function testRouteWithMultipleParameters(): void
 	{
 		// Arrange
-		$this->router->get( '/users/:id/posts/:post_id/comments/:comment_id', function() { return 'comment'; } )
-		              ->setName( 'user_post_comment' );
+		$this->router->addNamedRoute( 'user_post_comment', '/users/:id/posts/:post_id/comments/:comment_id' );
 
 		// Act
 		$url = $this->urlHelper->routePath( 'user_post_comment', [
@@ -236,8 +219,7 @@ public function testAbsoluteUrlWithoutBaseUrlInRegistry(): void
 		$originalBaseUrl = $registry->get( 'Base.Url' );
 		$registry->set( 'Base.Url', null );
 
-		$this->router->get( '/users/:id', function() { return 'test'; } )
-		              ->setName( 'user_profile' );
+		$this->router->addNamedRoute( 'user_profile', '/users/:id' );
 
 		// Act
 		$url = $this->urlHelper->routeUrl( 'user_profile', ['id' => 123] );

tests/Mvc/Helpers/UrlHelperTest.php

@@ -0,0 +1,117 @@
+<?php
+
+namespace Tests\Mock;
+
+use Neuron\Routing\Router;
+use Neuron\Routing\RouteMap;
+
+/**
+ * Mock Router for testing URL helpers.
+ * 
+ * This router implements the URL helper methods needed for testing,
+ * even when the vendor routing package doesn't have them.
+ */
+class MockRouter extends Router
+{
+	private array $namedRoutes = [];
+
+	/**
+	 * Override to store routes with names for testing
+	 */
+	public function get( string $Route, $function, ?string $Filter = null ): RouteMap
+	{
+		$route = parent::get( $Route, $function, $Filter );
+		return $route;
+	}
+
+	/**
+	 * Override to store routes with names for testing
+	 */
+	public function post( string $Route, $function, ?string $Filter = null ): RouteMap
+	{
+		$route = parent::post( $Route, $function, $Filter );
+		return $route;
+	}
+
+	/**
+	 * Store a named route for testing
+	 */
+	public function addNamedRoute( string $name, string $path, string $method = 'GET' ): MockRouter
+	{
+		$this->namedRoutes[$name] = [
+			'name' => $name,
+			'path' => $path,
+			'method' => $method
+		];
+		return $this;
+	}
+
+	/**
+	 * Find a route by name (for URL helper testing)
+	 */
+	public function getRouteByName( string $name ): ?RouteMap
+	{
+		if( !isset( $this->namedRoutes[$name] ) )
+		{
+			return null;
+		}
+
+		$routeData = $this->namedRoutes[$name];
+		$route = new RouteMap( $routeData['path'], function() { return 'test'; } );
+		$route->setName( $name );
+		
+		return $route;
+	}
+
+	/**
+	 * Generate URL from named route (for URL helper testing)
+	 */
+	public function generateUrl( string $name, array $parameters = [], bool $absolute = false ): ?string
+	{
+		$route = $this->getRouteByName( $name );
+		
+		if( !$route )
+		{
+			return null;
+		}
+
+		$path = $route->getPath();
+		
+		// Replace route parameters with actual values
+		foreach( $parameters as $key => $value )
+		{
+			$path = str_replace( ':' . $key, $value, $path );
+		}
+
+		// If absolute URL requested, prepend base URL
+		if( $absolute )
+		{
+			$baseUrl = \Neuron\Patterns\Registry::getInstance()->get( 'Base.Url' );
+			if( $baseUrl )
+			{
+				return rtrim( $baseUrl, '/' ) . $path;
+			}
+		}
+
+		return $path;
+	}
+
+	/**
+	 * Get all named routes (for URL helper testing)
+	 */
+	public function getAllNamedRoutes(): array
+	{
+		$routes = [];
+		
+		foreach( $this->namedRoutes as $name => $routeData )
+		{
+			$routes[] = [
+				'name' => $name,
+				'method' => $routeData['method'],
+				'path' => $routeData['path']
+			];
+		}
+		
+		return $routes;
+	}
+}

tests/Tests/Mock/MockRouter.php

@@ -7,7 +7,7 @@
   </coverage>
   <testsuites>
     <testsuite name="unit">
-        <directory>mvc</directory>
+        <directory>Mvc</directory>
     </testsuite>
   </testsuites>
 </phpunit>