Skip to content

Commit e028281

Browse files
committed
Fix wrong comment position, when generating comments for longer contracts.
1 parent 14432f5 commit e028281

File tree

5 files changed

+1219
-23
lines changed

5 files changed

+1219
-23
lines changed

package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,16 @@
3636
],
3737
"license": "MIT",
3838
"devDependencies": {
39+
"@babel/core": "^7.1.2",
40+
"@babel/register": "^7.0.0",
3941
"babel-cli": "^6.26.0",
4042
"babel-eslint": "^8.2.5",
4143
"babel-plugin-istanbul": "^4.1.6",
4244
"babel-preset-env": "^1.7.0",
4345
"babel-register": "^6.26.0",
4446
"babel-tape-runner": "^2.0.1",
4547
"coveralls": "^3.0.2",
48+
"electron": "^3.0.2",
4649
"eslint": "^5.0.1",
4750
"eslint-config-strongloop": "^2.1.0",
4851
"istanbul": "^0.4.5",
@@ -51,6 +54,7 @@
5154
"tape": "^4.9.1"
5255
},
5356
"dependencies": {
57+
"@babel/polyfill": "^7.0.0",
5458
"mustache": "^2.3.0",
5559
"solidity-parser-antlr": "^0.3.0"
5660
},

src/index.es6

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ function hasComment(contract, line) {
5757
}
5858

5959
function insertComment(contract, node) {
60-
let comment = generator.generate(node);
60+
let comment = generator.generate(node).trim();
6161
if (!comment) return;
6262
if (hasComment(contract, node.loc.start.line)) return;
6363
let commentLines = comment.split('\n');

src/lib/contract/contract.es6

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@ export class Contract {
7272
let offsetAmount = 0;
7373
for (let offset in this.offsets) {
7474
if (this.offsets.hasOwnProperty(offset)) {
75-
if (line >= offset) {
76-
offsetAmount += this.offsets[offset];
77-
}
75+
offsetAmount += this.offsets[offset];
7876
}
7977
}
8078
return offsetAmount;

test/lib/contract/contract.test.es6

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,14 @@ test('Insert text before', (t) => {
6060
});
6161

6262
test('Insert text before with offset', (t) => {
63-
t.plan(4);
63+
t.plan(5);
6464
let contract =new Contract(['line1', 'line2']);
6565
contract.insertTextBefore('test1\nbla', 0);
6666
t.equal(contract.getLineAt(0), 'test1');
6767
t.equal(contract.getLineAt(1), 'bla');
68-
contract.insertTextBefore('offset', 0);
6968
t.equal(contract.offset(0), 2);
69+
contract.insertTextBefore('offset', 0);
70+
t.equal(contract.offset(0), 3);
7071
t.equal(contract.getLineAt(2), 'offset');
7172
});
7273

0 commit comments

Comments
 (0)