Simplified checks for login status isSuccess

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>

Author: mgaffigan

client/src/com/mirth/connect/client/ui/LoginPanel.java

@@ -451,7 +451,7 @@ public Void doInBackground() {
                     }
 
                     // If SUCCESS or SUCCESS_GRACE_PERIOD
-                    if ((loginStatus != null) && ((loginStatus.getStatus() == LoginStatus.Status.SUCCESS) || (loginStatus.getStatus() == LoginStatus.Status.SUCCESS_GRACE_PERIOD))) {
+                    if (loginStatus != null && loginStatus.isSuccess()) {
                         if (!handleSuccess(loginStatus)) {
                             LoginPanel.getInstance().setVisible(false);
                             LoginPanel.getInstance().initialize(PlatformUI.SERVER_URL, PlatformUI.CLIENT_VERSION, "", "");
@@ -469,7 +469,7 @@ public Void doInBackground() {
 
                                 loginStatus = plugin.authenticate(LoginPanel.this, client, updatedUsername, loginStatus);
 
-                                if ((loginStatus != null) && ((loginStatus.getStatus() == LoginStatus.Status.SUCCESS) || (loginStatus.getStatus() == LoginStatus.Status.SUCCESS_GRACE_PERIOD))) {
+                                if (loginStatus != null && loginStatus.isSuccess()) {
                                     errorOccurred = false;
                                     if (!handleSuccess(loginStatus)) {
                                         LoginPanel.getInstance().setVisible(false);

server/src/com/mirth/connect/model/LoginStatus.java

@@ -43,4 +43,8 @@ public String getMessage() {
     public String getUpdatedUsername() {
         return updatedUsername;
     }
+
+    public boolean isSuccess() {
+        return status == Status.SUCCESS || status == Status.SUCCESS_GRACE_PERIOD;
+    }
 }